From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7341C55179 for ; Thu, 29 Oct 2020 11:33:30 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 672CE20719 for ; Thu, 29 Oct 2020 11:33:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="VINkT39G"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=st.com header.i=@st.com header.b="wuuikyCX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 672CE20719 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=c6WUY2BG40grMKcKYZFvG+hvmyUbpsxUhvKQcO3ZjcY=; b=VINkT39G4FYbFf1IhcMt09yHo 1BZAsVXQK3R6+h1kuTgry0Xmw5U33x9b15p2nVjvoX07CBUGi+7wsQv74IdbPR7uKsSytuW6n7T4/ j/y4CLVAY3J7IxET3YZYogd9ipuCZZEV9hbqEK3kglGKNa5P6+U3O1qARiS7njvYW7nyU1yV4Nrn3 1TZe8pXZQg9WHJGqsIZtEPaPAUa/k0KA8J5c8xJY3aDrGiRiCYxSe8YAjhiq7S8updLGntLeNNzxp XVkrgeQRJgN+j9jObr8F/o6y7XIeg9aO3pHaQ52D89yM/V+4kgBYmm/bMrDijAxjnRknl4z31b4zh VqAcsb/Ng==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY6AD-0001ec-L0; Thu, 29 Oct 2020 11:32:17 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kY6AA-0001dp-Ul for linux-arm-kernel@lists.infradead.org; Thu, 29 Oct 2020 11:32:16 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 09TBT2ho015110; Thu, 29 Oct 2020 12:32:10 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=STMicroelectronics; bh=cUDfsyMLBZwwHgRqMnfVV+OV2A2kx7Khz7i3EBjHkbU=; b=wuuikyCXCb0PXaWjYUO3rOJWAzLt+3HLpfrGoYCkB5OrrjS798C/bleMZax2DAAoTNDN Topy5pDO3+uRmTsKYW5AWQpn9BKIYPq9EX8dzWRJ6hsqdeYT3MYW43DfXkyUX8stvk2h GthdhhIF+Jwf8PpE31HHBOdzrAHZm0kwZDZktdyUcJjZ+XCp7KQfZShJJkr41ngFnQMk yFyxsitQ5WNN7TXRSafPk0wYkyZ/SqBaPcs831/BXvKc4PmMn6hDMAblmB2JvDwc11nF GMV46Mq+gwV+tzI8tbekj6sUAZF3SuHKKznxQcoEtxwsPqFTxVrBGuiwkWB+71GOxsyH OQ== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 34ccf3yw6e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 29 Oct 2020 12:32:10 +0100 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 39B90100034; Thu, 29 Oct 2020 12:32:10 +0100 (CET) Received: from Webmail-eu.st.com (sfhdag1node3.st.com [10.75.127.3]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1598D2823BF; Thu, 29 Oct 2020 12:32:10 +0100 (CET) Received: from [10.48.1.149] (10.75.127.47) by SFHDAG1NODE3.st.com (10.75.127.3) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Thu, 29 Oct 2020 12:31:55 +0100 Subject: Re: [PATCH 5/5] i2c: stm32: remove unnecessary CONFIG_PM_SLEEP To: Coiby Xu , References: <20201029074654.227263-1-coiby.xu@gmail.com> <20201029074654.227263-5-coiby.xu@gmail.com> From: Fabrice Gasnier Message-ID: <699f4908-1ea1-6075-3375-7f1dfc6fb225@st.com> Date: Thu, 29 Oct 2020 12:31:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201029074654.227263-5-coiby.xu@gmail.com> Content-Language: en-US X-Originating-IP: [10.75.127.47] X-ClientProxiedBy: SFHDAG4NODE2.st.com (10.75.127.11) To SFHDAG1NODE3.st.com (10.75.127.3) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-10-29_06:2020-10-29, 2020-10-29 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_073215_394317_B9F90F26 X-CRM114-Status: GOOD ( 21.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexandre Torgue , open list , Pierre-Yves MORDRET , Alain VOLMAT , Maxime Coquelin , "moderated list:ARM/STM32 ARCHITECTURE" , "moderated list:ARM/STM32 ARCHITECTURE" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/29/20 8:46 AM, Coiby Xu wrote: > SET_SYSTEM_SLEEP_PM_OPS has already took good care of CONFIG_PM_CONFIG. > > Signed-off-by: Coiby Xu > --- > drivers/i2c/busses/i2c-stm32f7.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-stm32f7.c b/drivers/i2c/busses/i2c-stm32f7.c > index f41f51a176a1..95ac9dfdf458 100644 > --- a/drivers/i2c/busses/i2c-stm32f7.c > +++ b/drivers/i2c/busses/i2c-stm32f7.c > @@ -2262,7 +2262,6 @@ static int __maybe_unused stm32f7_i2c_runtime_resume(struct device *dev) > return 0; > } > > -#ifdef CONFIG_PM_SLEEP Hi Coiby, This generates warnings when building with W=1 and CONFIG_PM_SLEEP=n. Could you please add also "__maybe_unused" for relevant routines below ? > static int stm32f7_i2c_regs_backup(struct stm32f7_i2c_dev *i2c_dev) ^ e.g. insert: __maybe_unused Best regards, Fabrice > { > int ret; > @@ -2356,7 +2355,6 @@ static int stm32f7_i2c_resume(struct device *dev) > > return 0; > } > -#endif > > static const struct dev_pm_ops stm32f7_i2c_pm_ops = { > SET_RUNTIME_PM_OPS(stm32f7_i2c_runtime_suspend, > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel