From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B9AB1E92FCB for ; Thu, 5 Oct 2023 22:36:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=P9XgTzeW6IfymRnaoCK9QXtIQvmPHgrwKTft+Y4Ocew=; b=JvC0IohY2kVVbT FxuiTck1WNvB2l3eiH2Vp6MkHuEvL1q+LgD9O46ae5NnEuc8ruNmtERX/k9zQ+5uSEXimW+Ry1v2/ 6dKuactMxl6IyITL5rYsLbC8xzBodGljK8ER4CW7PMPW0I/VX/P4zlwvOumYeDtgtA9FCs04jP7rZ GY+n1x5kWh3L+yhx6s9GJbrOJSSAAy+NFtWdQtGE32Kpx7RYXG2y7ThU2LOcNclVzzohYCxYZaS3t 9N12e679O7sD+2qtv/m8j8RQ+n4Hqe5zb4VUVK7vMV8ZAVGAwtHXUjghOlnlH82trWBdfs/An62Ko Pi7/NR7YVBot1ib0UxWw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qoWuT-004ZEr-1q; Thu, 05 Oct 2023 22:33:33 +0000 Received: from mx0a-0031df01.pphosted.com ([205.220.168.131]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qoWuQ-004ZEV-0c for linux-arm-kernel@lists.infradead.org; Thu, 05 Oct 2023 22:33:31 +0000 Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 395MSP5j009713; Thu, 5 Oct 2023 22:33:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=qcppdkim1; bh=6g9Cyjl5K6OG1jkcqwrpcexPvXh/RcSiBX825pOgneQ=; b=gQh1G/y9mUJFUoQgZK/H8e1Y/Q6hSsUHp5u0VMTmfMLqJB4vtfJVo+c+FqIRZwif46U6 KEJ8SPGnm6JvOw8Yy/lrLKHHqA4cCRRxNSphq05XsyJSanSiTy0C85na3jIQCjccMCia tLhdaFzacbv3KlsbQ5rv9oytCorAHsNNokBw29QGERufl1p/rLA9rrGoT79oQhCz435u 1fj5wlnh2WqxlvWkiFSMfWvPtg0/KtHotCOA40/7YwJWv75ZJmwfu4ZaBkXyJmUrmtcG zRoAWtEXnKy7q3JnJ+T4SzYIQ0lRI/jRU8SO1cXhqcfF5TeAeWl7S/rxmsqCthIPJ+lf yQ== Received: from nalasppmta05.qualcomm.com (Global_NAT1.qualcomm.com [129.46.96.20]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3th8e1v2js-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 05 Oct 2023 22:33:16 +0000 Received: from nalasex01c.na.qualcomm.com (nalasex01c.na.qualcomm.com [10.47.97.35]) by NALASPPMTA05.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTPS id 395MXGXg028924 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 5 Oct 2023 22:33:16 GMT Received: from [10.110.20.163] (10.80.80.8) by nalasex01c.na.qualcomm.com (10.47.97.35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Thu, 5 Oct 2023 15:33:15 -0700 Message-ID: <69b8ded0-7648-80bd-c41b-c591b0f861ef@quicinc.com> Date: Thu, 5 Oct 2023 15:33:14 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v4 4/4] firmware: arm_scmi: Add qcom hvc/shmem transport support To: Bjorn Andersson , Sudeep Holla CC: , , , , , , , , , References: <20230718160833.36397-1-quic_nkela@quicinc.com> <20230911194359.27547-1-quic_nkela@quicinc.com> <20230911194359.27547-5-quic_nkela@quicinc.com> <20231003111914.63z35sn3r3k7drtp@bogus> <6246714a-3b40-e1b6-640e-560ba55b6436@quicinc.com> <20231004160630.pxspafszlt6o7oj6@bogus> <20231005222016.GI3553829@hu-bjorande-lv.qualcomm.com> Content-Language: en-US From: Nikunj Kela In-Reply-To: <20231005222016.GI3553829@hu-bjorande-lv.qualcomm.com> X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01b.na.qualcomm.com (10.46.141.250) To nalasex01c.na.qualcomm.com (10.47.97.35) X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-GUID: zWNE7LW-QekoHznHQ7t6FM-CyQDjR4op X-Proofpoint-ORIG-GUID: zWNE7LW-QekoHznHQ7t6FM-CyQDjR4op X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2023-10-05_17,2023-10-05_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 suspectscore=0 adultscore=0 priorityscore=1501 mlxscore=0 lowpriorityscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 malwarescore=0 impostorscore=0 clxscore=1015 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2309180000 definitions=main-2310050171 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231005_153330_238846_077BEAD6 X-CRM114-Status: GOOD ( 20.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 10/5/2023 3:20 PM, Bjorn Andersson wrote: > On Wed, Oct 04, 2023 at 05:06:30PM +0100, Sudeep Holla wrote: >> On Tue, Oct 03, 2023 at 09:16:27AM -0700, Nikunj Kela wrote: >>> On 10/3/2023 4:19 AM, Sudeep Holla wrote: >>>> On Mon, Sep 11, 2023 at 12:43:59PM -0700, Nikunj Kela wrote: >>>>> diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c > [..] >>>>> @@ -63,6 +66,8 @@ struct scmi_smc { >>>>> u32 func_id; >>>>> u32 param_page; >>>>> u32 param_offset; >>>>> + u64 cap_id; >>>> Can it be unsigned long instead so that it just works for both 32 and 64 bit. >>> My first version of this patch was ulong but Bjorn suggested to make this >>> structure size fixed i.e. architecture independent. Hence changed it to u64. >>> If you are ok with ulong, I can change it back to ulong. >>> >> SMCCC pre-v1.2 used the common structure in that way. I don't see any issue >> with that. I haven't followed Bjorn suggestions/comments though. >> > My request was that funcId and capId is an ABI between the firmware and > the OS, so I'd like for that to use well defined, fixed sized, data > types - if nothing else just for documentation purpose. > > These values will be truncated when passed to arm_smccc_1_1_invoke() > anyways, so I don't have any opinion against using unsigned long here... > > > PS. I understand why func_id is u32, but why are param_page and > param_offset u32? That was done to keep it uniform across smc32/smc64 conventions. > > Regards, > Bjorn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel