From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 85018EB64D7 for ; Wed, 21 Jun 2023 14:23:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Subject:Cc:To:From:Date:References: In-Reply-To:Message-Id:Mime-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=whQRr9huJ0bxo1o4OZ567C3V82Qa+ERwwEkrymDKEpo=; b=RQ6P7pz5wt7BYK u5WjRSVI2r8gicnmGQytut4/PRayLIMCXQfnRZWAg0crZYkshOEUgzMEQDVAdY16naoxL/EzhrVuk bexT5EXqHgGRyr7CN+ADkQ0MqZuwYoRAOldSlkbu6fgR3Zcg8xXaYuTuKIXC6SAdK++NZsapT13y/ 2GL2TSwvUDUaXVRC/9zgqU6XrQ4hner+etM1j6t9MgrevJSg7Y1Bm7ZCIO71Dki4RJjQj2/ftlXwi RzpPWePQ1APa2x8kRFopMCa96leDEt0krmUhaB85nC9BR7fptPJlVodPxBIMuk4AzuUDfCBdGaVvf nc0np5lsyLYe6he7EXHQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qByjO-00EnxQ-20; Wed, 21 Jun 2023 14:22:46 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qByjL-00EnwN-2Z for linux-arm-kernel@lists.infradead.org; Wed, 21 Jun 2023 14:22:45 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 8C24F5C00AB; Wed, 21 Jun 2023 10:22:39 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Wed, 21 Jun 2023 10:22:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1687357359; x=1687443759; bh=uq h8tuCqF2dKU/vlVkQ8edaMsCAAwNBeUvu46sx3Vr8=; b=n/k1xIatpSiHzZ/KiJ /Kn+e6auwMeIvQud6Vykz3TW8nFUpbyjf0bXEE7w05GD9shcMK3OKVAX1H25HTh2 Ibihj5rpbIv8kjIX5EnTP5HtHObp1Z5l079DTY1DTqU8t+ylqhhsTeU/Fl+cimZZ a60vKPDZHc95/GGR1TZRvj3Tdp44obNMuiRQQqXjN9O7VzxHgRvd5F7YbEN7gx+c VcDIEgcFIGw/MSb0nOqUZNCaWAaQaAtld9uuFgOwWcp2lSJ87J14N5NohrWsU9b4 1P104rKiiOwXEJ8pR4hlAe13FTCaUKJ5KNuVTDgUAfZCCyJ51pYhNJDhZAd5/khz ePgA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; t=1687357359; x=1687443759; bh=uqh8tuCqF2dKU /vlVkQ8edaMsCAAwNBeUvu46sx3Vr8=; b=JvqS126TUMtYNG2bnXKUnqMMIaO4L Zq1sOfPQ7X74qemER9BF0sTdhDfzM7zN463Lbjx5O90kcd4IzT3S9hDDoqdp61eA SwV/CENSELEJeDzijTa8XZLbf8cBjWzGbDPvE1Ly/o5jwU2AUhYLuvG1MKwtVAzA oqZEI2ImOkXI+4h1mLECJenCoIVJDD59YZ6MiQ+CwwCPz4i8NLAU//tNWa8iACaw 9YfSCkwyjyTQVHLOQOjEkcqIIXTH27A+E7GADA0DIQ41RjS9A0Emdhlhk9IXjCeq 1zFhMBs8NXY75pRdV8t+GidD4m/uoNeKUyzfJZIBZn/F8wt5FIz2UOwEw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrgeefkedggeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id B68BAB60089; Wed, 21 Jun 2023 10:22:38 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-499-gf27bbf33e2-fm-20230619.001-gf27bbf33 Mime-Version: 1.0 Message-Id: <69c742e5-3270-4b1c-be31-1552d877677e@app.fastmail.com> In-Reply-To: <20230621031605.234149-2-ychuang570808@gmail.com> References: <20230621031605.234149-1-ychuang570808@gmail.com> <20230621031605.234149-2-ychuang570808@gmail.com> Date: Wed, 21 Jun 2023 16:22:18 +0200 From: "Arnd Bergmann" To: "Jacky Huang" , "Michael Turquette" , "Stephen Boyd" , "Greg Kroah-Hartman" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, soc@kernel.org, krzysztof.kozlowski+dt@linaro.org, schung@nuvoton.com, "Jacky Huang" Subject: Re: [PATCH v2 1/2] clk: nuvoton: Add clk-ma35d1.h for driver extern functions X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_072243_901455_102F99FF X-CRM114-Status: GOOD ( 13.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 21, 2023, at 05:16, Jacky Huang wrote: > From: Jacky Huang > > Moved the declaration of extern functions ma35d1_reg_clk_pll() and > ma35d1_reg_adc_clkdiv() from the .c files to the newly created header > file clk-ma35d1.h. > > Signed-off-by: Jacky Huang > #define PLL_MAX_NUM 5 > @@ -20,19 +22,19 @@ static DEFINE_SPINLOCK(ma35d1_lock); > #define REG_CLK_PWRCTL 0x00 > #define REG_CLK_SYSCLK0 0x04 > #define REG_CLK_SYSCLK1 0x08 > -#define REG_CLK_APBCLK0 0x0C > +#define REG_CLK_APBCLK0 0x0c > #define REG_CLK_APBCLK1 0x10 > #define REG_CLK_APBCLK2 0x14 > #define REG_CLK_CLKSEL0 0x18 > -#define REG_CLK_CLKSEL1 0x1C > +#define REG_CLK_CLKSEL1 0x1c > #define REG_CLK_CLKSEL2 0x20 > #define REG_CLK_CLKSEL3 0x24 > #define REG_CLK_CLKSEL4 0x28 > -#define REG_CLK_CLKDIV0 0x2C > +#define REG_CLK_CLKDIV0 0x2c > #define REG_CLK_CLKDIV1 0x30 > #define REG_CLK_CLKDIV2 0x34 > #define REG_CLK_CLKDIV3 0x38 > -#define REG_CLK_CLKDIV4 0x3C > +#define REG_CLK_CLKDIV4 0x3c > #define REG_CLK_CLKOCTL 0x40 > #define REG_CLK_STATUS 0x50 > #define REG_CLK_PLL0CTL0 0x60 This part of the patch does not relate to the decription, it looks like a minor cleanup that should be a separate patch. The actual change looks good and required, but I can't apply it if it's mixed with unrelated changes like this. Arnd _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel