From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: dts: imx6: enable pl310 "shared attribute override enable" bit
Date: Thu, 21 Jan 2016 20:43:08 -0800 [thread overview]
Message-ID: <69f1d2c00ea70882a0d1f0701f8ae2f5@agner.ch> (raw)
In-Reply-To: <1453368119.3183.19.camel@pengutronix.de>
On 2016-01-21 01:21, Lucas Stach wrote:
> Am Mittwoch, den 20.01.2016, 21:08 -0800 schrieb Stefan Agner:
>> Hi Andy,
>>
>> On 2016-01-20 19:28, Fugang Duan wrote:
>> > The default behavior of the L220 or PL310 cache controllers with respect
>> > to the shareable attribute is to transform "normal memory non-cacheable
>> > transactions" into "cacheable no allocate" (for reads) or "write through
>> > no write allocate" (for writes).
>> >
>> > On i.MX6 series platforms, enet/audio/usb/nand DMA buffer have corruption
>> > without CMA. So set this property "arm,shared-override" in L2 dts node to
>> > enable "shared attribute override enable" bit.
>>
>> Do you happen to know if Vybrid could also suffer this too? Some IP's
>> are the same/similar ones...
>>
> This is a bug in the default configuration of the PL310 L2 cache
> controller. AFAIK Vybrid does not use this IP block, so it should be
> safe.
The ones with a 1 in the second digit come with the PL310 L2 cache
controller (e.g. VF610). Currently U-Boot does not touch the L2 cache
controller at all, however, reading this discussion sounds like this
would be a good idea in the future...
--
Stefan
>> Did this manifest in any way?
>>
>> --
>> Stefan
>>
>>
>> >
>> > Signed-off-by: Fugang Duan <B38611@freescale.com>
>> > ---
>> > arch/arm/boot/dts/imx6qdl.dtsi | 1 +
>> > arch/arm/boot/dts/imx6sl.dtsi | 1 +
>> > arch/arm/boot/dts/imx6sx.dtsi | 1 +
>> > 3 files changed, 3 insertions(+)
>> >
>> > diff --git a/arch/arm/boot/dts/imx6qdl.dtsi b/arch/arm/boot/dts/imx6qdl.dtsi
>> > index 4f6ae92..b4de39a 100644
>> > --- a/arch/arm/boot/dts/imx6qdl.dtsi
>> > +++ b/arch/arm/boot/dts/imx6qdl.dtsi
>> > @@ -185,6 +185,7 @@
>> > cache-level = <2>;
>> > arm,tag-latency = <4 2 3>;
>> > arm,data-latency = <4 2 3>;
>> > + arm,shared-override;
>> > };
>> >
>> > pcie: pcie at 0x01000000 {
>> > diff --git a/arch/arm/boot/dts/imx6sl.dtsi b/arch/arm/boot/dts/imx6sl.dtsi
>> > index d12b250..3b80b45 100644
>> > --- a/arch/arm/boot/dts/imx6sl.dtsi
>> > +++ b/arch/arm/boot/dts/imx6sl.dtsi
>> > @@ -113,6 +113,7 @@
>> > cache-level = <2>;
>> > arm,tag-latency = <4 2 3>;
>> > arm,data-latency = <4 2 3>;
>> > + arm,shared-override;
>> > };
>> >
>> > pmu {
>> > diff --git a/arch/arm/boot/dts/imx6sx.dtsi b/arch/arm/boot/dts/imx6sx.dtsi
>> > index a5f7602..42f8f3b 100644
>> > --- a/arch/arm/boot/dts/imx6sx.dtsi
>> > +++ b/arch/arm/boot/dts/imx6sx.dtsi
>> > @@ -155,6 +155,7 @@
>> > cache-level = <2>;
>> > arm,tag-latency = <4 2 3>;
>> > arm,data-latency = <4 2 3>;
>> > + arm,shared-override;
>> > };
>> >
>> > dma_apbh: dma-apbh at 01804000 {
next prev parent reply other threads:[~2016-01-22 4:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-21 3:28 [PATCH] ARM: dts: imx6: enable pl310 "shared attribute override enable" bit Fugang Duan
2016-01-21 5:08 ` Stefan Agner
2016-01-21 9:21 ` Lucas Stach
2016-01-22 4:43 ` Stefan Agner [this message]
2016-01-21 9:20 ` Lucas Stach
-- strict thread matches above, loose matches on Subject: below --
2016-01-21 4:40 Fugang Duan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69f1d2c00ea70882a0d1f0701f8ae2f5@agner.ch \
--to=stefan@agner.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).