From: Thorsten Blum <thorsten.blum@linux.dev>
To: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] stm class: Remove unnecessary local variable in stm_write
Date: Mon, 26 Jan 2026 08:55:02 +0100 [thread overview]
Message-ID: <6D495929-0881-4B38-BFD1-4C55135C7A7D@linux.dev> (raw)
In-Reply-To: <83v7goano1.fsf@black.igk.intel.com>
On 26. Jan 2026, at 07:33, Alexander Shishkin wrote:
> Thorsten Blum <thorsten.blum@linux.dev> writes:
>
>> The local variable 'err' and the corresponding if check in stm_write()
>> are unnecessary. Remove them.
>
> Nice catch! Is this a result of manual code inspection or were any tools
> used, an AI agent or a coccinelle script or whatnot?
Manual code inspection. I think I stumbled upon it when I was working on
https://lore.kernel.org/lkml/20250909102512.694203-2-thorsten.blum@linux.dev/
https://lore.kernel.org/lkml/20250909102512.694203-4-thorsten.blum@linux.dev/
which are also still pending. Could you take a look at all three patches
while you're at it?
Thanks,
Thorsten
next prev parent reply other threads:[~2026-01-26 7:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-26 0:43 [PATCH RESEND] stm class: Remove unnecessary local variable in stm_write Thorsten Blum
2026-01-26 6:33 ` Alexander Shishkin
2026-01-26 7:55 ` Thorsten Blum [this message]
-- strict thread matches above, loose matches on Subject: below --
2026-03-18 0:25 Thorsten Blum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6D495929-0881-4B38-BFD1-4C55135C7A7D@linux.dev \
--to=thorsten.blum@linux.dev \
--cc=alexander.shishkin@linux.intel.com \
--cc=alexandre.torgue@foss.st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox