From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 05DC0C433FE for ; Mon, 14 Nov 2022 21:01:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Cc:To :Subject:From:Date:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+YZmm7KdyxEToFOgovhB2D5lsv+HNkDRDz33CqMh5oA=; b=YffrCIqvuQQxcCpV1+B1oWmEXL 3M8iP175lt4qxkxMLSaChx4pQaccn6HxyRe26huhOSF+7rGy5Mlh0gUYvmy9ZJ9XiSgAgeLhY1WoF bI41RwVJ7etale/rwWezrQ81PclrpfRBxUD+8jSqj0MDsLiiqo6hmcsFoIwwqWitKqd5m7kHj+iUs I8RlaMtCE+r7d3FkOMNkwgkDm68mZ79idRM/0aPfab6F5U9FxpZaZQAC+zp4l0DZ16ytVmPsGrqZ9 F1ZrHttKRDJsRKg3Y8nvzcKucbzkXCRFhZ5NRsHmt9/Nty0iOFWVt8SapoqdW800djr+adgUbhepi hBr5pRaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ougZl-0051uB-EO; Mon, 14 Nov 2022 21:01:05 +0000 Received: from relay02.th.seeweb.it ([2001:4b7a:2000:18::163]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ougZb-0051oq-BZ for linux-arm-kernel@lists.infradead.org; Mon, 14 Nov 2022 21:01:00 +0000 Received: from [192.168.2.144] (bband-dyn193.178-41-216.t-com.sk [178.41.216.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits)) (No client certificate requested) by m-r1.th.seeweb.it (Postfix) with ESMTPSA id 2FF9C1F68C; Mon, 14 Nov 2022 22:00:49 +0100 (CET) Date: Mon, 14 Nov 2022 22:00:42 +0100 From: Martin Botka Subject: Re: [PATCH V2 2/2] arm64: dts: Add basic support for BIQU CB1 To: Jernej =?iso-8859-2?q?=A9krabec?= Cc: martin.botka1@gmail.com, ~postmarketos/upstreaming@lists.sr.ht, Konrad Dybcio , AngeloGioacchino Del Regno , Marijn Suijten , Jami Kettunen , Paul Bouchara , Yenda , Rob Herring , Krzysztof Kozlowski , Chen-Yu Tsai , Samuel Holland , Andre Przywara , Maxime Ripard , Andrew Lunn , Conley Lee , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org Message-Id: <6PVCLR.2VYE5Q51SD7C2@somainline.org> In-Reply-To: <37920504.10thIPus4b@jernej-laptop> References: <20221114172018.1876608-1-martin.botka@somainline.org> <3191151.oiGErgHkdL@jernej-laptop> <37920504.10thIPus4b@jernej-laptop> X-Mailer: geary/40.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221114_130055_781549_B9916173 X-CRM114-Status: GOOD ( 39.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-2"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Nov 14 2022 at 09:47:58 PM +01:00:00, Jernej =A9krabec = wrote: > Dne ponedeljek, 14. november 2022 ob 21:38:08 CET je Martin Botka = > napisal(a): >> On Mon, Nov 14 2022 at 09:16:29 PM +01:00:00, Jernej =A9krabec >> = >> wrote: >> > Hi Martin, >> > >> > Dne ponedeljek, 14. november 2022 ob 18:20:16 CET je Martin Botka >> > >> > napisal(a): >> >> CB1 is Compute Module style board that plugs into Rpi board = >> style >> >> >> >> adapter or >> >> >> >> Manta 3D printer boards (M4P/M8P). >> >> >> >> The board has: >> >> H616 SoC >> >> 1GB of RAM >> >> AXP313A PMIC >> >> >> >> And the actual boards that CB1 plugs in are just extension to it >> >> >> >> with ports >> >> >> >> and thus are not split in DT. >> >> >> >> Boards have: >> >> 4x (3x for Manta boards) USB and 1 USB OTG. >> >> SDcard slot for loading images. >> >> Ethernet port wired to the internal PHY. >> >> 2x HDMI 2.0. >> >> Power and Status LEDs. >> >> >> >> Currently working: >> >> Booting >> >> USB >> >> UART >> >> >> >> Signed-off-by: Martin Botka >> >> --- >> >> Changes in V2: >> >> Add proper board compatible >> >> Add regulator prefix for vcc5v >> >> Drop okay status from PMIC >> >> Drop standby_param >> >> >> >> arch/arm64/boot/dts/allwinner/Makefile | 1 + >> >> .../dts/allwinner/sun50i-h616-biqu-cb1.dts | 186 >> >> >> >> ++++++++++++++++++ >> >> >> >> 2 files changed, 187 insertions(+) >> >> create mode 100644 >> >> >> >> arch/arm64/boot/dts/allwinner/sun50i-h616-biqu-cb1.dts >> >> >> >> diff --git a/arch/arm64/boot/dts/allwinner/Makefile >> >> b/arch/arm64/boot/dts/allwinner/Makefile index >> >> >> >> 6a96494a2e0a..223f1be73541 >> >> >> >> 100644 >> >> --- a/arch/arm64/boot/dts/allwinner/Makefile >> >> +++ b/arch/arm64/boot/dts/allwinner/Makefile >> >> @@ -38,5 +38,6 @@ dtb-$(CONFIG_ARCH_SUNXI) +=3D = >> sun50i-h6-pine-h64.dtb >> >> >> >> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h6-pine-h64-model-b.dtb >> >> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h6-tanix-tx6.dtb >> >> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h6-tanix-tx6-mini.dtb >> >> >> >> +dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h616-biqu-cb1.dtb >> >> >> >> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h616-orangepi-zero2.dtb >> >> dtb-$(CONFIG_ARCH_SUNXI) +=3D sun50i-h616-x96-mate.dtb >> >> >> >> diff --git = >> a/arch/arm64/boot/dts/allwinner/sun50i-h616-biqu-cb1.dts >> >> b/arch/arm64/boot/dts/allwinner/sun50i-h616-biqu-cb1.dts new = >> file >> >> >> >> mode >> >> >> >> 100644 >> >> index 000000000000..297536d7629a >> >> --- /dev/null >> >> +++ b/arch/arm64/boot/dts/allwinner/sun50i-h616-biqu-cb1.dts >> >> @@ -0,0 +1,186 @@ >> >> +// SPDX-License-Identifier: (GPL-2.0+ or MIT) >> >> +/* >> >> + * Copyright (C) 2022 Arm Ltd. >> > >> > I suppose Arm Ltd. has nothing to do with this board? Put yours >> > copyrights >> > there. >> = >> Correct. Was a left over from Opi Zero 2 with just changed year. = >> Will >> correct in V3 with the rest of the changes >> = >> >> + */ >> >> + >> >> +/dts-v1/; >> >> + >> >> +#include "sun50i-h616.dtsi" >> >> + >> >> +#include >> >> +#include >> >> +#include >> >> + >> >> +/ { >> >> + model =3D "BIQU CB1"; >> >> + compatible =3D "biqu,cb1", "allwinner,sun50i-h616"; >> >> + >> >> + aliases { >> >> + serial0 =3D &uart0; >> >> + }; >> >> + >> >> + chosen { >> >> + stdout-path =3D "serial0:115200n8"; >> >> + }; >> >> + >> >> + leds { >> >> + compatible =3D "gpio-leds"; >> >> + >> >> + led-0 { >> >> + function =3D LED_FUNCTION_POWER; >> >> + color =3D ; >> >> + gpios =3D <&pio 2 12 GPIO_ACTIVE_HIGH>; /* >> > >> > PC12 */ >> > >> >> + default-state =3D "on"; >> >> + }; >> >> + >> >> + led-1 { >> >> + function =3D LED_FUNCTION_STATUS; >> >> + color =3D ; >> >> + gpios =3D <&pio 2 13 GPIO_ACTIVE_HIGH>; /* >> > >> > PC13 */ >> > >> >> + }; >> >> + }; >> >> + >> >> + reg_vcc5v: regulator_vcc5v { >> >> + /* board wide 5V supply directly from the USB-C socket >> > >> > */ >> > >> >> + compatible =3D "regulator-fixed"; >> >> + regulator-name =3D "vcc-5v"; >> >> + regulator-min-microvolt =3D <5000000>; >> >> + regulator-max-microvolt =3D <5000000>; >> >> + regulator-always-on; >> >> + }; >> >> + >> >> + reg_usb1_vbus: regulator-usb1-vbus { >> >> + compatible =3D "regulator-fixed"; >> >> + regulator-name =3D "usb1-vbus"; >> >> + regulator-min-microvolt =3D <5000000>; >> >> + regulator-max-microvolt =3D <5000000>; >> >> + vin-supply =3D <®_vcc5v>; >> >> + enable-active-high; >> >> + gpio =3D <&pio 2 16 GPIO_ACTIVE_HIGH>; /* PC16 */ >> >> + }; >> >> +}; >> >> + >> >> +&ehci0 { >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&ehci1 { >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&ehci2 { >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&ehci3 { >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&mmc0 { >> >> + vmmc-supply =3D <®_dldo1>; >> >> + cd-gpios =3D <&pio 5 6 GPIO_ACTIVE_LOW>; /* PF6 */ >> >> + no-1-8-v; >> >> + bus-width =3D <4>; >> >> + status =3D "disabled"; >> >> +}; >> >> + >> >> +&ohci0 { >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&ohci1 { >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&ohci2 { >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&ohci3 { >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&r_i2c { >> >> + status =3D "okay"; >> >> + >> >> + axp1530: pmic@36 { >> >> + compatible =3D "x-powers,axp1530"; >> > >> > I see that you send driver for this PMIC separately. Next time = >> please >> > mention >> > that this series depends on another, otherwise checks will fail. = >> Ping >> > us here >> > once PMIC driver is merged to unblock this. >> > >> > Anyway, RSB is prefered. Can you switch to it? >> = >> RSB does initialize but as soon as I try to give it the PMIC via = >> RSB it >> doesnt really wanna work so thats a no sadly. > = > It's possible that you have to update this table: > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/ > drivers/bus/sunxi-rsb.c?h=3Dv6.1-rc5#n528 > = > If still doesn't work, you have to remove RSB support in PMIC driver. > = > Is there datasheet for this PMIC? From what i tried to find there isnt. Maybe i did not look hard enough = but i do not have one. All i go from here is the downstream kernel. Biqu itself released datasheets for AXP305 and AXP313A. Where the = AXP313A is actually used on the board and uses the AXP1530 driver thats found in downstream which did include = RSB support. So it looks like to me that AXP313A is just a rebrand of AXP1530. And = all other references to downstream kernels i found about AXP1530 or AXP313A used I2C to communicate with = the chip. So in this state i would be happy to drop the RSB support from the = driver as there seems to be no use for it and leave I2C in. This would be done in V2 alongside any other requested changes > = > Best regards, > Jernej > = >> = >> >> + reg =3D <0x36>; >> >> + wakeup-source; >> >> + >> >> + regulators{ >> >> + reg_dcdc1: dcdc1 { >> >> + regulator-name =3D "axp1530- > dcdc1"; >> >> + regulator-min-microvolt =3D >> > >> > <500000>; >> > >> >> + regulator-max-microvolt =3D >> > >> > <3400000>; >> > >> >> + regulator-step-delay-us =3D <25>; >> >> + regulator-final-delay-us =3D <50>; >> >> + regulator-always-on; >> >> + }; >> >> + >> >> + reg_dcdc2: dcdc2 { >> >> + regulator-name =3D "axp1530- > dcdc2"; >> >> + regulator-min-microvolt =3D >> > >> > <500000>; >> > >> >> + regulator-max-microvolt =3D >> > >> > <1540000>; >> > >> >> + regulator-step-delay-us =3D <25>; >> >> + regulator-final-delay-us =3D <50>; >> >> + regulator-ramp-delay =3D <200>; >> >> + regulator-always-on; >> >> + }; >> >> + >> >> + reg_dcdc3: dcdc3 { >> >> + regulator-name =3D "axp1530- > dcdc3"; >> >> + regulator-min-microvolt =3D >> > >> > <500000>; >> > >> >> + regulator-max-microvolt =3D >> > >> > <1840000>; >> > >> >> + regulator-step-delay-us =3D <25>; >> >> + regulator-final-delay-us =3D <50>; >> >> + regulator-always-on; >> >> + }; >> >> + >> >> + reg_aldo1: ldo1 { >> >> + regulator-name =3D "axp1530- > aldo1"; >> >> + regulator-min-microvolt =3D >> > >> > <1800000>; >> > >> >> + regulator-max-microvolt =3D >> > >> > <1800000>; >> > >> >> + regulator-step-delay-us =3D <25>; >> >> + regulator-final-delay-us =3D <50>; >> >> + regulator-always-on; >> >> + }; >> >> + >> >> + reg_dldo1: ldo2 { >> >> + regulator-name =3D "axp1530- > dldo1"; >> >> + regulator-min-microvolt =3D >> > >> > <3300000>; >> > >> >> + regulator-max-microvolt =3D >> > >> > <3300000>; >> > >> >> + regulator-step-delay-us =3D <25>; >> >> + regulator-final-delay-us =3D <50>; >> >> + regulator-always-on; >> >> + }; >> >> + }; >> >> + }; >> >> +}; >> >> + >> >> +&uart0 { >> >> + pinctrl-names =3D "default"; >> >> + pinctrl-0 =3D <&uart0_ph_pins>; >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&usbotg { >> >> + /* >> >> + * PHY0 pins are connected to a USB-C socket, but a role = >> switch >> >> + * is not implemented: both CC pins are pulled to GND. >> >> + * The VBUS pins power the device, so a fixed peripheral mode >> >> + * is the best choice. >> >> + * The board can be powered via GPIOs, in this case port0 = >> *can* >> >> + * act as a host (with a cable/adapter ignoring CC), as VBUS = >> is >> >> + * then provided by the GPIOs. Any user of this setup would >> >> + * need to adjust the DT accordingly: dr_mode set to "host", >> >> + * enabling OHCI0 and EHCI0. >> >> + */ >> > >> > Above text is verbatim copy from OrangePi Zero2 and I'm not sure = >> if >> > it is >> > fully accurate for this board too. Looking at board photo, it = >> surely >> > looks >> > like this board has same USB design as Zero2. But if that's true, = >> you >> > shouldn't enable OHCI0 and EHCI0 nodes. >> = >> Correct. But M8P has a dip switch that enables or disables usbotg. >> As for if it does anything its hard to say. >> = >> > Is there any board schematic publicly available for this board? >> = >> This is one of the issues. Im in contact with BIQU and asking for = >> the >> schematics. >> I hope we can get them released ASAP as it would help me as well. >> = >> > Best regards, >> > Jernej >> > >> >> + dr_mode =3D "peripheral"; >> >> + status =3D "okay"; >> >> +}; >> >> + >> >> +&usbphy { >> >> + usb1_vbus-supply =3D <®_usb1_vbus>; >> >> + status =3D "okay"; >> >> +}; >> = >> Best Regards, >> Martin > = > = > = > = _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel