From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0DD39C433FE for ; Mon, 28 Nov 2022 05:45:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Wpf+5VSfFhqt0jKMTZWb4Ulcr2TK1R1VVI04bzA1sA=; b=a15JnsTyLf0sjL 1tX51hBTs8lm8S/B0S50f14VLBwigYfgsIVRtD8uBg4wVOxDbUEaDWEgB5X3RYyg8OlVZ6VfEqGnh 72d0EdZd/2480onI3us2+LsXdL2yphddQUwT2eWBOICEhC5GIHpWRnLvvSZByXVVixAGw+Etm8eAl c5isxjB9Q/lcdOGIdvejpfXXCkF8A4l1j0Gl5q9BZOIt62xWw5xUeUt5lHo0JIEiEVdEq+tERu4VQ Yoo1XaBwBCBpceuhX68KeuziIPoZqIjmGQoTYyo0eJU4Lv0gCCDrw95EEfYKa8PzasdcUVQZpVpXI KL+DQ29I/XG/7or9GoIA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozWwO-00GRLu-6w; Mon, 28 Nov 2022 05:44:28 +0000 Received: from wp530.webpack.hosteurope.de ([80.237.130.52]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ozWwJ-00GRHn-SA for linux-arm-kernel@lists.infradead.org; Mon, 28 Nov 2022 05:44:25 +0000 Received: from [2a02:8108:963f:de38:eca4:7d19:f9a2:22c5]; authenticated by wp530.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) id 1ozWwB-0008Hk-HK; Mon, 28 Nov 2022 06:44:15 +0100 Message-ID: <6a5b523d-711b-d809-06b9-fdada64c9c65@leemhuis.info> Date: Mon, 28 Nov 2022 06:44:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH] Revert "arm64: dma: Drop cache invalidation from arch_dma_prep_coherent()" Content-Language: en-US, de-DE To: Manivannan Sadhasivam , catalin.marinas@arm.com, will@kernel.org Cc: robin.murphy@arm.com, amit.pundir@linaro.org, andersson@kernel.org, quic_sibis@quicinc.com, sumit.semwal@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20221114110329.68413-1-manivannan.sadhasivam@linaro.org> From: Thorsten Leemhuis In-Reply-To: <20221114110329.68413-1-manivannan.sadhasivam@linaro.org> X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1669614263;b1aa3bb0; X-HE-SMSGID: 1ozWwB-0008Hk-HK X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221127_214424_111368_A36FD29B X-CRM114-Status: GOOD ( 11.44 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 14.11.22 12:03, Manivannan Sadhasivam wrote: > This reverts commit c44094eee32f32f175aadc0efcac449d99b1bbf7. > > As reported by Amit [1], dropping cache invalidation from > arch_dma_prep_coherent() triggers a crash on the Qualcomm SM8250 platform > (most probably on other Qcom platforms too). The reason is, Qcom > qcom_q6v5_mss driver copies the firmware metadata and shares it with modem > for validation. The modem has a secure block (XPU) that will trigger a > whole system crash if the shared memory is accessed by the CPU while modem > is poking at it. > [...] > [1] https://lore.kernel.org/linux-arm-kernel/CAMi1Hd1VBCFhf7+EXWHQWcGy4k=tcyLa7RGiFdprtRnegSG0Mw@mail.gmail.com/ > I have Amit's report on the list of tracked regressions. I also noticed the proposed change "arm64: dts: qcom: sc8280xp: fix PCIe DMA coherency": https://lore.kernel.org/all/20221124142501.29314-1-johan+linaro@kernel.org/ I have no expertise in this area, but it looked somewhat related to my eyes, so please allow me to quickly ask: is that related or even supposed to fix Amit's regression? Ciao, Thorsten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel