From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20370C43381 for ; Tue, 19 Feb 2019 08:57:31 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C366E21902 for ; Tue, 19 Feb 2019 08:57:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YkFyKNHa" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C366E21902 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=i2se.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XGT35Oc2AQAqMQdsLjwd/e/JAQW74sgkqVTvTgcgv/Y=; b=YkFyKNHaTc8YcM Z5txFHlEtSQpcmdWcea+92j5txa4WIK2ZCUeKRyhBnwUPWvhdNQLIT24Dzv//6vNeGld8jHdi7cS+ eo/HG2VH5EY5KpJ4wEfon/y4g5SNDKdELfKHCGOF4EGzeWHc7HYCwv/3fmHe9kD5f/Q46F5qIxmPy QL2N/bwhoZclY6h/DQWL94w+y5N6IVRCNnixifxZu5ONPXf1hQrGoFPv7zciEG7FYgJalC9tTLrKZ ZS0apfwAku3A2mSpgpN1+tEZoAdLkFhyjUDgm9qoEMjwO+yCzdsv78IhK46BFm9NeDvBeLA9giS1H XAVSUjYLE4jX4PfNwRvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw1DP-0006fQ-6r; Tue, 19 Feb 2019 08:57:23 +0000 Received: from mout.kundenserver.de ([212.227.17.10]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gw1D9-0006Rs-Vc for linux-arm-kernel@lists.infradead.org; Tue, 19 Feb 2019 08:57:12 +0000 Received: from [192.168.178.52] ([109.104.34.73]) by mrelayeu.kundenserver.de (mreue106 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MKbwg-1gdFs63oVQ-00L0kR; Tue, 19 Feb 2019 09:56:50 +0100 Subject: Re: [PATCH 3/8] dt-bindings: net: bluetooth: Add rtl8723bs-bluetooth To: Vasily Khoruzhick , Rob Herring References: <20190118170232.16142-1-anarsoul@gmail.com> <20190118170232.16142-4-anarsoul@gmail.com> <20190218211035.GA28145@bogus> From: Stefan Wahren Message-ID: <6a61bca4-c458-6d98-68e6-ef49b191019c@i2se.com> Date: Tue, 19 Feb 2019 09:56:47 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Provags-ID: V03:K1:wht6XshRJSZw5SLNmwIESxEopFXtFOue70HBGTSF/lanmGZEk/Y R2ylCRKk0ZRx6XLP5vaFMef1GNeaefi06BeJpMcw9UtD7Q7bxr+ET8taXfQH8ddiYw/QpRa TEd2D9XH9H9ImIVf68UKptZBYgQ/jZ3aVvJCXjMEXWUjp1p8THWwtMDNL0F5OdShGBaS6lF Gv/k2tJ7sfldcRjdijX6Q== X-UI-Out-Filterresults: notjunk:1;V03:K0:FJk39dRHJ7M=:kxq/7OnfQ6e1kyQzD0rjo5 Wbt6Kw4DCj6DPRl+7ABjSCDOmy8TwsPgTDYPIac1Eh1QdVkmSlgpyTLA2MTPURAVKsAhTXhgP sZmg2JDOBtmQxeDlMdUSeV3VNIYigmmuZO7FNihU0tOXkv3npcYouhg3RVNYVgmGSFUkzkh97 1XIUj4yDmlKUZKGcOl2bJ4ZwXGBHeiXYirv/29wxg2tTjGt5txzhFD3QIlwMBtIg9Plzt5CV8 SptsFJIlkm79oNPY3kxJBUg81lv5ZcyZNyldlu9jZzslHibQayU1yrqvny3GrPLDmSDmqdZnz x94rsRxj6Ja3PMFhmPWjzqB8DsNUbZA4BwmE9BTbNubUibnGN1jHxSJ55idB2NoPkFgR0unWa ChnBHFHeH+BzLLFil3o2v8ec2+XT5g+ttu4FCWCo/GcbnCvAnA7WxlHX6fxYVOI2T6vU2QHb3 tU8t0ZsOsAeKFCY3AQztTfgpGaLShMOaNYo0tlidbnTFEEZTzqkm8Z9H2JL4QmKUEzlWfYm6g lUKBxJsvddupDqOABB84gTmNDy76XLQA+viMVAKtotoTi/08vUttulCWGvghpzySBzbiezho2 KEVh57ndTMWpU8Y+d7sU3IzTGyjzjqzHJ1Me94cl7++iISJPakBObaxTVOEqK3hCmmmTxBVfT RnnreOH7CmarQvv0yHTUCVvMN5RoKXG5b0qeLNwerxgfaxilHeQNkG9I0WfKpehkMQfvxW383 lddEDeyq8JFXZdGlmh9WUQPg5Pi25tyZJKeImhfe9N6sV3z1fKVt9r8I28wKZanKg2C2Be3/w guTPTlsUJxqQL2sYoHikoXyRAnXgULrvSb4Uq27ANyy03fCzC1OCgu9IYFPzOAdgnRJ9vae68 hN+W9KQj2vtH5XpwzxcQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190219_005708_426206_D8A11F82 X-CRM114-Status: GOOD ( 17.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Johan Hedberg , Maxime Ripard , netdev@vger.kernel.org, Marcel Holtmann , linux-bluetooth@vger.kernel.org, Chen-Yu Tsai , "David S. Miller" , arm-linux Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Vasily, Am 18.02.19 um 22:24 schrieb Vasily Khoruzhick: > On Mon, Feb 18, 2019 at 1:10 PM Rob Herring wrote: >> On Fri, Jan 18, 2019 at 09:02:27AM -0800, Vasily Khoruzhick wrote: >>> Add binding document for bluetooth part of RTL8723BS/RTL8723CS >>> >>> Signed-off-by: Vasily Khoruzhick >>> --- >>> .../bindings/net/rtl8723bs-bluetooth.txt | 35 +++++++++++++++++++ >>> 1 file changed, 35 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>> >>> diff --git a/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>> new file mode 100644 >>> index 000000000000..8357f242ae4c >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/net/rtl8723bs-bluetooth.txt >>> @@ -0,0 +1,35 @@ >>> +RTL8723BS/RTL8723CS Bluetooth >>> +--------------------- >>> + >>> +RTL8723CS/RTL8723CS is WiFi + BT chip. WiFi part is connected over SDIO, while >>> +BT is connected over serial. It speaks H5 protocol with few extra commands >>> +to upload firmware and change module speed. >>> + >>> +Required properties: >>> + >>> + - compatible: should be one of the following: >>> + * "realtek,rtl8723bs-bt" >>> + * "realtek,rtl8723cs-bt" >>> +Optional properties: >>> + >>> + - device-wake-gpios: GPIO specifier, used to wakeup the BT module (active high) >>> + - enable-gpios: GPIO specifier, used to enable the BT module (active high) >>> + - host-wake-gpios: GPIO specifier, used to wakeup the host processor (active high) >>> + - firmware-postfix: firmware postfix to be used for firmware config >> How is this used? > rtl8723bs-bt needs 2 firmware binaries -- one is actual firmware, > another is firmware config which is specific to the board. If > firmware-postfix is specified, driver appends it to the name of config > and requests board-specific config while loading firmware. I.e. if > 'pine64' is specified as firmware-postfix driver will load > rtl8723bs_config-pine64.bin. this is a common problem (e.g. brcmfmac has the same problem [1]). Why not using the "model" property instead of inventing a new software specific property? [1] - https://patchwork.kernel.org/patch/10764463/ > >> Rob >> > _ _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel