From: Robin Murphy <robin.murphy@arm.com>
To: Alessandro Carminati <alessandro.carminati@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Heiko Stuebner <heiko@sntech.de>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: rockchip: k3566-quartz64-a: fix names entries, refactor
Date: Fri, 16 Sep 2022 17:46:01 +0100 [thread overview]
Message-ID: <6a64bfed-2939-299f-5807-607406eaa89b@arm.com> (raw)
In-Reply-To: <YyRxp7pDCyikNLGc@lab.hqhome163.com>
On 2022-09-16 13:52, Alessandro Carminati wrote:
> Fix esisting "No underscores in node names" general rule, and prepare for
> new board versions.
>
> Signed-off-by: Alessandro Carminati <alessandro.carminati@gmail.com>
> ---
> arch/arm64/boot/dts/rockchip/Makefile | 2 +-
> ...-quartz64-a.dts => rk3566-quartz64-a.dtsi} | 27 ++++++++-----------
> .../dts/rockchip/rk3566-quartz64-a.usb3.dts | 9 +++++++
> 3 files changed, 21 insertions(+), 17 deletions(-)
> rename arch/arm64/boot/dts/rockchip/{rk3566-quartz64-a.dts => rk3566-quartz64-a.dtsi} (97%)
> create mode 100644 arch/arm64/boot/dts/rockchip/rk3566-quartz64-a.usb3.dts
>
> diff --git a/arch/arm64/boot/dts/rockchip/Makefile b/arch/arm64/boot/dts/rockchip/Makefile
> index ef79a672804a..97ec6c156346 100644
> --- a/arch/arm64/boot/dts/rockchip/Makefile
> +++ b/arch/arm64/boot/dts/rockchip/Makefile
> @@ -59,7 +59,7 @@ dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399-sapphire-excavator.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3399pro-rock-pi-n10.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.1.dtb
> dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-pinenote-v1.2.dtb
> -dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.dtb
> +dtb-$(CONFIG_ARCH_ROCKCHIP) += rk3566-quartz64-a.usb3.dtb
Beware that changing the name of an existing DTB is going to break some
people's boot scripts. Since this one was merged several releases ago,
it's a probably bit too late to change now.
Thanks,
Robin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-09-16 16:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 12:52 [PATCH 1/2] dt-bindings: rockchip: k3566-quartz64-a: fix names entries, refactor Alessandro Carminati
2022-09-16 13:17 ` Heiko Stuebner
2022-09-16 16:46 ` Robin Murphy [this message]
2022-09-17 16:42 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a64bfed-2939-299f-5807-607406eaa89b@arm.com \
--to=robin.murphy@arm.com \
--cc=alessandro.carminati@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox