From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B731FC77B7C for ; Wed, 25 Jun 2025 18:45:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CWa9vLHjivGtX23R7pWprB8Tx5F1xP2O2QxWoGtKsMg=; b=L90T6S36mm78w+2BfmyDB7Q8tZ iL4uW1om4bKu/N7XKlKl1pYLDemgSqLco+QBdaXcZw9HouUMnntzS6szYInxKf/FW/UcsNna+oGPO 7LOEmwVtP1ELsvCQSYZS+QV7ABa+aJnnKNOm1FVnyMXaaDLQfdaXyIUdPiYHVXBK1qUie5zve8wWO xUV/XzUtl8YZAAk+gY564sUbo7JeRkBf+6JKlGyDYOGJ7qa3BgvYoSPx55nFnfUuVNm+nQ6xaeulp ebd39wtl/6zYhmuvhfZCnkHGkNQMsdQn/HPSOfYm+Zxk1slO1zIK4JCwb/2robVt8c7pElCk8LsIH rsXnf5Lw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUV7i-00000009e1f-0YMt; Wed, 25 Jun 2025 18:45:30 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1uUPlX-00000008j2e-0uKN for linux-arm-kernel@lists.infradead.org; Wed, 25 Jun 2025 13:02:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750856534; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=CWa9vLHjivGtX23R7pWprB8Tx5F1xP2O2QxWoGtKsMg=; b=AuuSiwiHjDpHvBFifUOowCJ7u+FS3Z5s9C2FKzXYN8ejQHqXMVwzojsn49QsGP6Q7LErA3 AVB5dRc0xb1VtqszDSLy2QuOJLs/DOXFM9P19oRu/ozcZKw11GcfwC6+ouX+BSprsKOdy+ pV/+arKH72bAfTUup3IMHlkfcbCaoFY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-240-RKYpbOjlP7aLa6AF5WKzjA-1; Wed, 25 Jun 2025 09:02:09 -0400 X-MC-Unique: RKYpbOjlP7aLa6AF5WKzjA-1 X-Mimecast-MFC-AGG-ID: RKYpbOjlP7aLa6AF5WKzjA_1750856528 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-450d50eacafso11451915e9.3 for ; Wed, 25 Jun 2025 06:02:09 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750856528; x=1751461328; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=CWa9vLHjivGtX23R7pWprB8Tx5F1xP2O2QxWoGtKsMg=; b=DZEAQURE3E4Z5UIndbY1TgnJurpXyGdvOLwhqFwa0Lj5R9bzCuROPe0qabzvlCwIwV 3UyWW3HM7hNDn6oaTm/Dr+IETmgyhWCxSI9Uoh2lDOb3/e91xJz6dG0UNzRkHWEJJ7OW NksUgBgZhmjsbi5hcXLiurrNZeien7dZOtra4Q23Xamhro3WDIeHLj/NXEj4MaCOgG4q bM9wnrFAH+bvFURi/cSBfzNUMvM8hqJ4ste3aAqlBNUIK9eG1w6UwLGJztVQZEbNxuOP e23XFwYLpeZTKixZvh2+UOErkuzlhdxN0z0GqfPP8Eq6QO6M9fkWRVhrAWkHDvUG1D4w X6Dw== X-Forwarded-Encrypted: i=1; AJvYcCXr7Jd2PsVuDl/1EkLSHE1mMli+GUIJIeRZpwXAoY5xteolsS4ERvq0zAVr9AUEcBlI3upXL082bAODpV4/yn1E@lists.infradead.org X-Gm-Message-State: AOJu0YxwVWdJgAEYB2Z34L7GxEky0mzyN79y7383MdSpGvGs+0VltESk vq2187O7W4KRftfW7lKBdRfJ9qUljh5mLHCNzuEINajf8BFR4v/embticvgVwyY5qeYfLNxkzjP rUJ7Skik7/2VROxiwmqtr1Ht7BSxgoxhwDlVzzK4NYQRLUQwsoBm4Y7eJSon8kdGUajSxuR3+GG CjhqvaI1MgHQE= X-Gm-Gg: ASbGncvaSZT4GuGeliQPLsom4l3RlvRR/2FUz1MMB73bqJMzpyjPEIBoAmIXGdbOA+N 6Uf5+wUXfx0zI5YPu3oZa7/Vgy3x+J0iJjQmvxVmIOjxV0uZMH7NcnsIOiZsjtuUGm7psXqFQnS J4xMzCRhsoLrv/GCEIKX8+ARygnF0zH5DYk2WdXcELzJXverNRoQD5VycS4iNSdoxHgNUe50YH1 oEHFRfArOpc2otRG4utDse90BjFECrE2BmX7NksVPrSXQ9Dbm3HjQGUReCtx1NtWLYaPHHCTjrL Ml/PtR+Nt2IxOiEw1hXAxiZYUB8PClLEyWFIfWhASww+LWi8YZVb5laq+N+9NS9OpZvnbui0pfs 4k4FtjUT2QMMPQoWMKJFu8aSIgQ9EGySZlrz2wl7PjwJ0 X-Received: by 2002:a05:600c:c111:b0:453:d3d:d9fd with SMTP id 5b1f17b1804b1-45381af1eb9mr24755045e9.12.1750856527984; Wed, 25 Jun 2025 06:02:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEKiZA5X744huDWj+mGMDZbU1CSFk/eikCS0GwKNdrXtigtMtmCMaoW8coZuQI5rH2zraR2qQ== X-Received: by 2002:a05:600c:c111:b0:453:d3d:d9fd with SMTP id 5b1f17b1804b1-45381af1eb9mr24753265e9.12.1750856525887; Wed, 25 Jun 2025 06:02:05 -0700 (PDT) Received: from ?IPV6:2003:d8:2f12:1b00:5d6b:db26:e2b7:12? (p200300d82f121b005d6bdb26e2b70012.dip0.t-ipconnect.de. [2003:d8:2f12:1b00:5d6b:db26:e2b7:12]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-453823c3c7csm19445455e9.36.2025.06.25.06.02.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 25 Jun 2025 06:02:04 -0700 (PDT) Message-ID: <6a754628-d9d8-43e1-a6d9-fa45a5f23971@redhat.com> Date: Wed, 25 Jun 2025 15:02:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 3/4] mm: Support batched unmap for lazyfree large folios during reclamation To: Lance Yang , Barry Song <21cnbao@gmail.com> Cc: akpm@linux-foundation.org, baolin.wang@linux.alibaba.com, chrisl@kernel.org, kasong@tencent.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-riscv@lists.infradead.org, lorenzo.stoakes@oracle.com, ryan.roberts@arm.com, v-songbaohua@oppo.com, x86@kernel.org, ying.huang@intel.com, zhengtangquan@oppo.com, Lance Yang References: <2c19a6cf-0b42-477b-a672-ed8c1edd4267@redhat.com> <20250624162503.78957-1-ioworker0@gmail.com> <27d174e0-c209-4851-825a-0baeb56df86f@redhat.com> <938c4726-b93e-46df-bceb-65c7574714a6@linux.dev> <5ba95609-302b-456a-a863-2bd5df51baf2@redhat.com> <6179dd30-5351-4a79-b0d6-f0e85650a926@redhat.com> <5db6fb4c-079d-4237-80b3-637565457f39@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: rDvWhGFci4NHkfViRykcRsu9FxOv8tPU7TQTPtLUyYU_1750856528 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250625_060215_342224_6793B794 X-CRM114-Status: GOOD ( 23.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 25.06.25 14:58, Lance Yang wrote: > > > On 2025/6/25 20:09, David Hildenbrand wrote: >> On 25.06.25 13:42, Barry Song wrote: >>> On Wed, Jun 25, 2025 at 11:27 PM David Hildenbrand >>> wrote: >>>> >>>> On 25.06.25 13:15, Barry Song wrote: >>>>> On Wed, Jun 25, 2025 at 11:01 PM David Hildenbrand >>>>> wrote: >>>>>> >>>>>> On 25.06.25 12:57, Barry Song wrote: >>>>>>>>> >>>>>>>>> Note that I don't quite understand why we have to batch the >>>>>>>>> whole thing >>>>>>>>> or fallback to >>>>>>>>> individual pages. Why can't we perform other batches that span >>>>>>>>> only some >>>>>>>>> PTEs? What's special >>>>>>>>> about 1 PTE vs. 2 PTEs vs. all PTEs? >>>>>>>> >>>>>>>> That's a good point about the "all-or-nothing" batching logic ;) >>>>>>>> >>>>>>>> It seems the "all-or-nothing" approach is specific to the >>>>>>>> lazyfree use >>>>>>>> case, which needs to unmap the entire folio for reclamation. If >>>>>>>> that's >>>>>>>> not possible, it falls back to the single-page slow path. >>>>>>> >>>>>>> Other cases advance the PTE themselves, while try_to_unmap_one() >>>>>>> relies >>>>>>> on page_vma_mapped_walk() to advance the PTE. Unless we want to >>>>>>> manually >>>>>>> modify pvmw.pte and pvmw.address outside of >>>>>>> page_vma_mapped_walk(), which >>>>>>> to me seems like a violation of layers. :-) >>>>>> >>>>>> Please explain to me why the following is not clearer and better: >>>>> >>>>> This part is much clearer, but that doesn’t necessarily improve the >>>>> overall >>>>> picture. The main challenge is how to exit the iteration of >>>>> while (page_vma_mapped_walk(&pvmw)). >>>> >>>> Okay, I get what you mean now. >>>> >>>>> >>>>> Right now, we have it laid out quite straightforwardly: >>>>>                   /* We have already batched the entire folio */ >>>>>                   if (nr_pages > 1) >>>>>                           goto walk_done; >>>> >>>> >>>> Given that the comment is completely confusing whens seeing the >>>> check ... :) >>>> >>>> /* >>>>    * If we are sure that we batched the entire folio and cleared all >>>> PTEs, >>>>    * we can just optimize and stop right here. >>>>    */ >>>> if (nr_pages == folio_nr_pages(folio)) >>>>          goto walk_done; >>>> >>>> would make the comment match. >>> >>> Yes, that clarifies it. >>> >>>> >>>>> >>>>> with any nr between 1 and folio_nr_pages(), we have to consider two >>>>> issues: >>>>> 1. How to skip PTE checks inside page_vma_mapped_walk for entries that >>>>> were already handled in the previous batch; >>>> >>>> They are cleared if we reach that point. So the pte_none() checks will >>>> simply skip them? >>>> >>>>> 2. How to break the iteration when this batch has arrived at the end. >>>> >>>> page_vma_mapped_walk() should be doing that? >>> >>> It seems you might have missed the part in my reply that says: >>> "Of course, we could avoid both, but that would mean performing >>> unnecessary >>> checks inside page_vma_mapped_walk()." >> > > That’s true for both. But I’m wondering why we’re still doing the >> check, >>> even when we’re fairly sure they’ve already been cleared or we’ve reached >>> the end :-) >> >> :) >> >>> >>> Somehow, I feel we could combine your cleanup code—which handles a batch >>> size of "nr" between 1 and nr_pages—with the >>> "if (nr_pages == folio_nr_pages(folio)) goto walk_done" check. >> >> Yeah, that's what I was suggesting. It would have to be part of the >> cleanup I think. >> >> I'm still wondering if there is a case where >> >> if (nr_pages == folio_nr_pages(folio)) >>     goto walk_done; >> >> would be wrong when dealing with small folios. > > We can make the check more explicit to avoid any future trouble ;) > > if (nr_pages > 1 && nr_pages == folio_nr_pages(folio)) > goto walk_done; > > It should be safe for small folios. I mean, we are walking a single VMA, and a small folio should never be mapped multiple times into the same VMA. (ignoring KSM, but KSM is handled differently either way) So we should be good, just wanted to raise it. -- Cheers, David / dhildenb