From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EAAA6C433EF for ; Mon, 20 Sep 2021 21:58:42 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B687F603E5 for ; Mon, 20 Sep 2021 21:58:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B687F603E5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:Cc:To:Subject:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=IX03wHCRNJg0YgFtq/it2MxMfo8mpve6RBjOdQErroU=; b=ZYumqoVhqPPP6lp4phX0HEThFi lCgYOcON2wNa7eMo7gkxL/fvb9oND1FphPrG1vsa7QLOUXhj3qaf+B1KKEUOI49kbt7AJeqpiirX1 DDCB8RxSzIQf58Sl+xbuMKsdMugrDX3Hvbg9qrXCM2Nv1hZmNZBA4Tz5yU+PFA/7QjoE/YoRTz5Ol g1+A13Q0Bd6vWWiYYu+AxJlQHS45tBd6pW+zrLXmW6WRyB198aDL0GSJDeFqpesqmrbuG0plcsdjv AKyb77vpKd01gBDLRq5EbquuDxLywRdHaf6Cy9OxuTsZsg9/w1RgpyfuXHs7qLt3P/ubpwteRq1j1 m2NzswEw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSRHQ-003Cwm-AI; Mon, 20 Sep 2021 21:56:52 +0000 Received: from mail-pg1-x534.google.com ([2607:f8b0:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mSRHM-003CwC-EW for linux-arm-kernel@lists.infradead.org; Mon, 20 Sep 2021 21:56:49 +0000 Received: by mail-pg1-x534.google.com with SMTP id n18so18751362pgm.12 for ; Mon, 20 Sep 2021 14:56:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kY/4eMbED4CLtz6FkJE/bYjN2trJmqcJcBgHfiCqU6o=; b=bOO4yQ0nZzQgEuX1DLTzV9WniMTMSauFJDXNpUhKe7qX4Qy9rVoUV8W4RWWhgPbNQI +7dZyowGszGTR8YabQ5aWV2weDZb5+RK6oHgmO3u9A2Gwz36c8F5KvSR4GZHvUuo2FwC qaj2s+ZV4Q412NuIFPsvVHjAv3+IMnXR1ZbjHHuBHFKbqsTXLwUWrwHdIeLBaLCiRLSV 5O9cdT4FPGre+whF+uMGz/HBSFfM1PtIpFHXP7ComNKLO07Rl+IJA3UTkAywtg82N1sJ LIUTbcxD7KR84EOI+z/HJm5zb8qYQ9ZWFvmCsnur2LNBYcKznrBCbOx7ZUo6IzYg2P2O Tqag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kY/4eMbED4CLtz6FkJE/bYjN2trJmqcJcBgHfiCqU6o=; b=6KWyVMzn9EiimeO4ElfH59vncyrjDsRDxGgM9aWxT+UoFpgaACkwtr/ecpLJWuVzpK gqrZ2FnxOsjzCwqGZscWe8Xo/AuK8B+7Wm0+5jiXZYv57NctdGU9dhvoWzIXApLGFqDE 5jlknX2KQHOJ5t6F+L4GzHFsNmSjpeVHSs4fdgpXO5Tv22IrR+PPDTArhfDLYblMmqnM 0jNY1ilRzDQMf3+JFdN3Hm+jk5PtDyVhqahZ8uZ+bJZ4kCjmhYgyQiZ1yWNbd433QosO U8vF4C/RQg+nt1jDz8R/lI9ZSpHW0y6VnoDhPNEUxm0WTVAcOnMITmQU1LICPcCceoH2 H/0w== X-Gm-Message-State: AOAM532Xygxzt6xHWd6NJyJ41sko67Ui6VUyG6swUg10iOpj6Dn/4cPn vNULW6NKLryQTFyK8eBY3T+9WZ3ujH4= X-Google-Smtp-Source: ABdhPJxQ8au0fvrMAOuU6/c0e4rCbbkPKrRZ9f6h4RiRmI2S+b1nnyXx4Y5P4zhFV1yekAos2s8zdQ== X-Received: by 2002:a63:35cc:: with SMTP id c195mr25143261pga.373.1632175006686; Mon, 20 Sep 2021 14:56:46 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id i12sm356346pjv.19.2021.09.20.14.56.45 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Sep 2021 14:56:45 -0700 (PDT) Subject: Re: [PATCH 7/9] net: mdio: mdio-bcm-iproc: simplify getting .driver_data To: Wolfram Sang , linux-kernel@vger.kernel.org Cc: linux-renesas-soc@vger.kernel.org, Andrew Lunn , Heiner Kallweit , Russell King , "David S. Miller" , Jakub Kicinski , Ray Jui , Scott Branden , bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20210920090522.23784-1-wsa+renesas@sang-engineering.com> <20210920090522.23784-8-wsa+renesas@sang-engineering.com> From: Florian Fainelli Message-ID: <6a8ffcab-4534-1692-5f6a-8a7906d07a09@gmail.com> Date: Mon, 20 Sep 2021 14:56:44 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210920090522.23784-8-wsa+renesas@sang-engineering.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210920_145648_563071_76C4EBD8 X-CRM114-Status: GOOD ( 21.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 9/20/21 2:05 AM, Wolfram Sang wrote: > We should get 'driver_data' from 'struct device' directly. Going via > platform_device is an unneeded step back and forth. > > Signed-off-by: Wolfram Sang > --- > > Build tested only. buildbot is happy. > > drivers/net/mdio/mdio-bcm-iproc.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/mdio/mdio-bcm-iproc.c b/drivers/net/mdio/mdio-bcm-iproc.c > index 77fc970cdfde..5666cfab15b9 100644 > --- a/drivers/net/mdio/mdio-bcm-iproc.c > +++ b/drivers/net/mdio/mdio-bcm-iproc.c > @@ -181,8 +181,7 @@ static int iproc_mdio_remove(struct platform_device *pdev) > #ifdef CONFIG_PM_SLEEP > static int iproc_mdio_resume(struct device *dev) > { > - struct platform_device *pdev = to_platform_device(dev); > - struct iproc_mdio_priv *priv = platform_get_drvdata(pdev); > + struct iproc_mdio_priv *priv = dev_get_drvdata(dev); The change looks good to me, however if you change from platform_get_drvdata() to dev_get_drvdata(), you might also want to change from using platform_set_drvdata() to dev_set_drvdata() for symmetry no? If not, then maybe this patch should be dropped? -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel