From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D2C7C4332F for ; Wed, 30 Nov 2022 15:00:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=YeQ7QC32wAm/OJq+3ySl7Pxwhk2/qQHPTJti7JbdDQs=; b=MbQdY7bu145k2U bI7EvRFEpjiO/GfMvBW+USSTl2aXbquh7sJJ7h0Vfqc0tHefTu2xb8HDt8iGXzPw9fRn7eXGXlzIz 5LZt0E+hvHrSj8IMlGHjurq+XAebaZCfC/Vdx0KKfzchxhPiLoUpruLEJPk4PGPL7H3HRwIszHHey PjQ3RPLotksvoXlyAV7GdNqaAYVFUSWc609XqpmqApwioAHkpUUf1x2EQB0LENhUpw203k4WvFhHC z35imVp5BqKWWI4cW0wwXVEwpr+QbKdu++rFfVzxhhF6vrR4gpdWGwrtf4lSRP/9ayqgYPWFZkCYv UxBnc4T0HBHFtq95/EtA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0OYA-00H9mJ-Gs; Wed, 30 Nov 2022 14:59:02 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p0OY7-00H9im-Nl for linux-arm-kernel@lists.infradead.org; Wed, 30 Nov 2022 14:59:01 +0000 Received: by mail-lf1-x132.google.com with SMTP id s8so27370404lfc.8 for ; Wed, 30 Nov 2022 06:58:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=pl2InFbLzXPnwLz/BDdvIJ0HA7H7JI78J3GfTa9SOrs=; b=hYA09kJlnmYDZUv/QcyTuR8k+MOtEInjm61sfk7jr37iMoviJ2BdqIKzIh+9ExHlux 72ELiyV0H6nXUEu6fso3lwuXkvc/uMGYGJpvqaLpZRgMInruZlYtsUWobNqGwLwr3ycP gAvVzLAz2JckcF9R/q87y1MInIqlf0EPKBzdOkZcCih89X/prwOqD1Ja9qufcIllfeZH sC3pk/qSBChKy1rf/ITJJ2fXL3J+eccGEsI6j0lot+5sCK0cak4+ZtVeCfWVgwUiWecx WJ+oLD/D/8jSA2Ys3p8JeRk2YP2d3Z7+WO6UEiLFiMhHlcgnIdOLBcueC2yLTSm7iUcU 9+ew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=pl2InFbLzXPnwLz/BDdvIJ0HA7H7JI78J3GfTa9SOrs=; b=12BDnLM3M8nph+bbd7+OkT/Oc2BaJDD1YddKJ2raHL1MWpxMQhOycJpm6gV7dIylxR XHcIyKpJjLh3uf//ulylmdQjV4GOBzzr+6D8oEQ9uoqmxF02i3v+tekZE8Hpdz+HyEm/ mdmOh0JiSxAeKXKZ14zt/WUeQvoEaottgJVSXg3xVCa92kBPxnYqE9XidrISJGG02nBU BweNGf6kli+NMQ6yqltU2upGlm7Cm5EXzBuuZ4IQU33k2pquz7b5zuMvviy38CVkrJne TMDy2hCS2cvEvOctesR5ZEUu+sbYBCOUBhh77H0DXw4m9LYrXX604IOQzi0BIlmpJ5SR X97g== X-Gm-Message-State: ANoB5pmxX8IIvLrapoOPgu0l+/n5SVcqKslEm9Vj/Ge6ZNgjiaximLdw sprMn5IH4BWKBGGsp5kVo+LTHg== X-Google-Smtp-Source: AA0mqf45fgbVjjbldIXdB9H5YpsizXMDOt91gJQXars+ZMhuW5DggTaINvTYwluNiGS7CWzmc24EJw== X-Received: by 2002:a05:6512:20c3:b0:4a2:776f:f3c6 with SMTP id u3-20020a05651220c300b004a2776ff3c6mr19691347lfr.302.1669820333591; Wed, 30 Nov 2022 06:58:53 -0800 (PST) Received: from [192.168.0.20] (088156142067.dynamic-2-waw-k-3-2-0.vectranet.pl. [88.156.142.67]) by smtp.gmail.com with ESMTPSA id v5-20020ac258e5000000b00492ea54beeasm280631lfo.306.2022.11.30.06.58.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 30 Nov 2022 06:58:53 -0800 (PST) Message-ID: <6ad95ce3-887d-48fd-3c08-f50d4e666ded@linaro.org> Date: Wed, 30 Nov 2022 15:58:52 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH v2 1/2] dt-bindings: pinctrl: add schema for NXP S32 SoCs Content-Language: en-US To: Chester Lin , Rob Herring , Linus Walleij , Krzysztof Kozlowski Cc: s32@nxp.com, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Larisa Grigore , Ghennadi Procopciuc , Andrei Stefanescu , =?UTF-8?Q?Andreas_F=c3=a4rber?= , Matthias Brugger References: <20221128054820.1771-1-clin@suse.com> <20221128054820.1771-2-clin@suse.com> From: Krzysztof Kozlowski In-Reply-To: <20221128054820.1771-2-clin@suse.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221130_065859_821263_FF4A54E5 X-CRM114-Status: GOOD ( 29.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 28/11/2022 06:48, Chester Lin wrote: > Add DT schema for the pinctrl driver of NXP S32 SoC family. > > Signed-off-by: Larisa Grigore > Signed-off-by: Ghennadi Procopciuc > Signed-off-by: Andrei Stefanescu > Signed-off-by: Chester Lin > --- > > Changes in v2: > - Remove the "nxp,pins" property since it has been moved into the driver. > - Add descriptions for reg entries. > - Refine the compatible name from "nxp,s32g-..." to "nxp,s32g2-...". > - Fix schema issues and revise the example. > - Fix the copyright format suggested by NXP. > > .../pinctrl/nxp,s32cc-siul2-pinctrl.yaml | 125 ++++++++++++++++++ > 1 file changed, 125 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/nxp,s32cc-siul2-pinctrl.yaml > > diff --git a/Documentation/devicetree/bindings/pinctrl/nxp,s32cc-siul2-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/nxp,s32cc-siul2-pinctrl.yaml > new file mode 100644 > index 000000000000..2fc25a9362af > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/nxp,s32cc-siul2-pinctrl.yaml Usually filename matches the compatible (or family name), so any reason why compatible is "nxp,s32g2" but filename is "nxp,s32cc"? > @@ -0,0 +1,125 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2022 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/pinctrl/nxp,s32cc-siul2-pinctrl.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP S32 Common Chassis SIUL2 iomux controller > + > +maintainers: > + - Ghennadi Procopciuc > + - Chester Lin > + > +description: | > + Core driver for the pin controller found on S32 Common Chassis SoC. If "Core driver for the" refers to Linux driver, then drop it. If refers to something else, please elaborate. > + > +properties: > + compatible: > + enum: > + - nxp,s32g2-siul2-pinctrl > + > + reg: > + description: > + A list of MSCR/IMCR register regions to be reserved. > + - MSCR (Multiplexed Signal Configuration Register) > + An MSCR register can configure the associated pin as either a GPIO pin > + or a function output pin depends on the selected signal source. > + - IMCR (Input Multiplexed Signal Configuration Register) > + An IMCR register can configure the associated pin as function input > + pin depends on the selected signal source. > + minItems: 5 > + items: > + - description: MSCR registers group 0 managed by the SIUL2 controller 0 > + - description: MSCR registers group 1 managed by the SIUL2 controller 1 > + - description: MSCR registers group 2 managed by the SIUL2 controller 1 > + - description: IMCR registers group 0 managed by the SIUL2 controller 0 > + - description: IMCR registers group 1 managed by the SIUL2 controller 1 > + - description: IMCR registers group 2 managed by the SIUL2 controller 1 > + > +required: > + - compatible > + - reg required goes after all properties, so below patternProperties. > + > +patternProperties: > + '-pins$': > + type: object > + additionalProperties: false > + > + patternProperties: > + '-grp[0-9]$': > + type: object > + allOf: > + - $ref: pinmux-node.yaml# > + - $ref: pincfg-node.yaml# > + unevaluatedProperties: false > + description: > + Pinctrl node's client devices specify pin muxes using subnodes, > + which in turn use the standard properties. All properties are accepted? What about values, e.g. for drive strength? > + > +additionalProperties: false > + > +examples: > + - | > + > + /* Pins functions (SSS field) */ > + #define FUNC0 0 > + #define FUNC1 1 > + #define FUNC2 2 > + #define FUNC3 3 > + #define FUNC4 4 > + #define FUNC5 5 > + #define FUNC6 6 > + #define FUNC7 7 > + > + #define S32CC_PINMUX(PIN, FUNC) (((PIN) << 4) | (FUNC)) > + > + #define S32CC_SLEW_208MHZ 0 > + #define S32CC_SLEW_166MHZ 4 > + #define S32CC_SLEW_150MHZ 5 > + #define S32CC_SLEW_133MHZ 6 > + #define S32CC_SLEW_83MHZ 7 > + > + pinctrl@4009c240 { > + compatible = "nxp,s32g2-siul2-pinctrl"; > + > + /* > + * There are two SIUL2 controllers in S32G2: > + * > + * siul2_0 @ 0x4009c000 > + * siul2_1 @ 0x44010000 > + * > + * Every SIUL2 controller has multiple register types, and here > + * only MSCR and IMCR registers need to be revealed for kernel > + * to configure pinmux. Please note that some indexes are reserved, > + * such as MSCR102-MSCR111 in the following reg property. > + */ > + Either this should be part of description or should be dropped. It blows example and probably duplicates DTS. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel