From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 260BDC4338F for ; Thu, 19 Aug 2021 23:05:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E1F756109E for ; Thu, 19 Aug 2021 23:05:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E1F756109E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JGLwfz9n0CH2Yj0HDCVRS807d5S92bPhBxU0W3Cty/0=; b=IX8CKokXYZ/s2rVNytiAJwKAkw oJ/sd3YBgu9o5MIawhUnAu+qamMVUW3y8LkfnYAhHd+bIrFPXaNTNxn2wx2MK/hq2OcPtB8J2wYvj OYb29ITiB5EtGHQeq+61VWDa/BlCB31kWWffGryOvv2F6ffAYyulrZWtNcDyVtJjszy2isRxCx3Ch k0CjT+jfaG/pzSHSeUT4jM8Kf3d2Ca9mWJOJvFNeXgZx6RtSMYMkf3PKQzf6sDaMd+TfYZzNu7LNK 22rJHAy/IGGX44sYmyLRd5P7VDm9m+QtTBRMzxYHq6O9G8JRgL8HMHJOTgnF1ktXQPOGd5jFBtTW0 ZWyDFrcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGr43-009h31-48; Thu, 19 Aug 2021 23:03:11 +0000 Received: from mx.socionext.com ([202.248.49.38]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGr40-009h1u-02 for linux-arm-kernel@lists.infradead.org; Thu, 19 Aug 2021 23:03:09 +0000 Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 20 Aug 2021 08:03:03 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id CD33D2022041; Fri, 20 Aug 2021 08:03:03 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Fri, 20 Aug 2021 08:03:03 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by kinkan2.css.socionext.com (Postfix) with ESMTP id 7DB5DB631E; Fri, 20 Aug 2021 08:03:03 +0900 (JST) Received: from [10.212.29.185] (unknown [10.212.29.185]) by yuzu2.css.socionext.com (Postfix) with ESMTP id BB673A911B; Fri, 20 Aug 2021 08:03:02 +0900 (JST) Subject: Re: [PATCH] PCI: uniphier: Take lock in INTX irq_{mask,unmask,ack} callbacks To: Bjorn Helgaas Cc: Lorenzo Pieralisi , Rob Herring , =?UTF-8?Q?Krzysztof_Wilczy=c5=84ski?= , Bjorn Helgaas , =?UTF-8?Q?Pali_Roh=c3=a1r?= , Masami Hiramatsu , linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20210819112908.GA3188927@bjorn-Precision-5520> From: Kunihiko Hayashi Message-ID: <6ae226a6-dc3d-94da-a356-6bd78053de06@socionext.com> Date: Fri, 20 Aug 2021 08:03:02 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210819112908.GA3188927@bjorn-Precision-5520> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210819_160308_208014_D09FCD93 X-CRM114-Status: GOOD ( 13.83 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Bjorn, Thank you for checking. On 2021/08/19 20:29, Bjorn Helgaas wrote: > Possibly update subject to be more descriptive, along lines of: > > Serialize INTx masking/unmasking Okay, I'll apply it to the subject. > On Thu, Aug 19, 2021 at 07:56:06PM +0900, Kunihiko Hayashi wrote: >> The same condition register PCI_RCV_INTX is used in irq_mask(), >> irq_unmask() and irq_ack() callbacks. Accesses to register can occur at the >> same time without lock. >> This introduces a lock into the callbacks to prevent the issue. > > Rewrap into a single paragraph or add blank line between paragraphs. > > s/This introduces/Add/ to make this an imperative description of what > you want this patch to do. No need for "This" since the context is > obvious. I see. I'll rewrite the message to convey it more directly. Thank you, --- Best Regards Kunihiko Hayashi _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel