[PATCH] spi: axiado: Remove redundant pm_runtime_mark_last_busy() call

[PATCH] spi: axiado: Remove redundant pm_runtime_mark_last_busy() call

[Felix Gu]

The pm_runtime_mark_last_busy() call is redundant in the probe function
as pm_runtime_put_autosuspend() already calls pm_runtime_mark_last_busy()
internally to update the last access time of the device before queuing
autosuspend.

Fixes: e75a6b00ad79 ("spi: axiado: Add driver for Axiado SPI DB controller")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
---
 drivers/spi/spi-axiado.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-axiado.c b/drivers/spi/spi-axiado.c
index 8cea81432c5b..bd5f67acc4f6 100644
--- a/drivers/spi/spi-axiado.c
+++ b/drivers/spi/spi-axiado.c
@@ -850,7 +850,6 @@ static int ax_spi_probe(struct platform_device *pdev)
 
 	ctlr->bits_per_word_mask = SPI_BPW_MASK(8);
 
-	pm_runtime_mark_last_busy(&pdev->dev);
 	pm_runtime_put_autosuspend(&pdev->dev);
 
 	ctlr->mem_ops = &ax_spi_mem_ops;

---
base-commit: a0ae2a256046c0c5d3778d1a194ff2e171f16e5f
change-id: 20260307-axiado-1-6c84296be4a2

Best regards,
-- 
Felix Gu <ustc.gu@gmail.com>

Re: [PATCH] spi: axiado: Remove redundant pm_runtime_mark_last_busy() call

[Markus Elfring]

…
> +++ b/drivers/spi/spi-axiado.c
> @@ -850,7 +850,6 @@ static int ax_spi_probe(struct platform_device *pdev)
>  
>  	ctlr->bits_per_word_mask = SPI_BPW_MASK(8);
>  
> -	pm_runtime_mark_last_busy(&pdev->dev);
>  	pm_runtime_put_autosuspend(&pdev->dev);
>  
>  	ctlr->mem_ops = &ax_spi_mem_ops;

How do you think about to construct another coccicheck script
for such a source code transformation pattern?
https://elixir.bootlin.com/linux/v7.0-rc3/source/include/linux/pm_runtime.h#L579-L603

Regards,
Markus

Re: [PATCH] spi: axiado: Remove redundant pm_runtime_mark_last_busy() call

[Mark Brown]

On Sat, 07 Mar 2026 15:47:15 +0800, Felix Gu wrote:
> spi: axiado: Remove redundant pm_runtime_mark_last_busy() call

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-7.1

Thanks!

[1/1] spi: axiado: Remove redundant pm_runtime_mark_last_busy() call
      https://git.kernel.org/broonie/misc/c/ec6c2e15a42f

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark