public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: "Macpaul Lin" <macpaul.lin@mediatek.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	"Conor Dooley" <conor+dt@kernel.org>,
	"Matthias Brugger" <matthias.bgg@gmail.com>,
	"AngeloGioacchino Del Regno"
	<angelogioacchino.delregno@collabora.com>,
	"Bernhard Rosenkränzer" <bero@baylibre.com>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Cc: Bear Wang <bear.wang@mediatek.com>,
	Pablo Sun <pablo.sun@mediatek.com>,
	Macpaul Lin <macpaul@gmail.com>
Subject: Re: [PATCH] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board
Date: Mon, 11 Sep 2023 11:47:50 +0200	[thread overview]
Message-ID: <6b1f1e97-f747-eab4-86ec-39be487e6956@linaro.org> (raw)
In-Reply-To: <e697a23e-e677-c97b-269a-a7a11d338d95@mediatek.com>

On 11/09/2023 10:16, Macpaul Lin wrote:
> 
> 
> On 9/11/23 15:06, Krzysztof Kozlowski wrote:
>> 	
>>
>> External email : Please do not click links or open attachments until you 
>> have verified the sender or the content.
>>
>> On 11/09/2023 08:34, Macpaul Lin wrote:
>>> On 9/11/23 14:09, Krzysztof Kozlowski wrote:
>>>>
>>>>
>>>> External email : Please do not click links or open attachments until you 
>>>> have verified the sender or the content.
>>>>
>>>> On 10/09/2023 14:07, Macpaul Lin wrote:
>>>>>
>>>>>
>>>>> On 9/10/23 17:09, Krzysztof Kozlowski wrote:
>>>>>>> +      - description: MediaTek Genio 350 Boards (Genio 350 EVK)
>>>>>>
>>>>>> That's a bit confusing. So all of the boards here will be Genio 350 EVK?
>>>>>> I don't get what is the point of this description.
>>>>>>
>>>>>>
>>>>>>> +        items:
>>>>>>>            - enum:
>>>>>>>                - mediatek,mt8365-evk
>>>>>>>            - const: mediatek,mt8365
>>>>>
>>>>> Thes boards with compatible 'mediatek,mt8365-evk' is indeed used by
>>>>
>>>> Boards?
>>>
>>> I'm not sure if there will be more hardware version released to market.
>>> Current the p1v3 is the final version of mt8365-evk.
>>
>> Then your code (enum) does not match description. The code is saying:
>> this is for multiple boards based on mt8365.
>>
>> Your description is saying: this is only for 350 boards.
>>
>> Now your email is saying: there is only one 350 board.
>>
>> Three different versions. Sorry, I am confused.
>>
> 
> Okay, this description has been modified to support single board.
> Since there is only one type of the hardware is available on the market.

Then why the code uses enum?



Best regards,
Krzysztof


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-11  9:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-10  6:28 [PATCH] dt-bindings: arm64: dts: mediatek: add description for mt8365-evk board Macpaul Lin
2023-09-10  9:09 ` Krzysztof Kozlowski
2023-09-10 12:07   ` Macpaul Lin
2023-09-11  6:09     ` Krzysztof Kozlowski
2023-09-11  6:34       ` Macpaul Lin
2023-09-11  7:06         ` Krzysztof Kozlowski
2023-09-11  8:16           ` Macpaul Lin
2023-09-11  9:47             ` Krzysztof Kozlowski [this message]
2023-09-11  9:49   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b1f1e97-f747-eab4-86ec-39be487e6956@linaro.org \
    --to=krzysztof.kozlowski@linaro.org \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=bear.wang@mediatek.com \
    --cc=bero@baylibre.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=macpaul.lin@mediatek.com \
    --cc=macpaul@gmail.com \
    --cc=matthias.bgg@gmail.com \
    --cc=pablo.sun@mediatek.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox