From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8021DEB64D8 for ; Tue, 20 Jun 2023 16:31:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BypyKVBe0gSRfF5ucjdBUvO6BQOtpRxUIDSL8jzjyDI=; b=p6S7FvJTez9C0M BE2IK5QjyGKLccwTiJQXObaJbql8aESQDzXeSMfna9va98zzWDMhnppViyLOK6b5msq8HZwQj8/Jp F2vVCrsHzkVAEO9gShzsWYaBGPAFDX6M8UxCzvCb1nhzFZ/x9EGYcBsucnlN46YOaHLoGwN3yhZTy X7YMF48T4C/Rfi3J5jUf9fMCV84hzIPH0GJ7gMKPpvDT3zPhQQ7p6reKST+bNSfp3zDGUp7jJ54Uu 5FXgrKzQxJR96m/v24UEuDZHI6L+Vjio74QuOpnFa8Z5EjHr5xlSIDCZJyBjiHnLXa4t25MwOB4l/ mBr4x8bNFugTGwfk1YDw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qBeGB-00BpDm-2Q; Tue, 20 Jun 2023 16:31:15 +0000 Received: from madras.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e5ab]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qBeG8-00BpC4-0d; Tue, 20 Jun 2023 16:31:14 +0000 Received: from notapiano (zone.collabora.co.uk [167.235.23.81]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: nfraprado) by madras.collabora.co.uk (Postfix) with ESMTPSA id 2D5FD6600873; Tue, 20 Jun 2023 17:31:06 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1687278669; bh=Y9tvPReig8gmKXdmzgK1D+yZ0bHJi1pX+/SYM0CaaCQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Vf3K1+F7Y1XW2cVGXJmAn9KJj9mP5Epmo3LI1I5+xTE73Yqh5QgptpZv5v2f/lGZf xh74/x7jKjp0g06k3QYw7oDfGwJT0WmnC1aPXCuXaiolPKDVbZTbaqpLv9ku/nyV5a Dkh3fNuZlWN872H4KcidPxRI6iufj1fBDptlXqh6lBGsRvlOzM0u9cTxN2OA5R2iFM eT5iL/l8x2UE3TiF++xHqLYwHgGX2iJDPp4yAcSX2RPt6IQiL9EAh3J0O2bdvgvn/v RF/ArBZ3zEEjzdZJPQ6jzPdzVDNB0HkYKRcXmgTwzft5LrbfGn3s04WCRclDh7Nwv5 EwO5rEpF3MoRw== Date: Tue, 20 Jun 2023 12:31:02 -0400 From: =?utf-8?B?TsOtY29sYXMgRi4gUi4gQS4=?= Prado To: Krzysztof Kozlowski Cc: Matthias Brugger , Hans Verkuil , AngeloGioacchino Del Regno , kernel@collabora.com, Andrew-CT Chen , Conor Dooley , Krzysztof Kozlowski , Mauro Carvalho Chehab , Rob Herring , Tiffany Lin , Yunfei Dong , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v3 3/6] media: dt-bindings: mediatek,vcodec: Remove VDEC_SYS for mt8183 Message-ID: <6b41c5e4-bae9-4c99-8a28-7272c8a598a3@notapiano> References: <20230620000349.2122191-1-nfraprado@collabora.com> <20230620000349.2122191-4-nfraprado@collabora.com> <8b5e4a9b-7496-02a1-d3b6-a0be8ea85798@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230620_093112_547490_AF3E26A2 X-CRM114-Status: GOOD ( 33.73 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Jun 20, 2023 at 03:00:00PM +0200, Krzysztof Kozlowski wrote: > On 20/06/2023 14:46, N=EDcolas F. R. A. Prado wrote: > > On Tue, Jun 20, 2023 at 10:12:14AM +0200, Krzysztof Kozlowski wrote: > >> On 20/06/2023 02:03, N=EDcolas F. R. A. Prado wrote: > >>> The binding expects the first register space to be VDEC_SYS. But on > >>> mt8183, which uses the stateless decoders, this space is used only for > >>> controlling clocks and resets, which are better described as separate > >>> clock-controller and reset-controller nodes. > >>> > >>> In fact, in mt8173's devicetree there are already such separate > >>> clock-controller nodes, which cause duplicate addresses between the > >>> vdecsys node and the vcodec node. But for this SoC, since the stateful > >>> decoder code makes other uses of the VDEC_SYS register space, it's not > >>> straightforward to remove it. > >>> > >>> In order to avoid the same address conflict to happen on mt8183, > >>> since the only current use of the VDEC_SYS register space in > >>> the driver is to read the status of a hardware controlled clock, remo= ve > >>> the VDEC_SYS register space from the binding and describe an extra > >>> syscon that will be used to directly check the hardware status. > >>> > >>> Also add reg-names to be able to tell that this new register schema is > >>> used, so the driver can keep backward compatibility. > >>> > >>> Signed-off-by: N=EDcolas F. R. A. Prado > >>> > >>> --- > >>> I dropped the tags from this commit since a syscon is now used instead > >>> of an extra clock. > >>> > >>> Changes in v3: > >>> - Removed the active clock > >>> - Added a mediatek,vdecsys syscon property > >>> > >>> Changes in v2: > >>> - Merged with patch 1 (media: dt-bindings: mediatek,vcodec: Allow sin= gle > >>> clock for mt8183) to avoid changing number of clocks twice > >>> - Added maxItems to reg-names > >>> - Constrained clocks for each compatible > >>> - Reordered properties for each compatible > >>> > >>> .../media/mediatek,vcodec-decoder.yaml | 30 +++++++++++++++++= ++ > >>> 1 file changed, 30 insertions(+) > >>> > >>> diff --git a/Documentation/devicetree/bindings/media/mediatek,vcodec-= decoder.yaml b/Documentation/devicetree/bindings/media/mediatek,vcodec-deco= der.yaml > >>> index 1e56ece44aee..2f625c50bbfe 100644 > >>> --- a/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder= .yaml > >>> +++ b/Documentation/devicetree/bindings/media/mediatek,vcodec-decoder= .yaml > >>> @@ -21,8 +21,13 @@ properties: > >>> - mediatek,mt8183-vcodec-dec > >>> = > >>> reg: > >>> + minItems: 11 > >>> maxItems: 12 > >>> = > >>> + reg-names: > >>> + minItems: 11 > >>> + maxItems: 11 > >> > >> maxItems: 12 > >> > >>> + > >>> interrupts: > >>> maxItems: 1 > >>> = > >>> @@ -60,6 +65,10 @@ properties: > >>> description: > >>> Describes point to scp. > >>> = > >>> + mediatek,vdecsys: > >>> + $ref: /schemas/types.yaml#/definitions/phandle > >>> + description: Phandle to the vdecsys syscon node. > >>> + > >>> required: > >>> - compatible > >>> - reg > >>> @@ -79,8 +88,26 @@ allOf: > >>> then: > >>> required: > >>> - mediatek,scp > >>> + - mediatek,vdecsys > >>> = > >>> properties: > >>> + reg: > >>> + maxItems: 11 > >>> + > >>> + reg-names: > >>> + items: > >>> + - const: misc > >>> + - const: ld > >>> + - const: top > >>> + - const: cm > >>> + - const: ad > >>> + - const: av > >>> + - const: pp > >>> + - const: hwd > >>> + - const: hwq > >>> + - const: hwb > >>> + - const: hwg > >>> + > >>> clocks: > >>> minItems: 1 > >>> maxItems: 1 > >>> @@ -101,6 +128,9 @@ allOf: > >>> - mediatek,vpu > >>> = > >>> properties: > >>> + reg: > >>> + minItems: 12 > >> > >> > >> What about reg-names here? They should be also defined and in sync with > >> regs. > > = > > That's intentional. As described in the commit message, mt8173 will kee= p having > > the VDEC_SYS iospace, while mt8183 won't. And we use the presence of re= g-names > > to tell them apart. > > = > > So, mt8173 has 12 regs, no reg-names and no syscon, while mt8183 has 11= regs, > > with reg-names and the syscon. > = > reg-names is not the way to tell apart variants. Compatible is. If you > add reg-names for one variant, it's expected to have it defined for > other as well, because the order of items in reg is always fixed. But differentiating with compatible in this case would be wrong, since it's= not not something inherent to the SoC. We really just want to be able to tell whether the vdecsys iospace is supplied as a reg or as a syscon. This series focuses on getting the mt8183 decoder working, and as part of t= hat introduces the binding and DT node for mt8183 with vdecsys as a syscon inst= ead of a reg, to avoid introducing new 'duplicate unit-address' DT warnings. But in a separate series we could drop vdecsys from mt8173's reg as well, passing it as a syscon instead, which would solve the warning on that platf= orm, though some more driver changes would be needed to be able to handle it for= that SoC. The newer SoCs like mt8192, mt8195, etc, should also get vdecsys dropp= ed from their regs to have a correct memory description. Thanks, N=EDcolas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel