linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: mohit.kumar@st.com (Mohit Kumar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 08/12] pcie: designware: Fix IO transfers
Date: Wed, 11 Dec 2013 15:08:33 +0530	[thread overview]
Message-ID: <6b4282b9e793ec89ba0c20f3362d41f6133a8132.1386752447.git.mohit.kumar@st.com> (raw)
In-Reply-To: <cover.1386752447.git.mohit.kumar@st.com>

From: Pratyush Anand <pratyush.anand@st.com>

pp->io_base which is the input of the outbound IO address translation
unit should be the cpu address, it was programmed wrongly to realio
address.

We should pass global_io_offset rather than sys->io_offset to
pci_ioremap_io, so we map the new window into the first available spot
in the Linux view of the I/O space.

We must also pass cpu address instead  of realio address to
pci_ioremap_io.

This patch fixes above issue. It has been tested with Lecroy PTC in AIC
mode and Pericom PI7C9X2G303EL PCIe switch, which does not work
otherwise.

Signed-off-by: Pratyush Anand <pratyush.anand@st.com>
Tested-by: Mohit Kumar <mohit.kumar@st.com>
Tested-by: Tim Harvey <tharvey@gateworks.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Marek Vasut <marex@denx.de>
Cc: Richard Zhu <Hong-Xing.Zhu@freescale.com>
Cc: linux-pci at vger.kernel.org
Cc: spear-devel at list.st.com
---
 drivers/pci/host/pcie-designware.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c
index be6ce30..071ebc0 100644
--- a/drivers/pci/host/pcie-designware.c
+++ b/drivers/pci/host/pcie-designware.c
@@ -378,6 +378,7 @@ int __init dw_pcie_host_init(struct pcie_port *pp)
 					   + global_io_offset);
 			pp->config.io_size = resource_size(&pp->io);
 			pp->config.io_bus_addr = range.pci_addr;
+			pp->io_base = range.cpu_addr;
 		}
 		if (restype == IORESOURCE_MEM) {
 			of_pci_range_to_resource(&range, np, &pp->mem);
@@ -403,7 +404,6 @@ int __init dw_pcie_host_init(struct pcie_port *pp)
 
 	pp->cfg0_base = pp->cfg.start;
 	pp->cfg1_base = pp->cfg.start + pp->config.cfg0_size;
-	pp->io_base = pp->io.start;
 	pp->mem_base = pp->mem.start;
 
 	pp->va_cfg0_base = devm_ioremap(pp->dev, pp->cfg0_base,
@@ -573,7 +573,6 @@ static int dw_pcie_wr_other_conf(struct pcie_port *pp, struct pci_bus *bus,
 	return ret;
 }
 
-
 static int dw_pcie_valid_config(struct pcie_port *pp,
 				struct pci_bus *bus, int dev)
 {
@@ -667,7 +666,7 @@ static int dw_pcie_setup(int nr, struct pci_sys_data *sys)
 
 	if (global_io_offset < SZ_1M && pp->config.io_size > 0) {
 		sys->io_offset = global_io_offset - pp->config.io_bus_addr;
-		pci_ioremap_io(sys->io_offset, pp->io.start);
+		pci_ioremap_io(global_io_offset, pp->io_base);
 		global_io_offset += SZ_64K;
 		pci_add_resource_offset(&sys->resources, &pp->io,
 					sys->io_offset);
-- 
1.7.0.1

  parent reply	other threads:[~2013-12-11  9:38 UTC|newest]

Thread overview: 54+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-11  9:38 [PATCH 00/12] PCI:Add SPEAr13xx PCie support Mohit Kumar
2013-12-11  9:38 ` [PATCH 01/12] SPEAr13xx: Correct dt field name for stmmac phy-addr Mohit Kumar
2013-12-11 11:09   ` Rajeev kumar
2013-12-11 11:14     ` Rajeev kumar
2013-12-12  0:39     ` Jingoo Han
2013-12-12  3:59       ` Rajeev kumar
2013-12-12  4:07         ` Chen-Yu Tsai
2013-12-12  5:13           ` Mohit KUMAR DCG
2013-12-11  9:38 ` [PATCH 02/12] SPEAr13xx: Move SPEAr1340 definitions to header file Mohit Kumar
2013-12-11 22:48   ` Arnd Bergmann
2013-12-13  4:18     ` Mohit KUMAR DCG
2013-12-14 19:02       ` Arnd Bergmann
2014-01-16  7:25         ` Mohit KUMAR DCG
2014-01-16  9:19           ` Pratyush Anand
2014-01-16 11:33             ` Arnd Bergmann
2014-01-16 11:45               ` Pratyush Anand
2013-12-11  9:38 ` [PATCH 03/12] SPEAr13xx: Add SPEAr1310 PCIe register definitions Mohit Kumar
2013-12-11 22:51   ` Arnd Bergmann
2013-12-11  9:38 ` [PATCH 04/12] SPEAr13xx: Fix static mapping table Mohit Kumar
2013-12-11  9:38 ` [PATCH 05/12] clk: SPEAr13xx: Fix pcie clock name Mohit Kumar
2013-12-11 22:42   ` Arnd Bergmann
2013-12-12  5:00     ` Mohit KUMAR DCG
2013-12-12 21:30       ` Arnd Bergmann
2013-12-11  9:38 ` [PATCH 06/12] pcie: designware: Move register definition to the header file Mohit Kumar
2013-12-11 11:38   ` Jagan Teki
2013-12-11 11:55     ` Mohit KUMAR DCG
2013-12-11 12:04       ` Jagan Teki
2013-12-11 21:31       ` Arnd Bergmann
2013-12-11 22:48         ` Jingoo Han
2013-12-12  4:55           ` Mohit KUMAR DCG
2013-12-11  9:38 ` [PATCH 07/12] pcie: designware: add dw_pcie prefix before cfg_read/write Mohit Kumar
2013-12-11 11:40   ` Jagan Teki
2013-12-12  1:12     ` Jingoo Han
2013-12-12  1:05   ` Jingoo Han
2013-12-20 16:35   ` Bjorn Helgaas
2013-12-11  9:38 ` Mohit Kumar [this message]
2013-12-11 10:03   ` [PATCH 08/12] pcie: designware: Fix IO transfers Marek Vasut
2013-12-11 11:29     ` Jagan Teki
2013-12-12  1:17       ` Jingoo Han
2013-12-20  3:47         ` Pratyush Anand
2013-12-11 13:34   ` Arnd Bergmann
2013-12-11 23:34   ` Jingoo Han
2013-12-20 16:36   ` Bjorn Helgaas
2013-12-11  9:38 ` [PATCH 09/12] pcie: SPEAr13xx: Add designware pcie support Mohit Kumar
2013-12-11 23:00   ` Arnd Bergmann
2013-12-13  4:30     ` Mohit KUMAR DCG
2013-12-13  4:57       ` Jingoo Han
2013-12-14 19:01         ` Arnd Bergmann
2013-12-11  9:38 ` [PATCH 10/12] SPEAr13xx: defconfig: Update Mohit Kumar
2013-12-11 10:47   ` Rajeev kumar
2013-12-12  4:47     ` Mohit KUMAR DCG
2013-12-11  9:38 ` [PATCH 11/12] MAINTAINERS: Add ST SPEAr13xx PCIe driver maintainer Mohit Kumar
2013-12-12  1:55   ` Jingoo Han
2013-12-11  9:38 ` [PATCH 12/12] MAINTAINERS: Add Synopsis Designware " Mohit Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6b4282b9e793ec89ba0c20f3362d41f6133a8132.1386752447.git.mohit.kumar@st.com \
    --to=mohit.kumar@st.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).