[PATCH] perf script: Fix typo in branch event mask

linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed

* [PATCH] perf script: Fix typo in branch event mask
@ 2025-03-12  7:56 Yujie Liu
  2025-03-12  9:56 ` Leo Yan
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Yujie Liu @ 2025-03-12  7:56 UTC (permalink / raw)
  To: linux-perf-users, linux-kernel, linux-arm-kernel
  Cc: Leo Yan, Arnaldo Carvalho de Melo, Namhyung Kim, Ian Rogers,
	James Clark, Adrian Hunter, Jiri Olsa, Liang, Kan, Mark Rutland,
	Will Deacon, Mike Leach, Graham Woodward, Paschalis.Mpeis

BRACH -> BRANCH

Fixes: 88b1473135e4 ("perf script: Separate events from branch types")
Signed-off-by: Yujie Liu <yujie.liu@intel.com>
---
 tools/perf/util/event.h                 | 2 +-
 tools/perf/util/trace-event-scripting.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
index c7f4b4b841ca..664bf39567ce 100644
--- a/tools/perf/util/event.h
+++ b/tools/perf/util/event.h
@@ -91,7 +91,7 @@ enum {
 	PERF_IP_FLAG_VMENTRY		|\
 	PERF_IP_FLAG_VMEXIT)
 
-#define PERF_IP_FLAG_BRACH_EVENT_MASK	\
+#define PERF_IP_FLAG_BRANCH_EVENT_MASK	\
 	(PERF_IP_FLAG_BRANCH_MISS |	\
 	 PERF_IP_FLAG_NOT_TAKEN)
 
diff --git a/tools/perf/util/trace-event-scripting.c b/tools/perf/util/trace-event-scripting.c
index 29cc467be14a..72abb28b7b5a 100644
--- a/tools/perf/util/trace-event-scripting.c
+++ b/tools/perf/util/trace-event-scripting.c
@@ -347,7 +347,7 @@ static int sample_flags_to_name(u32 flags, char *str, size_t size)
 
 	flags &= ~(PERF_IP_FLAG_TRACE_BEGIN | PERF_IP_FLAG_TRACE_END);
 
-	types = flags & ~PERF_IP_FLAG_BRACH_EVENT_MASK;
+	types = flags & ~PERF_IP_FLAG_BRANCH_EVENT_MASK;
 	for (i = 0; sample_flags[i].name; i++) {
 		if (sample_flags[i].flags != types)
 			continue;
@@ -359,7 +359,7 @@ static int sample_flags_to_name(u32 flags, char *str, size_t size)
 		break;
 	}
 
-	events = flags & PERF_IP_FLAG_BRACH_EVENT_MASK;
+	events = flags & PERF_IP_FLAG_BRANCH_EVENT_MASK;
 	for (i = 0; branch_events[i].name; i++) {
 		if (!(branch_events[i].flags & events))
 			continue;

base-commit: b10f74308e1305275e69ddde711ec817cc69e306
-- 
2.34.1



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf script: Fix typo in branch event mask
  2025-03-12  7:56 [PATCH] perf script: Fix typo in branch event mask Yujie Liu
@ 2025-03-12  9:56 ` Leo Yan
  2025-03-12 10:02 ` James Clark
  2025-03-14 17:43 ` Namhyung Kim
  2 siblings, 0 replies; 4+ messages in thread
From: Leo Yan @ 2025-03-12  9:56 UTC (permalink / raw)
  To: Yujie Liu
  Cc: linux-perf-users, linux-kernel, linux-arm-kernel,
	Arnaldo Carvalho de Melo, Namhyung Kim, Ian Rogers, James Clark,
	Adrian Hunter, Jiri Olsa, Liang, Kan, Mark Rutland, Will Deacon,
	Mike Leach, Graham Woodward, Paschalis.Mpeis

On Wed, Mar 12, 2025 at 03:56:36PM +0800, Yujie Liu wrote:
> BRACH -> BRANCH
> 
> Fixes: 88b1473135e4 ("perf script: Separate events from branch types")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>

Reviewed-by: Leo Yan <leo.yan@arm.com>

> ---
>  tools/perf/util/event.h                 | 2 +-
>  tools/perf/util/trace-event-scripting.c | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
> index c7f4b4b841ca..664bf39567ce 100644
> --- a/tools/perf/util/event.h
> +++ b/tools/perf/util/event.h
> @@ -91,7 +91,7 @@ enum {
>  	PERF_IP_FLAG_VMENTRY		|\
>  	PERF_IP_FLAG_VMEXIT)
>  
> -#define PERF_IP_FLAG_BRACH_EVENT_MASK	\
> +#define PERF_IP_FLAG_BRANCH_EVENT_MASK	\
>  	(PERF_IP_FLAG_BRANCH_MISS |	\
>  	 PERF_IP_FLAG_NOT_TAKEN)
>  
> diff --git a/tools/perf/util/trace-event-scripting.c b/tools/perf/util/trace-event-scripting.c
> index 29cc467be14a..72abb28b7b5a 100644
> --- a/tools/perf/util/trace-event-scripting.c
> +++ b/tools/perf/util/trace-event-scripting.c
> @@ -347,7 +347,7 @@ static int sample_flags_to_name(u32 flags, char *str, size_t size)
>  
>  	flags &= ~(PERF_IP_FLAG_TRACE_BEGIN | PERF_IP_FLAG_TRACE_END);
>  
> -	types = flags & ~PERF_IP_FLAG_BRACH_EVENT_MASK;
> +	types = flags & ~PERF_IP_FLAG_BRANCH_EVENT_MASK;
>  	for (i = 0; sample_flags[i].name; i++) {
>  		if (sample_flags[i].flags != types)
>  			continue;
> @@ -359,7 +359,7 @@ static int sample_flags_to_name(u32 flags, char *str, size_t size)
>  		break;
>  	}
>  
> -	events = flags & PERF_IP_FLAG_BRACH_EVENT_MASK;
> +	events = flags & PERF_IP_FLAG_BRANCH_EVENT_MASK;
>  	for (i = 0; branch_events[i].name; i++) {
>  		if (!(branch_events[i].flags & events))
>  			continue;
> 
> base-commit: b10f74308e1305275e69ddde711ec817cc69e306
> -- 
> 2.34.1
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf script: Fix typo in branch event mask
  2025-03-12  7:56 [PATCH] perf script: Fix typo in branch event mask Yujie Liu
  2025-03-12  9:56 ` Leo Yan
@ 2025-03-12 10:02 ` James Clark
  2025-03-14 17:43 ` Namhyung Kim
  2 siblings, 0 replies; 4+ messages in thread
From: James Clark @ 2025-03-12 10:02 UTC (permalink / raw)
  To: Yujie Liu, linux-perf-users, linux-kernel, linux-arm-kernel
  Cc: Leo Yan, Arnaldo Carvalho de Melo, Namhyung Kim, Ian Rogers,
	Adrian Hunter, Jiri Olsa, Liang, Kan, Mark Rutland, Will Deacon,
	Mike Leach, Graham Woodward, Paschalis.Mpeis



On 12/03/2025 7:56 am, Yujie Liu wrote:
> BRACH -> BRANCH
> 
> Fixes: 88b1473135e4 ("perf script: Separate events from branch types")
> Signed-off-by: Yujie Liu <yujie.liu@intel.com>
> ---
>   tools/perf/util/event.h                 | 2 +-
>   tools/perf/util/trace-event-scripting.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tools/perf/util/event.h b/tools/perf/util/event.h
> index c7f4b4b841ca..664bf39567ce 100644
> --- a/tools/perf/util/event.h
> +++ b/tools/perf/util/event.h
> @@ -91,7 +91,7 @@ enum {
>   	PERF_IP_FLAG_VMENTRY		|\
>   	PERF_IP_FLAG_VMEXIT)
>   
> -#define PERF_IP_FLAG_BRACH_EVENT_MASK	\
> +#define PERF_IP_FLAG_BRANCH_EVENT_MASK	\
>   	(PERF_IP_FLAG_BRANCH_MISS |	\
>   	 PERF_IP_FLAG_NOT_TAKEN)
>   
> diff --git a/tools/perf/util/trace-event-scripting.c b/tools/perf/util/trace-event-scripting.c
> index 29cc467be14a..72abb28b7b5a 100644
> --- a/tools/perf/util/trace-event-scripting.c
> +++ b/tools/perf/util/trace-event-scripting.c
> @@ -347,7 +347,7 @@ static int sample_flags_to_name(u32 flags, char *str, size_t size)
>   
>   	flags &= ~(PERF_IP_FLAG_TRACE_BEGIN | PERF_IP_FLAG_TRACE_END);
>   
> -	types = flags & ~PERF_IP_FLAG_BRACH_EVENT_MASK;
> +	types = flags & ~PERF_IP_FLAG_BRANCH_EVENT_MASK;
>   	for (i = 0; sample_flags[i].name; i++) {
>   		if (sample_flags[i].flags != types)
>   			continue;
> @@ -359,7 +359,7 @@ static int sample_flags_to_name(u32 flags, char *str, size_t size)
>   		break;
>   	}
>   
> -	events = flags & PERF_IP_FLAG_BRACH_EVENT_MASK;
> +	events = flags & PERF_IP_FLAG_BRANCH_EVENT_MASK;
>   	for (i = 0; branch_events[i].name; i++) {
>   		if (!(branch_events[i].flags & events))
>   			continue;
> 
> base-commit: b10f74308e1305275e69ddde711ec817cc69e306

Reviewed-by: James Clark <james.clark@linaro.org>



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf script: Fix typo in branch event mask
  2025-03-12  7:56 [PATCH] perf script: Fix typo in branch event mask Yujie Liu
  2025-03-12  9:56 ` Leo Yan
  2025-03-12 10:02 ` James Clark
@ 2025-03-14 17:43 ` Namhyung Kim
  2 siblings, 0 replies; 4+ messages in thread
From: Namhyung Kim @ 2025-03-14 17:43 UTC (permalink / raw)
  To: linux-perf-users, linux-kernel, linux-arm-kernel, Yujie Liu
  Cc: Leo Yan, Arnaldo Carvalho de Melo, Ian Rogers, James Clark,
	Adrian Hunter, Jiri Olsa, Liang, Kan, Mark Rutland, Will Deacon,
	Mike Leach, Graham Woodward, Paschalis.Mpeis

On Wed, 12 Mar 2025 15:56:36 +0800, Yujie Liu wrote:
> BRACH -> BRANCH
> 
> 
Applied to perf-tools-next, thanks!

Best regards,
Namhyung




^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2025-03-14 18:07 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-03-12  7:56 [PATCH] perf script: Fix typo in branch event mask Yujie Liu
2025-03-12  9:56 ` Leo Yan
2025-03-12 10:02 ` James Clark
2025-03-14 17:43 ` Namhyung Kim

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).