From: Cristian Marussi <cristian.marussi@arm.com>
To: Viresh Kumar <viresh.kumar@linaro.org>,
Sudeep Holla <sudeep.holla@arm.com>
Cc: peng.fan@nxp.com, arnd@arndb.de, jassisinghbrar@gmail.com,
linux-kernel@vger.kernel.org, peter.hilber@opensynergy.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V4] firmware: arm_scmi: Make scmi core independent of the transport type
Date: Thu, 23 Jan 2020 11:37:55 +0000 [thread overview]
Message-ID: <6b614d90-6326-db81-12dc-a0b4a467400f@arm.com> (raw)
In-Reply-To: <20200123112711.mggm7ayxcqnr54yf@vireshk-i7>
On 23/01/2020 11:27, Viresh Kumar wrote:
> On 23-01-20, 10:30, Sudeep Holla wrote:
>> On Wed, Jan 22, 2020 at 12:15:38PM +0000, Sudeep Holla wrote:
>>> On Wed, Jan 22, 2020 at 08:06:23AM +0530, Viresh Kumar wrote:
>>>
>>
>> [...]
>>
>>>> Can you please help me getting this tested, now that I have rebased it
>>>> as well :) ?
>>>>
>>>
>>> Sure, I will give it a go on my Juno. Thanks for the rebase, makes it
>>> simpler.
>>>
>>
>> Sorry for the delay. I gave this a spin on my Juno. I am seeing below
>> warning once on boot but it continues and everything seem to work fine.
>> Also the warning is not related to this change I believe and this patch
>> is just helping to hit some corner case with deferred probe and devres.
>> I need to spend some time to debug it.
>>
>> Regards,
>> Sudeep
>>
>> --->8
>>
>> WARNING: CPU: 1 PID: 187 at drivers/base/dd.c:519 really_probe+0x11c/0x418
>> Modules linked in:
>> CPU: 1 PID: 187 Comm: kworker/1:2 Not tainted 5.5.0-rc7-00026-gf7231cd3108d-dirty #20
>> Hardware name: ARM LTD ARM Juno Development Platform/ARM Juno Development Platform, BIOS EDK II Jan 16 2020
>> Workqueue: events deferred_probe_work_func
>> pstate: 80000005 (Nzcv daif -PAN -UAO)
>> pc : really_probe+0x11c/0x418
>> lr : really_probe+0x10c/0x418
>> Call trace:
>> really_probe+0x11c/0x418
>> driver_probe_device+0xe4/0x138
>> __device_attach_driver+0x90/0x110
>> bus_for_each_drv+0x80/0xd0
>> __device_attach+0xdc/0x160
>> device_initial_probe+0x18/0x20
>> bus_probe_device+0x98/0xa0
>> deferred_probe_work_func+0x90/0xe0
>> process_one_work+0x1ec/0x4a8
>> worker_thread+0x210/0x490
>> kthread+0x110/0x118
>> ret_from_fork+0x10/0x18
>> ---[ end trace 06f96d55ce6093a8 ]---
>
> Still it looks strange that the warning comes only after my patch :)
In fact, got the same warning while testing your patch on JUNO at top of SCMI for-next.
But then everything worked fine as Sudeep said.
Thanks
Cristian
>
> Should I send V5 (fixed few comments after reviews) now ?
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-23 11:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-21 8:27 [PATCH V3] firmware: arm_scmi: Make scmi core independent of the transport type Viresh Kumar
2020-01-21 15:11 ` Arnd Bergmann
2020-01-21 18:38 ` Sudeep Holla
2020-01-22 2:36 ` [PATCH V4] " Viresh Kumar
2020-01-22 12:15 ` Sudeep Holla
2020-01-23 10:30 ` Sudeep Holla
2020-01-23 11:27 ` Viresh Kumar
2020-01-23 11:37 ` Cristian Marussi [this message]
2020-01-23 15:17 ` Sudeep Holla
2020-01-24 3:02 ` Viresh Kumar
2020-01-24 11:22 ` Sudeep Holla
2020-01-24 12:15 ` Peter Hilber
2020-01-24 18:28 ` Jassi Brar
2020-01-22 12:44 ` [PATCH V3] " Cristian Marussi
2020-01-23 2:39 ` Viresh Kumar
2020-01-23 11:06 ` Cristian Marussi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b614d90-6326-db81-12dc-a0b4a467400f@arm.com \
--to=cristian.marussi@arm.com \
--cc=arnd@arndb.de \
--cc=jassisinghbrar@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.fan@nxp.com \
--cc=peter.hilber@opensynergy.com \
--cc=sudeep.holla@arm.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).