From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1025CC77B7C for ; Thu, 4 May 2023 12:23:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zcFp/cf5xkZwKuLVTC4Px3m0W8fYAkdTtTZrpbgeuH4=; b=MF/BJ71QEFVxGK+U2IS0actbBh lH2hcSfSp93Pi20BypB4rle3sxbGXDvpFWYrffjSphihDQ94JlQwTqjhqsb7cRCoVD4RbcQxljthA WMRn3nIjeJq6xHL8/L2j4NQGGe6ZN2StN+s+DoiOqZHN6QSikKP9QMvCgJimi0Zq2yD98rjgwZpFa zVvUw290M+y3e+qjNwGVnVW3UWRK/7ugpUTT9jg0VIgAVtcAIiwIr/Pwe4StioYcJj42IwUo29b9w FktagFt5hyVgu72YFLYXnAQLSwdPg2cYtwXmGxpPNnba5f5vI5f6/gikQR28cTOLXjiW6VoZmtwf2 0RJRJK8Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1puXyb-007pLp-1V; Thu, 04 May 2023 12:22:25 +0000 Received: from fieber.vanmierlo.com ([84.243.197.177] helo=connect.vanmierlo.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1puXyY-007pK8-2m for linux-arm-kernel@lists.infradead.org; Thu, 04 May 2023 12:22:24 +0000 X-Footer: dmFubWllcmxvLmNvbQ== Received: from roundcube.vanmierlo.com ([192.168.37.37]) (authenticated user m.brock@vanmierlo.com) by connect.vanmierlo.com (Kerio Connect 9.4.2) with ESMTPA; Thu, 4 May 2023 14:22:13 +0200 MIME-Version: 1.0 Date: Thu, 04 May 2023 14:22:13 +0200 From: m.brock@vanmierlo.com To: Manikanta Guntupalli Cc: gregkh@linuxfoundation.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, linux-serial@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, michal.simek@amd.com, git@amd.com, radhey.shyam.pandey@amd.com, shubhrajyoti.datta@amd.com, srinivas.goud@amd.com, manion05gk@gmail.com Subject: Re: [PATCH 0/2] Add rs485 support to uartps driver In-Reply-To: <1682512187-8828-1-git-send-email-manikanta.guntupalli@amd.com> References: <1682512187-8828-1-git-send-email-manikanta.guntupalli@amd.com> Message-ID: <6b72c56e79a44fec348de26d14d9dce0@vanmierlo.com> X-Sender: m.brock@vanmierlo.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230504_052223_033708_2C64FC5E X-CRM114-Status: UNSURE ( 6.09 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Manikanta Guntupalli wrote 2023-04-26 14:29: > Add optional gpio property to uartps node to support rs485 > Add rs485 support to uartps driver > > Manikanta Guntupalli (2): > dt-bindings: Add optional gpio property to uartps node to support > rs485 > tty: serial: uartps: Add rs485 support to uartps driver > > .../devicetree/bindings/serial/cdns,uart.yaml | 5 + > drivers/tty/serial/xilinx_uartps.c | 96 ++++++++++++++++++- > 2 files changed, 100 insertions(+), 1 deletion(-) Why would you want to use a GPIO and not RTS for choosing the direction as is more common in this case? And have you thought about configuring the polarity? How long will the signal be active before the real transmission begins so the driver can settle? Maarten _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel