From: Yipeng Zou <zouyipeng@huawei.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: <linux@armlinux.org.uk>, <ndesaulniers@google.com>,
<morbo@google.com>, <justinstitt@google.com>,
<ssantosh@kernel.org>, <linux-arm-kernel@lists.infradead.org>,
<nathan@kernel.org>
Subject: Re: [PATCH v2] arm: fix clang build warning in include/asm/memory.h
Date: Sat, 13 Apr 2024 10:31:36 +0800 [thread overview]
Message-ID: <6b7825ec-8f5d-49ea-b4ae-a5b1e601b3cf@huawei.com> (raw)
In-Reply-To: <CACRpkdY00Md8=JPZr9TRtC_NFXNz97kN=HMDoKYL27TLQfgWQw@mail.gmail.com>
在 2024/3/28 16:16, Linus Walleij 写道:
> On Thu, Mar 21, 2024 at 2:36 AM Yipeng Zou<zouyipeng@huawei.com> wrote:
>
>> There is a build error has been founded with build in clang-15.0.4:
>>
>> ./arch/arm/include/asm/memory.h:358:12: error: result of comparison "phys addr_t’ (aka 'unsigned int’) > 4294967295 is always false [-Werror, -Wtautological-type-limit-compare]
>> if (addr > (u32)~0)
>> ~~~~ ^ ~~~~~~~
>>
>> It will be always goes fail without CONFIG_PHYS_ADDR_T_64BIT.
>>
>> Directly silence it by Use CONFIG_PHYS_ADDR_T_64BIT.
>>
>> Fixes: 981b6714dbd2 ("ARM: provide improved virt_to_idmap() functionality")
>> Signed-off-by: Yipeng Zou<zouyipeng@huawei.com>
>> ---
>> V2: IDMAP_INVALID_ADDR was used in other place, keep it defined.
>> arch/arm/include/asm/memory.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm/include/asm/memory.h b/arch/arm/include/asm/memory.h
>> index ef2aa79ece5a..07c7e759d04c 100644
>> --- a/arch/arm/include/asm/memory.h
>> +++ b/arch/arm/include/asm/memory.h
>> @@ -353,8 +353,10 @@ static inline unsigned long phys_to_idmap(phys_addr_t addr)
>> {
>> if (IS_ENABLED(CONFIG_MMU) && arch_phys_to_idmap_offset) {
>> addr += arch_phys_to_idmap_offset;
>> +#ifdef CONFIG_PHYS_ADDR_T_64BIT
>> if (addr > (u32)~0)
> What about my suggestion:
>
> #include <linux/limits.h>
>
> if (addr > U32_MAX)
>
> ?
>
> Yours,
> Linus Walleij
Hi:
I just miss it, sorry for that.
Yes indeed, is clearer by use U32_MAX here.
Add it in V3 thanks for review.
V3:
https://lore.kernel.org/all/20240413022843.1730174-1-zouyipeng@huawei.com/
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Regards,
Yipeng Zou
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2024-04-13 2:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 1:35 [PATCH v2] arm: fix clang build warning in include/asm/memory.h Yipeng Zou
2024-03-26 23:55 ` Nathan Chancellor
2024-03-28 8:16 ` Linus Walleij
2024-04-13 2:31 ` Yipeng Zou [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b7825ec-8f5d-49ea-b4ae-a5b1e601b3cf@huawei.com \
--to=zouyipeng@huawei.com \
--cc=justinstitt@google.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox