From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93333C25B78 for ; Wed, 22 May 2024 18:43:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s/tlUoDF9Ow4LxWgz3GunxzdMGbQgdyiRBL0WHOK0jw=; b=ukCIZJjxp/uGhP kpLW1qtdcxPJczXbGHVye9PSH/G1nwHU5wzSMNBhdhvDDX4zpwG1AKVs6Bcy4rsx1lX2rrIp6SEzH sWn2kpTbuGxQjkIpRgVk0M65l20om1DHHajklFnHFf8jKkwt3ap8PrSeQ9ppNeEVBWdQICj+KCYOL Oc5VpqKaP8FwKrZ1KQ213mKO5JohzBQ26Cc0j6xarAsaUnK1uLcmKMQ/enoQ2mLHOFTN7c42M2dVd Z9a0Raxrqh9xj7rweFyZScMiSF0cPn/5XJqqS5MnzLY5rmrxzMAwsqr6XHG46JnkyLuoJTT0cm/3D cIc50uAV8d8T3ci8vAMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9qwD-00000003q9g-11Ou; Wed, 22 May 2024 18:43:45 +0000 Received: from mail-ed1-x534.google.com ([2a00:1450:4864:20::534]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s9qw9-00000003q8z-44Vv for linux-arm-kernel@lists.infradead.org; Wed, 22 May 2024 18:43:43 +0000 Received: by mail-ed1-x534.google.com with SMTP id 4fb4d7f45d1cf-572a93890d1so11738712a12.3 for ; Wed, 22 May 2024 11:43:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716403419; x=1717008219; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=4X92RNyaocOQ9jeaX09e1iKmMV7MiGKGnZ+Dic7jjso=; b=lP49YMnBaGwPIjkK90crlaR0z32DQcL+6qCD9HxAhfAwGQHYbhUKIeJZuM1yQC7r/x WN7Upq/3X9DIIa3wAq0tsgI83a0USKR+GaO2rvd2E9uOHMn0NFXaTIfn/PNmlkLqM7np vQoLZ+4inc896yW0qdbFU/fl1CSAsBLMF5CY00Q4gB/hXrW6gLQikjs27GXV4VnEmh6j C4TQWbhDAyJKm719CESFy2E+y0p7ZFOhjdib235Z3Y+OGl/4LcjpHRl8QgqSNhOEMKqX kpr+sDjJbmZ9prKYBAh0PSo8R2g4qvHL62cmBCFEPzV86UQZ7yv1qZAr+/uHedTcMr6d cgiA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716403419; x=1717008219; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4X92RNyaocOQ9jeaX09e1iKmMV7MiGKGnZ+Dic7jjso=; b=QdEvSzeL9zt4Vmmt9IaEfbZpRC6H8GR+w3C6gB0dVcBVE2Bgx3KPClmz+TAcdlrlmz TQwbHYY40UtTza/veupo6kJZbu2qAoA8dnnjaxJjC7ffz55gkvyEGyp8GP81N10m3zD/ XyaWhon+s9gwjf297nG1x2UshfBg4GI1IYgk4HdsPysxozffLw4PIMPsAgrLwB793zRk OTZ/SAjNCRQT2NLaag6rSX9g3tnQ1cdLpTASwbmejH+gnW6hbnctZHaKaPr9do1K84NU slZw2bx0Bm/0r7XALXHOHGMVyLRHEEZD49a3b1XI34RMm+PyO4sKsaxPhg48ayK+Tw0V Islg== X-Forwarded-Encrypted: i=1; AJvYcCVNIQB1DNqmkjlW+uggEASCBssFt+jgW+3yfDZS9vo7FQaVOWM+gaxof6r4VeZM8inne3ZTgKA1dbI5CnTR/ZzUm1rLDeU1380NeN/mUun96lzyYSU= X-Gm-Message-State: AOJu0YzUrqbqOuSfFCPJWcVzD4B/3X3lgX38XVy6gQySVGMoh7QV+Kj5 xVOicc2YzLBW+26KL7ymEdhVWQZDi4lWECja3EXQroilQkPiStJN X-Google-Smtp-Source: AGHT+IGN0pFDJpoxG2Grv/YFh/MhqqsO4GibeJdmlSjDyMjLmGY31Vxcn3drvjikcwZeQyVyTrLosA== X-Received: by 2002:a50:ab0d:0:b0:572:664c:83f2 with SMTP id 4fb4d7f45d1cf-57832bee6c5mr2410990a12.27.1716403419377; Wed, 22 May 2024 11:43:39 -0700 (PDT) Received: from ?IPV6:2a02:2f00:503:7c00:503d:ca7a:1fd6:cd63? ([2a02:2f00:503:7c00:503d:ca7a:1fd6:cd63]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-57421480d99sm16875505a12.8.2024.05.22.11.43.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 22 May 2024 11:43:38 -0700 (PDT) Message-ID: <6b9b959e-9a03-420c-9f61-adaae05bc5eb@gmail.com> Date: Wed, 22 May 2024 21:43:37 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/4] dt-bindings: reset: add schema for imx8ulp SIM reset Content-Language: en-US To: Rob Herring Cc: Krzysztof Kozlowski , Conor Dooley , Lee Jones , Shawn Guo , Philipp Zabel , Liu Ying , Sascha Hauer , laurentiu.mihalcea@nxp.com, devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240516204031.171920-1-laurentiumihalcea111@gmail.com> <20240516204031.171920-2-laurentiumihalcea111@gmail.com> <20240517195943.GA2854624-robh@kernel.org> From: Laurentiu Mihalcea In-Reply-To: <20240517195943.GA2854624-robh@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240522_114342_077802_4A9F6481 X-CRM114-Status: GOOD ( 17.98 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/17/2024 10:59 PM, Rob Herring wrote: > On Thu, May 16, 2024 at 11:40:28PM +0300, Laurentiu Mihalcea wrote: >> From: Laurentiu Mihalcea >> >> Add schema for imx8ulp's SIM reset controller. >> >> Signed-off-by: Liu Ying >> Signed-off-by: Laurentiu Mihalcea >> --- >> .../bindings/reset/nxp,imx8ulp-sim-reset.yaml | 43 +++++++++++++++++++ >> 1 file changed, 43 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml >> >> diff --git a/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml >> new file mode 100644 >> index 000000000000..ec9a5c73e83c >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/reset/nxp,imx8ulp-sim-reset.yaml >> @@ -0,0 +1,43 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/reset/nxp,imx8ulp-sim-reset.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP i.MX8ULP System Integration Module Reset Controller >> + >> +maintainers: >> + - Liu Ying >> + >> +description: | >> + Some instances of i.MX8ULP's SIM may offer control over the >> + reset of some components of a certain domain (e.g: AVD-SIM). >> + As far as the DT is concerned, this means that the reset >> + controller needs to be a child of the SIM node. >> + >> +properties: >> + compatible: >> + const: nxp,imx8ulp-avd-sim-reset >> + >> + '#reset-cells': >> + const: 1 >> + >> +required: >> + - compatible >> + - '#reset-cells' >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + #include >> + syscon@2da50000 { >> + compatible = "nxp,imx8ulp-avd-sim", "syscon"; >> + reg = <0x2da50000 0x38>; >> + clocks = <&pcc5 IMX8ULP_CLK_AVD_SIM>; >> + >> + reset-controller { >> + compatible = "nxp,imx8ulp-avd-sim-reset"; >> + #reset-cells = <1>; >> + }; >> + }; > Why do you need a child node here? No DT resources or anything for this > 'sub-block'. Just put "#reset-cells" in the parent node. You're right, we don't need the child here. In fact, the reset controller will never get probed anyways since "simple-mfd" was removed from the compatible list of the parent. Will remove it and turn the parent into a syscon + reset controller in V2. > > (Note that examples for MFDs like this go in the MFD binding rather than > having incomplete examples here.) > > Rob Noted, thank you! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel