From: Andrew Kilroy <andrew.kilroy@arm.com>
To: John Garry <john.garry@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-perf-users@vger.kernel.org"
<linux-perf-users@vger.kernel.org>,
"acme@kernel.org" <acme@kernel.org>,
Andi Kleen <ak@linux.intel.com>
Cc: Will Deacon <will@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Leo Yan <leo.yan@linaro.org>, Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@redhat.com>, Namhyung Kim <namhyung@kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [RFC PATCH 1/1] perf arm64: Implement --topdown with metrics
Date: Wed, 5 Jan 2022 16:58:42 +0000 [thread overview]
Message-ID: <6ba550d1-61bc-e229-2a64-331cfa59c388@arm.com> (raw)
In-Reply-To: <48437bee-9c39-38ba-e990-ba9a6a5378b4@huawei.com>
On 17/12/2021 10:19, John Garry wrote:
>
> And there is no colouring for results which are above/below standard
> thresholds (see stat-shadow.c:get_radio_color()).
>
> My impression is that we're not plugging the results from
> metricgroup__parse_groups_to_evlist() into the --topdown print
> functionality properly.
>
The --topdown kernel event colouring is dictated by a large if-else
statement in stat-shadow.c:perf_stat__print_shadow_stats.
There are branches depending on what is returned by
perf_stat_evsel__is() for example
} else if (perf_stat_evsel__is(evsel, TOPDOWN_FETCH_BUBBLES)) {
double fe_bound = td_fe_bound(cpu, st, &rsd);
if (fe_bound > 0.2)
color = PERF_COLOR_RED;
print_metric(config, ctxp, color, "%8.1f%%", "frontend bound",
fe_bound * 100.);
} else if (perf_stat_evsel__is(evsel, TOPDOWN_SLOTS_RETIRED)) {
Because the patches are enabling metrics (equivalent of the -M
'somemetricname' option), the perf_stat__print_shadow_stats function
always makes calls to generic_metric(), where colours are never picked.
Seeing thresholds like:
retiring > 0.7
fe_bound > 0.2
be_bound > 0.2
bad_spec > 0.1
I'm not sure about adding the colouring really. Are these thresholds
x86 specific?
> Thanks,
> John
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-05 17:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 12:37 [PATCH v2 0/2] perf vendor events: Arm Neoverse N2 Andrew Kilroy
2021-12-10 12:37 ` [PATCH v2 1/2] perf vendor events: For the " Andrew Kilroy
2021-12-10 13:21 ` John Garry
2021-12-14 18:42 ` [RFC PATCH 0/1] topdown with metrics Andrew Kilroy
2021-12-14 18:42 ` [RFC PATCH 1/1] perf arm64: Implement --topdown " Andrew Kilroy
2021-12-14 20:32 ` Ian Rogers
2021-12-15 10:38 ` James Clark
2021-12-15 10:52 ` John Garry
2021-12-15 12:38 ` Andrew Kilroy
2021-12-15 12:53 ` John Garry
2022-01-06 16:33 ` Andrew Kilroy
2022-01-06 18:24 ` John Garry
2021-12-20 17:21 ` Andrew Kilroy
2021-12-21 14:03 ` Andi Kleen
2022-01-27 11:11 ` Andrew Kilroy
2021-12-17 10:19 ` John Garry
2021-12-21 14:31 ` Andrew Kilroy
2022-01-05 16:58 ` Andrew Kilroy [this message]
2022-01-28 18:00 ` John Garry
2021-12-10 12:37 ` [PATCH v2 2/2] perf vendor events: Rename arm64 arch std event files Andrew Kilroy
2021-12-10 13:46 ` John Garry
2021-12-10 19:01 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ba550d1-61bc-e229-2a64-331cfa59c388@arm.com \
--to=andrew.kilroy@arm.com \
--cc=acme@kernel.org \
--cc=ak@linux.intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=john.garry@huawei.com \
--cc=jolsa@redhat.com \
--cc=leo.yan@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.poirier@linaro.org \
--cc=namhyung@kernel.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).