From: Andrew Davis <afd@ti.com>
To: Rob Herring <robh@kernel.org>
Cc: Nishanth Menon <nm@ti.com>, Tero Kristo <kristo@kernel.org>,
Santosh Shilimkar <ssantosh@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Sebastian Reichel <sre@kernel.org>,
Vignesh Raghavendra <vigneshr@ti.com>,
<linux-arm-kernel@lists.infradead.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-pm@vger.kernel.org>
Subject: Re: [PATCH 02/12] dt-bindings: arm: keystone: ti-sci: Add reboot-controller child node
Date: Thu, 1 Feb 2024 17:50:00 -0600 [thread overview]
Message-ID: <6ba87a3f-e2f4-4caf-8d23-aa78caaba45a@ti.com> (raw)
In-Reply-To: <20240201230351.GA1900918-robh@kernel.org>
On 2/1/24 5:03 PM, Rob Herring wrote:
> On Wed, Jan 31, 2024 at 04:19:47PM -0600, Andrew Davis wrote:
>> The TI-SCI firmware supports rebooting the system in addition to the
>> functions already listed here, document child node for the same.
>>
>> Signed-off-by: Andrew Davis <afd@ti.com>
>> ---
>> .../devicetree/bindings/arm/keystone/ti,sci.yaml | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> index c24ad0968f3ef..e392175b33c74 100644
>> --- a/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> +++ b/Documentation/devicetree/bindings/arm/keystone/ti,sci.yaml
>> @@ -83,6 +83,10 @@ properties:
>> type: object
>> $ref: /schemas/reset/ti,sci-reset.yaml#
>>
>> + reboot-controller:
>> + type: object
>> + $ref: /schemas/power/reset/ti,sci-reboot.yaml#
>
> Don't need a ref just for a single property.
>
> But then why do we need a node here at all? Can't you assume reboot
> support for TI-SCI firmware (i.e. based on the parent node). Then you
> don't need a DT update to add the feature.
>
We could yes, but then again we could do the same for all the
child nodes of this system-controller parent node. Might even
have been better that way, for now I'm trying to be consistent
with what is already here (child node per service provided,
even though the services are always the same).
Andrew
> Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-02-01 23:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 22:19 [PATCH 00/12] Add TI-SCI reboot driver Andrew Davis
2024-01-31 22:19 ` [PATCH 01/12] dt-bindings: power: reset: Document ti,sci-reboot compatible Andrew Davis
2024-02-01 18:53 ` Conor Dooley
2024-01-31 22:19 ` [PATCH 02/12] dt-bindings: arm: keystone: ti-sci: Add reboot-controller child node Andrew Davis
2024-02-01 18:42 ` Conor Dooley
2024-02-01 23:03 ` Rob Herring
2024-02-01 23:50 ` Andrew Davis [this message]
2024-01-31 22:19 ` [PATCH 03/12] power: reset: Add TI-SCI reboot driver Andrew Davis
2024-02-01 21:15 ` Nishanth Menon
2024-02-02 17:04 ` Sebastian Reichel
2024-01-31 22:19 ` [PATCH 04/12] arm64: dts: ti: k3-am64: Add reboot-controller node Andrew Davis
2024-01-31 22:19 ` [PATCH 05/12] arm64: dts: ti: k3-am62: " Andrew Davis
2024-01-31 22:19 ` [PATCH 06/12] arm64: dts: ti: k3-am62a: " Andrew Davis
2024-01-31 22:19 ` [PATCH 07/12] arm64: dts: ti: k3-am62p: " Andrew Davis
2024-01-31 22:19 ` [PATCH 08/12] arm64: dts: ti: k3-am65: " Andrew Davis
2024-01-31 22:19 ` [PATCH 09/12] arm64: dts: ti: k3-j7200: " Andrew Davis
2024-01-31 22:19 ` [PATCH 10/12] arm64: dts: ti: k3-j721e: " Andrew Davis
2024-01-31 22:19 ` [PATCH 11/12] arm64: dts: ti: k3-j721s2: " Andrew Davis
2024-01-31 22:19 ` [PATCH 12/12] arm64: dts: ti: k3-j784s4: " Andrew Davis
2024-02-01 21:14 ` [PATCH 00/12] Add TI-SCI reboot driver Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ba87a3f-e2f4-4caf-8d23-aa78caaba45a@ti.com \
--to=afd@ti.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kristo@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=sre@kernel.org \
--cc=ssantosh@kernel.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).