From: Krzysztof Kozlowski <krzk@kernel.org>
To: Pengfei Li <pengfei.li_1@nxp.com>, Rob Herring <robh@kernel.org>
Cc: krzk+dt@kernel.org, conor+dt@kernel.org, abelvesa@kernel.org,
mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org,
s.hauer@pengutronix.de, kernel@pengutronix.de,
festevam@gmail.com, ping.bai@nxp.com, ye.li@nxp.com,
peng.fan@nxp.com, aisheng.dong@nxp.com, frank.li@nxp.com,
tharvey@gateworks.com, alexander.stein@ew.tq-group.com,
gregor.herburger@ew.tq-group.com, hiago.franco@toradex.com,
joao.goncalves@toradex.com, hvilleneuve@dimonoff.com,
Markus.Niebel@ew.tq-group.com, m.felsch@pengutronix.de,
m.othacehe@gmail.com, bhelgaas@google.com, leoyang.li@nxp.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-clk@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2 2/5] dt-bindings: clock: Add i.MX91 clock definition
Date: Wed, 5 Jun 2024 10:24:38 +0200 [thread overview]
Message-ID: <6bbcf768-ecaf-4120-9a98-85528a142008@kernel.org> (raw)
In-Reply-To: <ZmEBn2E1FPKiXnMc@pengfei-OptiPlex-Tower-Plus-7010>
On 06/06/2024 02:23, Pengfei Li wrote:
> On Tue, Jun 04, 2024 at 10:04:47AM -0500, Rob Herring wrote:
>> On Wed, May 29, 2024 at 07:26:31PM -0700, Pengfei Li wrote:
>>> i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93.
>>> Add i.MX91 related clock definition.
>>>
>>> Signed-off-by: Pengfei Li <pengfei.li_1@nxp.com>
>>> Reviewed-by: Frank Li <Frank.Li@nxp.com>
>>> ---
>>> include/dt-bindings/clock/imx93-clock.h | 7 ++++++-
>>> 1 file changed, 6 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h
>>> index 787c9e74dc96..ca0785f35a46 100644
>>> --- a/include/dt-bindings/clock/imx93-clock.h
>>> +++ b/include/dt-bindings/clock/imx93-clock.h
>>> @@ -204,6 +204,11 @@
>>> #define IMX93_CLK_A55_SEL 199
>>> #define IMX93_CLK_A55_CORE 200
>>> #define IMX93_CLK_PDM_IPG 201
>>> -#define IMX93_CLK_END 202
>>> +#define IMX91_CLK_ENET1_QOS_TSN 202
>>> +#define IMX91_CLK_ENET_TIMER 203
>>> +#define IMX91_CLK_ENET2_REGULAR 204
>>> +#define IMX91_CLK_ENET2_REGULAR_GATE 205
>>> +#define IMX91_CLK_ENET1_QOS_TSN_GATE 206
>>> +#define IMX93_CLK_END 207
>>
>> Drop the END define. If it can change, it's not part of the ABI.
>>
>> Rob
>>
>
> Hi Rob Herring,
>
> The 'IMX93_CLK_END' macro definition is indeed not a certain clock, but it is
> used in the imx93 ccm driver to indicate the number of clocks. And this macro
> already existed before this patch, so it may not be able to be deleted.
May be. Trust me. Fix your driver first.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-06-05 8:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-30 2:26 [PATCH v2 0/5] arm64: dts: freescale: Add i.MX91 11x11 EVK basic support Pengfei Li
2024-05-30 2:26 ` [PATCH v2 1/5] dt-bindings: clock: Add i.MX91 clock support Pengfei Li
2024-06-04 15:03 ` Rob Herring
2024-06-05 23:59 ` Pengfei Li
2024-06-05 8:12 ` Krzysztof Kozlowski
2024-05-30 2:26 ` [PATCH v2 2/5] dt-bindings: clock: Add i.MX91 clock definition Pengfei Li
2024-06-04 15:04 ` Rob Herring
2024-06-06 0:23 ` Pengfei Li
2024-06-05 8:24 ` Krzysztof Kozlowski [this message]
2024-05-30 2:26 ` [PATCH v2 3/5] arm64: dts: freescale: Add i.MX91 dtsi support Pengfei Li
2024-05-30 2:26 ` [PATCH v2 4/5] dt-bindings: arm: fsl: Add i.MX91 11x11 evk board Pengfei Li
2024-06-04 15:09 ` Rob Herring (Arm)
2024-05-30 2:26 ` [PATCH v2 5/5] arm64: dts: freescale: Add i.MX91 11x11 EVK basic support Pengfei Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bbcf768-ecaf-4120-9a98-85528a142008@kernel.org \
--to=krzk@kernel.org \
--cc=Markus.Niebel@ew.tq-group.com \
--cc=abelvesa@kernel.org \
--cc=aisheng.dong@nxp.com \
--cc=alexander.stein@ew.tq-group.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=frank.li@nxp.com \
--cc=gregor.herburger@ew.tq-group.com \
--cc=hiago.franco@toradex.com \
--cc=hvilleneuve@dimonoff.com \
--cc=imx@lists.linux.dev \
--cc=joao.goncalves@toradex.com \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=m.othacehe@gmail.com \
--cc=mturquette@baylibre.com \
--cc=peng.fan@nxp.com \
--cc=pengfei.li_1@nxp.com \
--cc=ping.bai@nxp.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sboyd@kernel.org \
--cc=shawnguo@kernel.org \
--cc=tharvey@gateworks.com \
--cc=ye.li@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).