From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9F135C25B76 for ; Wed, 5 Jun 2024 08:25:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZR/h/UxmpTXdQKjjUiKBQw2Bk767a21BDUVLIYmK+nc=; b=H8/hzvEXRRjc5e AKL51s3UemPMqZ8ofp0VV0TEoYCpc2Il3ULT8aVwMmuuNhs+uZIQ4toEPJt+Goabi/sF/7uLZRzjp 45xv+Yen9LqIlM+iWfUFi6KPbc5ojkVzTAXxlC0XljyM/luVSD/v7CrJAiNhOYYiOIpoA7Lxbj1EE WiTB21X5q8+uB7ma2Pzg/Ettj60Es2GSrDtWvPux+8KlMAmMBQxxRnLiDwo5o5FoI90sd+M2HtagV r3FA6J1u4C3x4lvHdQJ/Gi2A/zCUXM2U7z4LzecwVF1SfkzwSoD8Cu370bGNoz4KIwCcFutmYOFnh mfzvOWZz4mNfI3+dbMmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sElwy-00000005By4-1jtr; Wed, 05 Jun 2024 08:24:52 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sElwv-00000005BxB-10Md for linux-arm-kernel@lists.infradead.org; Wed, 05 Jun 2024 08:24:50 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 56916616F0; Wed, 5 Jun 2024 08:24:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9082AC32781; Wed, 5 Jun 2024 08:24:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1717575888; bh=nvygrpCQm6tIoTRBf/JypeEyOilo9fzXmix4PvWBWvU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=sHcFCifNacAkgFK4H9YarCqWvVnI81N2jpCElBnUa8fCtorGwezkBUu8ZoEQl94Rl qIHDx011cPu+PsKh3AD7RBr/Mh9AR8rKV7qEOEFmlreWg7AVjgq1Gynue2megD3uCF AjtCdkRZF05gv5DWqSfGpHUoL0ys/LYzn8Uk1v26thnKXExOEIU8ht7hX4EZ3AIyxK 4BSr7XfMXBhcmZ4GVFuWs9fquRzk1CwsdXQxxymA0mrs9+XZDHwBdipg51nS1f9KfJ ogM1Ov5CTljgWaAt20Uxf09LPfjLVMyJXlkp+GMwHBEm39PnSVulrtHx1KNXug8vDe 4xoKdbhAQ/kHg== Message-ID: <6bbcf768-ecaf-4120-9a98-85528a142008@kernel.org> Date: Wed, 5 Jun 2024 10:24:38 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/5] dt-bindings: clock: Add i.MX91 clock definition To: Pengfei Li , Rob Herring Cc: krzk+dt@kernel.org, conor+dt@kernel.org, abelvesa@kernel.org, mturquette@baylibre.com, sboyd@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, ping.bai@nxp.com, ye.li@nxp.com, peng.fan@nxp.com, aisheng.dong@nxp.com, frank.li@nxp.com, tharvey@gateworks.com, alexander.stein@ew.tq-group.com, gregor.herburger@ew.tq-group.com, hiago.franco@toradex.com, joao.goncalves@toradex.com, hvilleneuve@dimonoff.com, Markus.Niebel@ew.tq-group.com, m.felsch@pengutronix.de, m.othacehe@gmail.com, bhelgaas@google.com, leoyang.li@nxp.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org References: <20240530022634.2062084-1-pengfei.li_1@nxp.com> <20240530022634.2062084-3-pengfei.li_1@nxp.com> <20240604150447.GA604729-robh@kernel.org> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240605_012449_424540_01C7E2B1 X-CRM114-Status: GOOD ( 15.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/06/2024 02:23, Pengfei Li wrote: > On Tue, Jun 04, 2024 at 10:04:47AM -0500, Rob Herring wrote: >> On Wed, May 29, 2024 at 07:26:31PM -0700, Pengfei Li wrote: >>> i.MX91 is similar with i.MX93, only add few new clock compared to i.MX93. >>> Add i.MX91 related clock definition. >>> >>> Signed-off-by: Pengfei Li >>> Reviewed-by: Frank Li >>> --- >>> include/dt-bindings/clock/imx93-clock.h | 7 ++++++- >>> 1 file changed, 6 insertions(+), 1 deletion(-) >>> >>> diff --git a/include/dt-bindings/clock/imx93-clock.h b/include/dt-bindings/clock/imx93-clock.h >>> index 787c9e74dc96..ca0785f35a46 100644 >>> --- a/include/dt-bindings/clock/imx93-clock.h >>> +++ b/include/dt-bindings/clock/imx93-clock.h >>> @@ -204,6 +204,11 @@ >>> #define IMX93_CLK_A55_SEL 199 >>> #define IMX93_CLK_A55_CORE 200 >>> #define IMX93_CLK_PDM_IPG 201 >>> -#define IMX93_CLK_END 202 >>> +#define IMX91_CLK_ENET1_QOS_TSN 202 >>> +#define IMX91_CLK_ENET_TIMER 203 >>> +#define IMX91_CLK_ENET2_REGULAR 204 >>> +#define IMX91_CLK_ENET2_REGULAR_GATE 205 >>> +#define IMX91_CLK_ENET1_QOS_TSN_GATE 206 >>> +#define IMX93_CLK_END 207 >> >> Drop the END define. If it can change, it's not part of the ABI. >> >> Rob >> > > Hi Rob Herring, > > The 'IMX93_CLK_END' macro definition is indeed not a certain clock, but it is > used in the imx93 ccm driver to indicate the number of clocks. And this macro > already existed before this patch, so it may not be able to be deleted. May be. Trust me. Fix your driver first. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel