From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5B5E8E9B260 for ; Tue, 24 Feb 2026 12:44:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Type:MIME-Version: Message-ID:Date:References:In-Reply-To:Subject:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=IXazMPEj7jgw5BSwheNm4F1VytAdXnaYKht9RUhUEyI=; b=WwgfmfJTxFNTyNk9IGQfpA1UZo HCZKqxRNLxVfFjHuaEasjk82tZYmruSIdDFuI/f9/aiOGCqzWHqCd/YPKDObycMcXCjV4qUUVdF7O ySVtqoNkz0JYsabt2P3XBMLIjviMrP/3KeZM7uuAqFSHULiMOEFxlbM5P35SmyCV9kl69Q9MsHvaI l9m6duoZxOQLIulbP8sxMZQYX+OC2TBdEx+kgpvrh5CoFsTlYq1E46UXb7AFTnVphHjSRaUk6q+SQ ReD9oy6+kSZ1VyekMazKdO/k+sRSj7vI6pFPb0UamL7EADPr2/2DlqH5uW4lN/QYgAXwxvUnIDikE R3f7trcA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vurlc-000000024Tg-0w7r; Tue, 24 Feb 2026 12:43:56 +0000 Received: from mgamail.intel.com ([198.175.65.19]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vurlY-000000024Sv-403o; Tue, 24 Feb 2026 12:43:54 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1771937033; x=1803473033; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=GYIQtbOzePAjqzLuQH8+HHBY0PZDV/oocDXPjvOLjg4=; b=fGOeKWF5Z+g/+/7sgZqqnCQbBQbGP7P8VCkQ7I87SiEuxXE/GQTlkeHs ipYjv3ROg8cxcJMsRlXa3WkBVMsRKgp5mtF56BRoavNOlV1KxbcxsO2em qRfKhZAxf+DZIVAUiS/OsU/VAr93dUcHIN+5rodw0sxXNTInrFx3sByeG J6Tywqg6csZjEiXJ1IK6Z9kM6XD1nDFnbA1ZXLU8Bj7AH71yKm2tTudVg 4H5DraBqsd3QrNHiGoSvESpTxzg1UsWccVxR9YFc/PlITpq4xjQK7nayb k6Bklz71CfwyoxF1n4nqMwux1tssq1brW5kzDnCtEFounlQ8JETIHu7xi Q==; X-CSE-ConnectionGUID: dcXaUybGQVO3g7rjuqezWg== X-CSE-MsgGUID: o1XOFzvQTlOLM34/+QtuFw== X-IronPort-AV: E=McAfee;i="6800,10657,11710"; a="72853997" X-IronPort-AV: E=Sophos;i="6.21,308,1763452800"; d="scan'208";a="72853997" Received: from fmviesa010.fm.intel.com ([10.60.135.150]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2026 04:43:52 -0800 X-CSE-ConnectionGUID: yhhIkH3dTBCEo6bY5mI5tw== X-CSE-MsgGUID: 52bV+SrBTRymLIB6WF2upQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.21,308,1763452800"; d="scan'208";a="214131396" Received: from ettammin-mobl2.ger.corp.intel.com (HELO localhost) ([10.245.246.20]) by fmviesa010-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2026 04:43:40 -0800 From: Jani Nikula To: Maxime Ripard , Nicolas Frattaroli , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Harry Wentland , Leo Li , Rodrigo Siqueira , Alex Deucher , Christian =?utf-8?Q?K=C3=B6nig?= , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Andy Yan , Liviu Dudau , Chun-Kuang Hu , Philipp Zabel , Matthias Brugger , AngeloGioacchino Del Regno , Sandy Huang , Heiko =?utf-8?Q?St=C3=BCbner?= , Liu Ying , Chen-Yu Tsai , Samuel Holland , Dave Stevenson , =?utf-8?Q?Ma=C3=ADra?= Canal , Raspberry Pi Kernel Maintenance Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH 14/14] drm/display: hdmi: Use drm_output_color_format instead of hdmi_colorspace In-Reply-To: <20260224-drm-rework-color-formats-v1-14-bebc76604ada@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - c/o Alberga Business Park, 6 krs Bertel Jungin Aukio 5, 02600 Espoo, Finland References: <20260224-drm-rework-color-formats-v1-0-bebc76604ada@kernel.org> <20260224-drm-rework-color-formats-v1-14-bebc76604ada@kernel.org> Date: Tue, 24 Feb 2026 14:43:37 +0200 Message-ID: <6bcc885f3d4c2327a9b1ca4b4521c4e59c68a414@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260224_044353_044981_BBFA82F6 X-CRM114-Status: UNSURE ( 9.64 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 24 Feb 2026, Maxime Ripard wrote: > diff --git a/include/drm/display/drm_hdmi_helper.h b/include/drm/display/drm_hdmi_helper.h > index 09145c9ee9fc0cd839242f2373b305940e06e157..414e134ca23bcdcdd6ef491812ed0a9020b204ba 100644 > --- a/include/drm/display/drm_hdmi_helper.h > +++ b/include/drm/display/drm_hdmi_helper.h > @@ -2,10 +2,11 @@ > > #ifndef DRM_HDMI_HELPER > #define DRM_HDMI_HELPER > > #include > +#include You could avoid the include by forward declaring the enum, which is not strictly standard C but allowed by both GCC and Clang, and quite useful in reducing header dependencies. BR, Jani. > > struct drm_connector; > struct drm_connector_state; > struct drm_display_mode; > > @@ -24,11 +25,11 @@ drm_hdmi_infoframe_set_hdr_metadata(struct hdmi_drm_infoframe *frame, > void drm_hdmi_avi_infoframe_content_type(struct hdmi_avi_infoframe *frame, > const struct drm_connector_state *conn_state); > > unsigned long long > drm_hdmi_compute_mode_clock(const struct drm_display_mode *mode, > - unsigned int bpc, enum hdmi_colorspace fmt); > + unsigned int bpc, enum drm_output_color_format fmt); > > void > drm_hdmi_acr_get_n_cts(unsigned long long tmds_char_rate, > unsigned int sample_rate, > unsigned int *out_n, -- Jani Nikula, Intel