From: zajec5@gmail.com (Rafał Miłecki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 3/4] phy: Add USB3 PHY support for Broadcom NSP SoC
Date: Thu, 2 Feb 2017 07:48:35 +0100 [thread overview]
Message-ID: <6be62ef6-e90c-b5f8-adcd-0ea62ab73ced@gmail.com> (raw)
In-Reply-To: <1484669670-4201-4-git-send-email-yendapally.reddy@broadcom.com>
[Resending with fixed/complete Cc-s]
On Tue, 17 Jan 2017 11:14:29 -0500, Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com> wrote:> This patch adds support for Broadcom NSP USB3 PHY
>
> Signed-off-by: Yendapally Reddy Dhananjaya Reddy <yendapally.reddy@broadcom.com>
Seriously?! I really dislike what you did there.
NACK.
You are aware this block is common for both: Northstar and Northstar Plus and
we already have phy-bcm-ns-usb3.c! In fact Jon told me to rewrite my initial
driver to make is possible to reuse it on NSP and I did that!
This is old comment from Jon:
In 30 March 2016 at 23:31, Jon Mason <jon.mason@broadcom.com> wrote:
> On Mon, Mar 28, 2016 at 9:46 PM, Florian Fainelli <f.fainelli@gmail.com>
> wrote:
>>
>> CC: bcm-kernel-feedback-list, Jon
>
>
> This is a common IP block with NSP. I believe with some minor changes it
> can support both. Please allow me 1-2 days to look at these in more detail
> and see if I can get these patches working on NSP.
Please start using existing code instead of inventing everything from the
scratch internally at Broadcom. You did the same thing with (Q)SPI driver.
This driver duplicates phy-bcm-ns-usb3.c and should have not been accepted. I
strongly suggest *reverting* it and adjusting existing driver if needed.
next prev parent reply other threads:[~2017-02-02 6:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 16:14 [PATCH v2 0/4] USB support for Broadcom NSP SoC Yendapally Reddy Dhananjaya Reddy
2017-01-17 16:14 ` [PATCH v2 1/4] dt-bindings: phy: Add documentation for NSP USB3 PHY Yendapally Reddy Dhananjaya Reddy
2017-01-19 19:26 ` Rob Herring
2017-01-17 16:14 ` [PATCH v2 2/4] net: phy: Initialize mdio clock at probe function Yendapally Reddy Dhananjaya Reddy
2017-01-19 19:26 ` Florian Fainelli
2017-02-01 22:08 ` Florian Fainelli
2017-01-17 16:14 ` [PATCH v2 3/4] phy: Add USB3 PHY support for Broadcom NSP SoC Yendapally Reddy Dhananjaya Reddy
2017-02-02 6:48 ` Rafał Miłecki [this message]
2017-02-03 16:05 ` Jon Mason
2017-01-17 16:14 ` [PATCH v2 4/4] arm: dts: nsp: Add USB nodes to device tree Yendapally Reddy Dhananjaya Reddy
2017-01-26 15:34 ` [PATCH v2 0/4] USB support for Broadcom NSP SoC Kishon Vijay Abraham I
2017-01-26 17:27 ` Florian Fainelli
2017-01-27 7:39 ` Kishon Vijay Abraham I
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6be62ef6-e90c-b5f8-adcd-0ea62ab73ced@gmail.com \
--to=zajec5@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).