From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 576C5C433DB for ; Fri, 26 Mar 2021 04:12:54 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CD51E61A38 for ; Fri, 26 Mar 2021 04:12:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CD51E61A38 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=wlOrTY6GyWAzIjPRPe+etkRAEMes4jLyZMDaYFPA4kg=; b=TQiGPRhbbjQFrKHHdqr11DjkD Ma/4Pdb7p/utTwwh8xeOx2DySx1QXAj3ZXMTN+4XZRSJkRtbQBj9qYS+F8C9TaRmVqeHcOjcu80IC jyJ0RhObgeHcwjZBoNG3o1KBntGAtTjjAi0wknCfPoG9zPp6Bbu6LItx/5ee8f4NrIKioU/YdPPMm muLTg4XVNC70ed8DAx23C07HrYnnL3PKr6VA284O/fiuKPWhgau6fgIwEDDTvAtUjLtX1EH/P9V/n YjkMf59zlIF8ZZ/cRCsmUOz6FTj+irZ/MShhoShCCiCofAQt4apyoIHnEswoUxzT670rM/39Q0ZLU eqI2GGFSQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lPdnj-002jvj-5Y; Fri, 26 Mar 2021 04:10:23 +0000 Received: from mail-pl1-x636.google.com ([2607:f8b0:4864:20::636]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lPdnP-002jv1-Kx for linux-arm-kernel@lists.infradead.org; Fri, 26 Mar 2021 04:10:15 +0000 Received: by mail-pl1-x636.google.com with SMTP id v8so282514plz.10 for ; Thu, 25 Mar 2021 21:10:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=RYXNKKSLKbuWAE9mYRQ16nqU5xlOECMHxPCnTaOHxLA=; b=VhVRhXmudo1xSUd+HwCzGEeQ7XnkFREVP09rDN8krT+xdi6sAKoA6kAy0sP/9KDwof zOuOWzhio/jmFWbZGrpG0S7P6v5MrM/fWgSvCmeqssHPmWegQu2OZb3qLSBwLtHVca4B N5UuQ+UIOvdtgQEWR/6nYTOaqA98G/YzGh2HYvZISVbD8hxyZDEtFm85wDyhOBNNJiAX y7Bj+7Kjw7LJdmDSWrXSBbgFQKsUwl+zqHgXGvGkl9lLr2W22Iwz328t8gin+xAa7wNz vtTFfdCtFr6OtN1tkpxl9COJekLYXWkXxEhMBq8lB3SxThJmgjHm58Fe45tcHQpKSLU3 dWFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=RYXNKKSLKbuWAE9mYRQ16nqU5xlOECMHxPCnTaOHxLA=; b=KnNEtAxzBMYTjV9kMKLJQqrJUa3BM4tY6QJRqfUDJTy+5nXeJbQ3msa5zjLROJ+RcN /6ckTBTSxBTZIfSQ66vt6N6+kmXgvp43aUAXl/YgHqZ9Gvc6dW0PDGgBNc4Nt2RPwaV/ x1+Ex+GFKU9MowXOHFc0n2MqdmiPvpkVQnDF8HrpjeticA7RT4qOgW8CHd8UfFvvXsOi SoS0wDR5gBKBDBx4yjIM0zNt3s1+ujWy3aoL+oNtMeEYoZLOzd3myb0fQuJgiZ9wa0Qi H/XHwGgZu86ihudcxGnVEYJSC24zKvzWmyz0NxHSFEn5PpRYdiqp/c8MA9fQn8DejNz3 qNGA== X-Gm-Message-State: AOAM531FrJkS21/A3imnCSrI11JiS1v+B0t1fkNoWrR0kikRqQQryQdm kx1Ua6wFrN1MMK62t8irYcI= X-Google-Smtp-Source: ABdhPJy7ST4lP1rI4edPczlpoN3VdcUwMu5DN0FQV8EsXtdCmSxKf0sehHprvKyf2Zx5cyoN9TCyQg== X-Received: by 2002:a17:902:ed0a:b029:e4:3589:e4f9 with SMTP id b10-20020a170902ed0ab02900e43589e4f9mr13598893pld.36.1616731801465; Thu, 25 Mar 2021 21:10:01 -0700 (PDT) Received: from [10.230.29.202] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id r9sm6804827pgg.12.2021.03.25.21.09.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Mar 2021 21:10:00 -0700 (PDT) Subject: Re: [PATCH v7 00/38] SCMI vendor protocols and modularization To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: sudeep.holla@arm.com, lukasz.luba@arm.com, james.quinlan@broadcom.com, Jonathan.Cameron@Huawei.com, etienne.carriere@linaro.org, thara.gopinath@linaro.org, vincent.guittot@linaro.org, souvik.chakravarty@arm.com References: <20210316124903.35011-1-cristian.marussi@arm.com> From: Florian Fainelli Message-ID: <6bf4921a-12ad-a3b5-3dcc-d5463dd36729@gmail.com> Date: Thu, 25 Mar 2021 21:09:52 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210316124903.35011-1-cristian.marussi@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210326_041012_528289_B4878E8F X-CRM114-Status: GOOD ( 31.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 3/16/2021 5:48 AM, Cristian Marussi wrote: > Hi all, > > The current SCMI implementation does not provide an interface to easily > develop and include a custom vendor protocol implementation as prescribed > by the SCMI standard, also because, there is not currently any custom > protocol in the upstream to justify the development of a custom interface > and its maintenance. > > Moreover the current interface exposes protocol operations to the SCMI > driver users attaching per-protocol operations directly to the handle > structure, which, in this way, tends to grow indefinitely for each new > protocol addition. > > Beside this, protocols private data are also exposed via handle *_priv > pointers, making such private data accessible also to the SCMI drivers > even if neither really needed nor advisable. > > This series wants to address this by simplifying the SCMI protocols > interface and reducing it, roughly, to these common generic operations: > > - handle->devm_protocol_get() > - handle->devm_protocol_put() > - handle->notify_ops->* > > All protocols' private data pointers are removed from handle too and made > accessible only to the protocols code through dedicated internal helpers. > > The concept of protocol handle is also introduced in the SCMI protocol code > to represent a protocol instance initialized against a specific SCMI > instance (handle), so that all the new protocol code uses such protocol > handles wherever previously SCMI handle was used: this enable tighter > control of what is exposed to the protocol code vs the SCMI drivers. > > Moreover protocol initialization is moved away from device probe and now > happens on demand when the first user shows up (first .protocol_get), while > de-initialization is performed once the last user of the protocol, even in > terms of registered notifications callback, is gone, with the SCMI core > taking care to perform all the needed underlying resource accounting. > > This way any new future standard or custom protocol implementation will > expose a common unified interface which does not need to be extended > endlessly: no need to maintain a custom interface only for vendor protos. > SCMI drivers written on top of standard or custom protocols will use this > same common interface to access any protocol operations. > > All existent upstream SCMI drivers are converted to this new interface. > > In order to make this migration painless and to avoid the need of a big > un-mergeable jumbo patch touching all over the protocols and drivers (like > it was in v2), since v3 the migration process has been heavily split with a > bit of transient code added along the way (to preserve bisectability) and > finally removed towards the ends of the series. > Protocols and SCMI drivers migration to the new interface happens along > patches 10->30. > > Leveraging this new centralized and common initialization flow we took > care also to refactor and simplify protocol-events registration and remove > *notify_priv from the handle interface making it accessible only to the > notification core. > > Patch 37 builds on top of this new interface and introduces a mechanism to > define an SCMI protocol as a full blown module (possibly loadable) while > leaving the core dealing with proper resource accounting. > Standard protocols are still kept as builtins in this series, though. > > Finally, patch 38 introduces dynamic SCMI devices creation to avoid having > to update the static module device table in the core each time a new driver > is added. > > The whole SCMI stack can still be built alternatively as a module, with all > the standard protocols included in scmi-module.ko in such a case. > > On top of this series an example SCMI Custom protocol 0x99 and related > SCMI Custom Dummy driver has been built and it is available at [1] as a > series of DEBUG patches on top this same series. > > The series is currently based on sudeep/for-next/scmi [2] on top of: > > commit 908a4f778dc7 ("Merge branch 'ib-iio-scmi-5.12-rc2-take3' of > git://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio into > for-next/scmi") > > Any feedback welcome. You copied me on each round and thanks for doing that, I did not have time to go look at each change, but sensors, clocks and cpufreq still worked on ARCH_BRCMSTB with both 32-bit and 64-bit kernels, so: Tested-by: Florian Fainelli Thanks! -- Florian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel