From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 443C0C001DF for ; Mon, 31 Jul 2023 08:22:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Content-ID:In-Reply-To: References:Message-ID:Date:Subject:CC:To:From:Reply-To:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=u/uCFNxxpUpxIh0KB45B3OK3wUj+l+RMn1MTdrtijyE=; b=J9708mREp0ft2W lp0NowZYs0BHyf2HciWn24fVScjiLmpPAlQeYCqrPpIv67QCu1tg8D2dE29Bgv1W7U3990u8Pcex9 BYaapwV8pPB18l+Y4SzVyLiE8POY3Mq3aKxDFaZm1UYQQwqPnT+MEah51Sa2MWBEXr5wz2N9DMGEH SbgD0/VNkomRroKCTG2tTvGEn4oBm+ARefSPldo0Ok943KerFuPPzwcLV0u015e27Tofh6rb9vsRI RS44cQsY9RS0cYrnN0wlOEBJBm0NY+6dRGPseEIwGsCse6vt6XpHRtRaD8uCgq+3/aTXW4hGXP3IM efhNo4o5Ppy0RY4ailww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQOA0-00EWCt-0Y; Mon, 31 Jul 2023 08:21:48 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQO9x-00EWBZ-0f; Mon, 31 Jul 2023 08:21:46 +0000 X-UUID: 449133c02f7b11ee912e1518a6540028-20230731 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=MIME-Version:Content-Transfer-Encoding:Content-ID:Content-Type:In-Reply-To:References:Message-ID:Date:Subject:CC:To:From; bh=T99hATGukInAJcGycKe4WY5UKk1pHm+CWdE9a3WT16M=; b=WbyNnfNpFYKqWLc9C0eK7P668jtqVRAlny5d8eyGbmvS10z/noGb1YA/Oq6SmASbzIDOJJaxcdOQqBb4HGV4TthoPgsGziETiEYnkf8MLf1k1rJ6CoJX4cTncCh+dQYhgdSDHQydNbCTQzW2PgggpMOEJWcVwch8T+HGhBhsbYY=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.30,REQID:a1812f86-7cb9-46fe-a0eb-514fc43f34ef,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:1fcc6f8,CLOUDID:397bf9b3-a467-4aa9-9e04-f584452e3794,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0,AV:0,LES:1,SPR:NO, DKR:0,DKP:0,BRR:0,BRE:0 X-CID-BVR: 0 X-CID-BAS: 0,_,0,_ X-CID-FACTOR: TF_CID_SPAM_SNR X-UUID: 449133c02f7b11ee912e1518a6540028-20230731 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 403959250; Mon, 31 Jul 2023 01:21:37 -0700 Received: from mtkmbs10n2.mediatek.inc (172.21.101.183) by mtkmbs11n1.mediatek.inc (172.21.101.185) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.26; Mon, 31 Jul 2023 16:21:34 +0800 Received: from APC01-PSA-obe.outbound.protection.outlook.com (172.21.101.237) by mtkmbs10n2.mediatek.inc (172.21.101.183) with Microsoft SMTP Server id 15.2.1118.26 via Frontend Transport; Mon, 31 Jul 2023 16:21:34 +0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iC8UE/3KMlL51CSSdOv0VRQUyeuIgGKpUSk5YYNUqCSNnidvIkmQFreQ2qs32lxvZF0bWAQ4n2Z58JXtnfiXDR7s+DYh/cyCOA+8aMFpjLm43GkSO8MkSLX9Qf+nZi9LgZKkcLkTLTVyhQJi6QNWli2/ooyYY9h1BUbs2i42NWOosyQpIe3XxTi+rNAzxpGGmQ53ctgy1Gj6yP8zpSNSbM6g7Y9QF62W9RFpVOsluFwjh2pQNWjavqw46FuG9Nxe8rzbLIr14fMtdpGOc6M8UqadAi+pBzIlIJlMBkvdGqPqtviaEhpXySEaD9aWMlCPa12Ighz4F3dNTeksroYrGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=T99hATGukInAJcGycKe4WY5UKk1pHm+CWdE9a3WT16M=; b=OLdVSytXzdFuNgA7CBjQ/+ErUVV1suTQ7VtYS8fWN7B1rmAMlskh+MERkQvVTUCZ5K7vZe98yAv0FrnD72s5on5BMnqAnnGJiD1Y5kJBkiSyX3a9r97TpdLrzGjT3F1ibvRUNEry/sUXGnW6cY4riI7CEFRzVnGZgldViaMiwCXrOkK75kGtjdWd364u9TTZf1fusqUM8jiAAb8wP/aWwatgtLrMdQgEH3h/aBR4q3ot+IpkSQLuo90KnEuSIEjIZM/ICqzp6Y3u3+vp2Vz8Kv66dgYSkNkzvDGywlLVkKL47o5RVwHcXR6Kk4qFrsJFU5WoTD3YqgD4q/20qW7pWQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=mediatek.com; dmarc=pass action=none header.from=mediatek.com; dkim=pass header.d=mediatek.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mediateko365.onmicrosoft.com; s=selector2-mediateko365-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=T99hATGukInAJcGycKe4WY5UKk1pHm+CWdE9a3WT16M=; b=m17/fYuDjTmFlmErykNo4jlItIcbwMG1LVTdkI5Gx0w6GpdwltoKgNnGLrSTbQ7eiKgHCKY+7ny95K9qLAUq5HQJSL5oCgXoJq3xtU0F3fUxeVDo/dxVU2Ed5qBXMDBZ/rHspYqxOYt3ngS2/ymdPea4ojdC6Aoby51vbHtRSUM= Received: from SEYPR03MB7682.apcprd03.prod.outlook.com (2603:1096:101:149::11) by SEZPR03MB8016.apcprd03.prod.outlook.com (2603:1096:101:181::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6631.43; Mon, 31 Jul 2023 08:21:29 +0000 Received: from SEYPR03MB7682.apcprd03.prod.outlook.com ([fe80::1b82:a45d:e171:62e8]) by SEYPR03MB7682.apcprd03.prod.outlook.com ([fe80::1b82:a45d:e171:62e8%4]) with mapi id 15.20.6631.042; Mon, 31 Jul 2023 08:21:29 +0000 From: =?utf-8?B?SmFzb24tSkggTGluICjmnpfnnb/npaUp?= To: "chunkuang.hu@kernel.org" , "angelogioacchino.delregno@collabora.com" , "eugen.hristev@collabora.com" CC: "linux-mediatek@lists.infradead.org" , =?utf-8?B?U2luZ28gQ2hhbmcgKOW8teiIiOWciyk=?= , =?utf-8?B?Sm9obnNvbiBXYW5nICjnjovogZbpkasp?= , =?utf-8?B?SmFzb24tY2ggQ2hlbiAo6Zmz5bu66LGqKQ==?= , =?utf-8?B?U2hhd24gU3VuZyAo5a6L5a2d6KyZKQ==?= , "linux-kernel@vger.kernel.org" , =?utf-8?B?TmFuY3kgTGluICjmnpfmrKPonqIp?= , "dri-devel@lists.freedesktop.org" , Project_Global_Chrome_Upstream_Group , "linux-arm-kernel@lists.infradead.org" , "matthias.bgg@gmail.com" Subject: Re: [PATCH v7 2/4] drm/mediatek: Fix using wrong drm private data to bind mediatek-drm Thread-Topic: [PATCH v7 2/4] drm/mediatek: Fix using wrong drm private data to bind mediatek-drm Thread-Index: AQHZwKkypTU41zGk0kqR4mBL6m3qP6/O3w2AgASvoIA= Date: Mon, 31 Jul 2023 08:21:28 +0000 Message-ID: <6c07d1bc12c9226bf623da0a46ffaadb151c2175.camel@mediatek.com> References: <20230727164114.20638-1-jason-jh.lin@mediatek.com> <20230727164114.20638-3-jason-jh.lin@mediatek.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=mediatek.com; x-ms-publictraffictype: Email x-ms-traffictypediagnostic: SEYPR03MB7682:EE_|SEZPR03MB8016:EE_ x-ms-office365-filtering-correlation-id: 5c60428b-2040-451a-b165-08db919f23d8 x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: rHn1LGqK9cz3ZvI+2sxp6GtRrY6pciNfliYwwW+y5GI5ABvNh8qTQX3hN1Dy9lkQldgHu1PhZCk2K8Yx8j9+ZsgeMzISG99i89aBmecUfNkldRXRfpEZvG3WWAqS+LBzd3YOZGUvPc8QRrBqOVV78fT0z6xmow92Q9Yc9QC3w+d8culHAfbRtWKm/aHf4kEpObQ52N/t9WH0IcpKTP9UvReDphyXzAolbtjAHwky46ohOLPPYTnzw3di90blUehLXEjBX+iiaNOmuSpLH03tDMnK+yTkkrjyejGH1DuL9Qivmu0qAZdtRAOug3NgjXgWHa1he3Tf1W0RCKv+v4iSszyYJaNo32XofNorYqXU0Iv9sJsT5xtRIqMbC/e4g6Mx+a81FiCcoRdGItIFzbRleyWI9f2xNwJfJwjgoZgcNoDPKeNgP/xqN0+wcGUbZELCp60BvTcV/p2ROMjKj3FHaT0iukqGY1cXgjb9wcP4lndS60A/5hujwieecpvxKf1HEX4AzFIh3WXqWnQP3fGInAjogrrN2H+1R2e/ET5XmfbmgxsdGT7Wln++ghS2TgJ5HpSXOOK8gdlMCqEOFORdWPHzRLGJYbIEpQNAzm+JWSNkch5Ho+s82+INk9NeRi+YA2RXUYGVIVyGdnWwX6teeiXJcAA2LTKxTwHxS3ei3gs= x-forefront-antispam-report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SEYPR03MB7682.apcprd03.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(366004)(39860400002)(346002)(396003)(136003)(451199021)(6512007)(71200400001)(6486002)(186003)(83380400001)(2616005)(36756003)(85182001)(86362001)(38070700005)(122000001)(38100700002)(53546011)(26005)(6506007)(64756008)(66446008)(66476007)(66556008)(2906002)(66946007)(4326008)(76116006)(91956017)(316002)(5660300002)(41300700001)(8936002)(8676002)(478600001)(110136005)(54906003);DIR:OUT;SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?utf-8?B?c1Zya2NzbWpQVDlSN2pMVEJIWkpXUk9SeGw5R0FZMDByN3ZLb3ZocVU1MUd4?= =?utf-8?B?aHc4eGhGbXJrdmlsMmt4dzl1NjdTYzBhaTVWT1lXWGxxLzhlVlBIUUc4ekVq?= =?utf-8?B?Y1pWWVJHd2xzVEEvbmpjd3l1T2VBTWZFVTlNcTlvU21iTGVueUMrVFpIenRE?= =?utf-8?B?blBuR1UzK2lYLzZhb1d5V012ekx1OXF4Q3MrYVpzMnYxRS9MWmRLYXk4K0NN?= =?utf-8?B?cEtad0ZYdFpobWwwWWZDbFcrZFY1RWN5UVFaeTQvZjJjb3NjNldvMkdEeWls?= =?utf-8?B?bFZBeFp4aWVDVzNJSnpmWjA4V1dSbW1ybEFnNHErS2NiN0JEamxXaG5IZDkv?= =?utf-8?B?VFk5d1FzSjd5QVB2b0tueWUyUnhPVXJIdUlrRVdnOHhKcWtYdDBCQllLYW1Q?= =?utf-8?B?VHhUUkx6RThGVHlEekJOVTBXTkRFbDFHTzBHYUxncko2NnR6eUgxSmxxd2Nr?= =?utf-8?B?blhyWkNRZDFzTFo4Yi9FeDUzeFJvSGdXU2Y0L01PK1RDS3ZuUFBFYURZQXdW?= =?utf-8?B?WXYrNEsvZjBvSUVFYmZhQjhIMGtBYy9DZzYxVWlTaU04WWszK280dzdoVzkx?= =?utf-8?B?ZEF3WkxVZnZTQ2N6UzU4aEJoYXd3ZEpaMnlWY2NNRDhMMkJ6ZEQrb1BRcEhR?= =?utf-8?B?WExqNC9RY0xncHBFcC9iWTJocmdmWHkzUUJDbFcxTDQ3eU5KdGlOMlBIQWlN?= =?utf-8?B?aTR1MDlqd0FEN3FVQUdOMWk2Ull6cVZOa2c0cGZLTFZXdENvVk9mUGgwTnFq?= =?utf-8?B?RVAzM0k2NmVGN2h1MmxvZGJkSDJsRW55Z2tZUVI2LzFFZkVDT0pIclJ0Vm1n?= =?utf-8?B?N0xBVDBmSUxDbjJ6QW1DeXhHVGJYVWZQek1qaVlqdXo4TzJqMGdIQnI1T0Vk?= =?utf-8?B?SUw0Yjg1VVl4Q0xYS3BOOW5ac0VPQWc1d3U5NzREOUZLY1pSd04vZEtoV2tk?= =?utf-8?B?ODg5SndDeFlmM0tSYWVwNW1FRnRicDJNYkc2UTZ5WXVnTlNBUXJsem5ZdjdL?= =?utf-8?B?OG1kd2oxNGRJVWVOV0tTR2o4NWhjbmdyRVNHTjVBQXRON1Rmbk91RnZrcWRK?= =?utf-8?B?Ty8wV3djZ2NPVDVKaC9Lb1dsVDl1Q3F5aTJ4Q08ydnNSN2ZuUDIwQ2Nzem5E?= =?utf-8?B?YXJsUXBwd0FIUUR6T1ZtVGxYMGlUcU5Jalh1L0hTVEtDVjI3dlV3VXVKYzgr?= =?utf-8?B?UnhRR0RkVDNrbVZaUm9KalZqckxsdm5FQ1VMSTkzakNDQmptdWpqdkdFWml6?= =?utf-8?B?VkxXcUViYThVNDluU014YjdMRDM2YjJGQU5Fd3lqMWU0aE80dW8wN1NBejU3?= =?utf-8?B?VHNxT2hFcERPZ09zU1ZvbUpRNERNYnorL25kdGovc3ZPeEZXeWdCaUpCaFZa?= =?utf-8?B?ZFFsc0haeHdaZzZ5VlpYYmV3MjBNbkN3QXBObmlvWXdQSEdiQzJ6R1ZTd3hp?= =?utf-8?B?ejVvZGhwTXBhU29JV2VUNitSZWo5dkMraGE4V1BWcTgydmFodk1rcUtSeWtD?= =?utf-8?B?MWJUTm5YS2dKQmU2eVo0eGN6QkdUSUNOS3Rnc2VneWMwdDJzdlZjbGRjVjJE?= =?utf-8?B?QTFqUmxMYmtSKzRNd2JLMktSVGxMN0dMMVBKTEZ1c1VPWlVVWVNEakdEM1NK?= =?utf-8?B?L3QwbnJkT25ZN0JlSWI1UWQ4dlVYd3JMc0xIbTVqbUxGSzhUN2tnL24vVEUw?= =?utf-8?B?MlY2ZzlnQTFHallXMHU0eU5LR2RjY3RTbE5WUFp6aS9iZkFuc29JMnVPU3Ji?= =?utf-8?B?bUhUdTc3a0gzbW4yR09vT3RQRGNrRjFST2RYY1oydUN0QW9hdHZxR2M1MkhY?= =?utf-8?B?d0pTM3RjNzhkNXVWcC9yWCtEMFRpcXRXbXpYTzBOQ2pDdWZQZGsrd3QrQkYr?= =?utf-8?B?VHJoWXliVjVCSkxHenZxa0ZqMDJCQVkwNnd6eU9QUmt5d3BuYmtZajFNTlBR?= =?utf-8?B?Y3d0NlhPRm1aMnM3amF3SmFIREp4bmkzWG9vWTBmRisranlIQ0V5NTI4VHhW?= =?utf-8?B?bFlXVHBQWGZaSkFDOVZxM0RxZlFHb2lNc3ZRd3Q5eGFXRkpUYkVXUkVaT3JC?= =?utf-8?B?d21lcnIwTTRBN1FzZHpDNW1GVjBuem1JMjJQSm5tWXU3eDdua0ROWi91eWdx?= =?utf-8?B?OWs2K1V4UHhkK0hiVTl0SHMzSEtuMjZQL1crbDQzbTBUL3NwZ0JCTzlZU1FJ?= =?utf-8?B?OHc9PQ==?= Content-ID: <49BBB81ADC99DA46AA6E02A74792490E@apcprd03.prod.outlook.com> MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: SEYPR03MB7682.apcprd03.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c60428b-2040-451a-b165-08db919f23d8 X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jul 2023 08:21:29.0027 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: a7687ede-7a6b-4ef6-bace-642f677fbe31 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ok/Wp5DC3iRNkwtXQrhac++EptJoV5ImVHma145Mw2WsxFPzFB1fNgyJ3CAE8wUU6vFXDzqrvfAa1mDRRwHjYpgM9nnWfbxPgdVW3kpn4zk= X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEZPR03MB8016 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230731_012145_260401_DE3CF9C7 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Eugen, Thanks for the reviews. On Fri, 2023-07-28 at 11:47 +0300, Eugen Hristev wrote: > Hi, > > On 7/27/23 19:41, Jason-JH.Lin wrote: > > Add checking the length of each data path before assigning drm > > private > > data into all_drm_priv array. > > > > Fixes: 1ef7ed48356c ("drm/mediatek: Modify mediatek-drm for mt8195 > > multi mmsys support") > > Signed-off-by: Jason-JH.Lin > > --- > > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 16 +++++++++++++--- > > 1 file changed, 13 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > index 249c9fd6347e..d2fb1fb4e682 100644 > > --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c > > @@ -351,6 +351,7 @@ static bool mtk_drm_get_all_drm_priv(struct > > device *dev) > > { > > struct mtk_drm_private *drm_priv = dev_get_drvdata(dev); > > struct mtk_drm_private *all_drm_priv[MAX_CRTC]; > > + struct mtk_drm_private *temp_drm_priv; > > struct device_node *phandle = dev->parent->of_node; > > const struct of_device_id *of_id; > > struct device_node *node; > > @@ -373,9 +374,18 @@ static bool mtk_drm_get_all_drm_priv(struct > > device *dev) > > if (!drm_dev || !dev_get_drvdata(drm_dev)) > > continue; > > > > - all_drm_priv[cnt] = dev_get_drvdata(drm_dev); > > - if (all_drm_priv[cnt] && all_drm_priv[cnt]- > > >mtk_drm_bound) > > - cnt++; > > + temp_drm_priv = dev_get_drvdata(drm_dev); > > + if (temp_drm_priv) { > > + if (temp_drm_priv->mtk_drm_bound) > > + cnt++; > > + > > + if (temp_drm_priv->data->main_len) > > + all_drm_priv[0] = temp_drm_priv; > > + else if (temp_drm_priv->data->ext_len) > > + all_drm_priv[1] = temp_drm_priv; > > + else if (temp_drm_priv->data->third_len) > > + all_drm_priv[2] = temp_drm_priv; > > + } > > Previously the code was assigning stuff into all_drm_priv[cnt] and > incrementing it. > With your change, it assigns to all_drm_priv[0], [1], [2]. Is this > what > you intended ? Because dev_get_drvdata(drm_dev) will get the driver data by drm_dev. Each drm_dev represents a display path. e,g. drm_dev of "mediatek,mt8195-vdosys0" represents main path. drm_dev of "mediatek,mt8195-vdosys1" represents ext path. So we want to make sure all_drm_priv[] store the private data in the order of display path, such as: all_drm_priv[0] = the private data of main display all_drm_priv[1] = the private data of ext display all_drm_priv[2] = the private data of third display > If this loop has second run, you will reassign to all_drm_priv again > ? Because the previous code will store all_drm_priv[] in the order of mtk_drm_bind() was called. If drm_dev of ext path bound earlier than drm_dev of main path, all_drm_priv[] in mtk_drm_get_all_drm_priv() may be re-assigned like this: all_drm_priv[0]->all_drm_priv[0] = private data of ext path all_drm_priv[1]->all_drm_priv[0] = private data of ext path all_drm_priv[0]->all_drm_priv[1] = private data of main path all_drm_priv[1]->all_drm_priv[1] = private data of main path But we expect all_drm_priv[] be re-assigned like this: all_drm_priv[0]->all_drm_priv[0] = private data of main path all_drm_priv[1]->all_drm_priv[0] = private data of main path all_drm_priv[0]->all_drm_priv[1] = private data of ext path all_drm_priv[1]->all_drm_priv[1] = private data of ext path > I would expect you to take `cnt` into account. > Also, is it expected that all_drm_priv has holes in the array ? Each drm_dev will only called mtk_drm_bind() once, so all holes will be filled after all drm_dev has called mtk_drm_bind(). Do you agree with this statement? :) Regards, Jason-JH.Lin > > Eugen > > > > > } > > > > if (drm_priv->data->mmsys_dev_num == cnt) { > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel