From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4E5EDC52D71 for ; Tue, 6 Aug 2024 16:48:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+fAYh7NklhLBjpKe9sHoFdzJliLK6+I4PaScht2r68M=; b=i7IJlJ3fGVnZ4rda+ZkSZZdWRT 6QxpPRFQccUg18cOMeSJzFuDHKwroGJ9cqUzoUWuQZpa8kN+mAy6ck/3pZzxb2ChHdpAM73qFOB09 HHqp+nTpH1fRwAan5lrPI0BDlnqrOOjvjBg5EaS+UmVHAwuMmT18/BWQ4Ii6MOy1sQsKHW2x2GnE8 1vrKedCR1uxyYbyg8V7G333pyYTfBFeN6exVwoRwInS99FWp0NQmoAAHGyS7keeXW6tKVstEAt5eZ kI9fOQMBxzE9RqzJ9leF9jHOhjt7CIlAdM/hXqK+DWtjIjvo3UBz2uUmorBOOnIjTuGyF8iIIEshJ 0vNg2uDQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbNLn-00000002OKB-31M6; Tue, 06 Aug 2024 16:47:55 +0000 Received: from mail-pf1-x429.google.com ([2607:f8b0:4864:20::429]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbNLF-00000002OG9-2kie for linux-arm-kernel@lists.infradead.org; Tue, 06 Aug 2024 16:47:23 +0000 Received: by mail-pf1-x429.google.com with SMTP id d2e1a72fcca58-7107b16be12so668661b3a.3 for ; Tue, 06 Aug 2024 09:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1722962840; x=1723567640; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=+fAYh7NklhLBjpKe9sHoFdzJliLK6+I4PaScht2r68M=; b=EzR26/UKq3+lhv1BqPVjdi56wpz4yvfJ7yOfFq2t3pnOj63Tl4YyQVeDPlSShBdiNK kUmknk7r0FuDeDeMWXq4qUSkUvx5Nr0kiQG+Onw1WqTEYta0P+y79eO47u7tI1l6rWRn lRBvSDX/oC8++QGsZGh2jSr72YxDzbQVOHGDf9WEuhD1PS8zb8ZTkSvTQzT9I+XQhGsm mZcuqn59TEWXbIvCDg90F7SOuyxrABPcpr5mwWnyyiCN4d8y/lplx/pP8uGSZhV3RRqV LrY7/7G1bOJiE0IdLYISRbKsRKhiuQ/5UPuD5XHslYVy1jIk/PaGSLNO94Jcd2kT49Xy aoVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722962840; x=1723567640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=+fAYh7NklhLBjpKe9sHoFdzJliLK6+I4PaScht2r68M=; b=eV4kE/X41r5qIGRCHoxPVvkoRIWVQTi/8fkaUtEpdLH+ZCQV2TlJ5KtxOC3Mg+R3jv R4BzLh80d/E0USGaob4ItRwsVR+v7VrxzHQZTMIZ2k9s5fOA0Di1gKdjwHP8jIdzVpjQ hEqxQBJajcNEaFSeJnqeqUiO0Udcv0DbTLmSqN9LlrQQZqb9l4iFmD3foyBbvVwDZ1ot mceuWekinqB8uEtIOP9VhX5Sy/Z6jEs8jm2EMcpdNKHCgRMyNusVf1mPX2diARN6pduZ Je7eYnISp5k/Gt9lkdSj8wGB6rWzsvcmMmh3M/G4AcFvTpmKxIys9CD/qeg6SLSx+ht0 Zxfw== X-Forwarded-Encrypted: i=1; AJvYcCX65rh7Lv4C/EOXtRdHHuBSXKhYWTjac0FZXVps6/8zGFLNlwe7gt71vMybDWvUZGuP6zrstmfXNAfCDdTR2bPNuWILZSKsVLcVus/eUUuaaEIsw/A= X-Gm-Message-State: AOJu0Yz4mFm7jlmEFFQpnKcAYcbqfHEcVt/Xt3mfKaR9VyeIZ9VXA124 JesQ5NY2KNm1Z83zAjPrcAiBY0yIO85vbzMrdH3ZhMY6GpR8c9G9 X-Google-Smtp-Source: AGHT+IHNn+3tDwOKtFAmo1AONjvRl0gq90xof22nJT9D9Qh8nzmQSzz9i2x+YAL1tQ1smdjThcVLMw== X-Received: by 2002:a05:6a21:10f:b0:1c0:f23c:28a7 with SMTP id adf61e73a8af0-1c699668f98mr14273228637.44.1722962839602; Tue, 06 Aug 2024 09:47:19 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.googlemail.com with ESMTPSA id d2e1a72fcca58-7106ec0bda0sm7141971b3a.8.2024.08.06.09.47.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 06 Aug 2024 09:47:19 -0700 (PDT) Message-ID: <6c2b185e-42d4-408b-a7f5-972b2099067b@gmail.com> Date: Tue, 6 Aug 2024 09:47:17 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/9] Make SCMI transport as standalone drivers To: Cristian Marussi , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, arm-scmi@vger.kernel.org Cc: sudeep.holla@arm.com, james.quinlan@broadcom.com, vincent.guittot@linaro.org, etienne.carriere@st.com, peng.fan@oss.nxp.com, michal.simek@amd.com, quic_sibis@quicinc.com, quic_nkela@quicinc.com, ptosi@google.com, dan.carpenter@linaro.org, souvik.chakravarty@arm.com References: <20240730133318.1573765-1-cristian.marussi@arm.com> Content-Language: en-US From: Florian Fainelli In-Reply-To: <20240730133318.1573765-1-cristian.marussi@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240806_094721_731665_FBDD7737 X-CRM114-Status: GOOD ( 30.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 7/30/24 06:33, Cristian Marussi wrote: > Hi all, > > Till now the SCMI transport layer was being built embedded into in the core > SCMI stack. > > Some of these transports, despite being currently part of the main SCMI > module, are indeed also registered with different subsystems like optee or > virtio, and actively probed also by those: this led to a few awkward and > convoluted tricks to properly handle such interactions at boot time in the > SCMI stack. > > Moreover some partner expressed the desire to be able to fully modularize > the transports components. > > This series aim to make all such transports as standalone drivers that can > be optionally loaded as modules. > > In order to do this, at first some new mechanism is introduced to support > this new capability while maintaining, in parallel, the old legacy embedded > transports; then each transport, one by one, is transitioned to be a > standalone driver and finally the old legacy support for embedded transport > is removed. > > Patch [1/9] is a fix around the chan_free method for OPTEE transport; it is > really unrelated to this series, but included to avoid conflicts. > > Patch [2/9] is a mostly unrelated (but much needed) clean-up from Peng, > which I included in this series to avoid conflicts at merge. > > Patch [3/9] simply collects the existing datagram manipulation helpers in a > pair of function pointers structures, in preparation for later reworks. > > Patch [4/9] adds the bulk of the new logic to the core SCMI stack and then > each existing transport is transitioned to be a standalone driver in > patches 5,6,7,8 while shuffling around the compatibles. (no DT change is > needed of curse for backward compatibility) > While doing this I kept the module authorship in line with the main > author(S) as spitted out by git-blame. > > Finally patch [9/9] removes all the legacy dead code from the core SCMI > stack. > > No new symbol EXPORT has been added. > > The new transport drivers have been tested, as built-in and LKM, as > follows: > > - mailbox on JUNO > - virtio on emulation > - optee on QEMU/optee using Linaro setup > > Exercised using the regular SCMI drivers stack and the SCMI ACS suite, > testing commands, replies, delayed responses and notification. > > Multiple virtual SCMI instances support has been tested too. > > SMC has NOT been tested/exercised at run-time, only compile-tested. > (due to lack of hardware) > > Note that in this new setup, all the probe deferral and retries between the > SCMI core stack and the transports has been removed, since no more needed. > > Moreover the new drivers have been tested also with a fully modularized > SCMI stack, i.e.: > > scmi-core.ko + scmi-module.ko + scmi_transport_*.ko [ + vendor modules ] > > Based on v6.11-rc1 > > Any feedback, and especially testing (:D) is welcome. Tested-by: Florian Fainelli -- Florian