From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2FF4DC433DF for ; Mon, 24 Aug 2020 11:45:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D42A32074D for ; Mon, 24 Aug 2020 11:45:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ATXoTXO9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D42A32074D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Cc:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=NiC8N7o21h0ON39hxtl8lcsLO8YnwxpNFbAhfN13eio=; b=ATXoTXO9rQDKoUrQ4nBF+VEe6 wapJqkDJ6rp0cUxh3cPIWptF5eBEQHs0BoxIy6kPbQck4KHhDkFvOMPigdlcdl/d2mfg5kCnql5Xd WuFvJGXP6OoZw5VnNkB+qwFiYJuVyWGIQtadTq5YIHjJwHIOJeEaSeOUxXqB/d4iehsiTJl2MygOt mogi2Dbn9nhFTWC1YFCzXBRIag3BbjNZRxPE19oDBd0AdxM3XkYXen34V79uy6KnD0c9fO+v2ikWN E1/ayQTvs3+kOkvdr8FoL9iHYrd59v2QmyFulbcPU3BkBEVP87xT+cJ42KHt5IlcMt7bYVj0LPiyk P5qHhQSdg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAAt3-0002UJ-Nn; Mon, 24 Aug 2020 11:43:41 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kAAt0-0002Td-LY for linux-arm-kernel@lists.infradead.org; Mon, 24 Aug 2020 11:43:39 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F21631063; Mon, 24 Aug 2020 04:43:36 -0700 (PDT) Received: from [10.37.12.65] (unknown [10.37.12.65]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 9399D3F66B; Mon, 24 Aug 2020 04:43:35 -0700 (PDT) Subject: Re: [PATCH 2/3] memory: samsung: exynos5422-dmc: remove unused exynos5_dmc members To: Krzysztof Kozlowski , Kukjin Kim , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20200822163218.21857-1-krzk@kernel.org> <20200822163218.21857-2-krzk@kernel.org> From: Lukasz Luba Message-ID: <6c61572d-ef7a-ca0a-2253-7a3c0736f0a5@arm.com> Date: Mon, 24 Aug 2020 12:43:33 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <20200822163218.21857-2-krzk@kernel.org> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200824_074338_774217_39F6522F X-CRM114-Status: GOOD ( 22.61 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On 8/22/20 5:32 PM, Krzysztof Kozlowski wrote: > The struct exynos5_dmc members bypass_rate, mx_mspll_ccore_phy, > mout_mx_mspll_ccore_phy and opp_bypass are not actually used. > > Apparently there was a plan to store the OPP for the bypass mode in > opp_bypass member, but drivers fails to do it and instead always sets > target voltage during bypass mode. > > Signed-off-by: Krzysztof Kozlowski > --- > drivers/memory/samsung/exynos5422-dmc.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/memory/samsung/exynos5422-dmc.c b/drivers/memory/samsung/exynos5422-dmc.c > index 31864ce59b25..df02afa8aa90 100644 > --- a/drivers/memory/samsung/exynos5422-dmc.c > +++ b/drivers/memory/samsung/exynos5422-dmc.c > @@ -123,9 +123,7 @@ struct exynos5_dmc { > struct mutex lock; > unsigned long curr_rate; > unsigned long curr_volt; > - unsigned long bypass_rate; > struct dmc_opp_table *opp; > - struct dmc_opp_table opp_bypass; > int opp_count; > u32 timings_arr_size; > u32 *timing_row; > @@ -143,8 +141,6 @@ struct exynos5_dmc { > struct clk *mout_bpll; > struct clk *mout_mclk_cdrex; > struct clk *mout_mx_mspll_ccore; > - struct clk *mx_mspll_ccore_phy; > - struct clk *mout_mx_mspll_ccore_phy; > struct devfreq_event_dev **counter; > int num_counters; > u64 last_overflow_ts[2]; > @@ -455,9 +451,6 @@ static int exynos5_dmc_align_bypass_voltage(struct exynos5_dmc *dmc, > unsigned long target_volt) > { > int ret = 0; > - unsigned long bypass_volt = dmc->opp_bypass.volt_uv; > - > - target_volt = max(bypass_volt, target_volt); Could you explain which use cases you considered when you decided to remove these lines? Regards, Lukasz _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel