From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 358C9C77B6F for ; Tue, 11 Apr 2023 13:17:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RRxexgLpZWosM1WR06KoL/8HIdNe/bvTSIehdrfo92U=; b=IlHtxEA+MewI8W ihkYpfDFwvpEaeSlyZrlwbkyenscxYDRzveyKErrSSDZ6auod1abDZbFRnxadlID9RNQ672LjhCKI ado1w6EzUpUBzdkLzr5ecUF54gnRcdnzN4aUo6JVBrEgqxspx6V1XkcMF0qXp3FU7c7/bVhJ33J3O e4gtcqPMqaprHBuNCNDeXmVGwezHncyfSihUb76jd4L125OM3h02Io9iR2CEcr+lNGP1ioNVZ6xPO HNpr4WmdPQbhEJ/mmwKZJdQjII44r1Gu7/M35PFSOMJuY/47aovTjrA8VJd0nexqa+tekEaDzlvFt C1z1Nm7D+nIQoAqBJU1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmDrK-0005at-18; Tue, 11 Apr 2023 13:16:30 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmDrH-0005Zq-2o for linux-arm-kernel@lists.infradead.org; Tue, 11 Apr 2023 13:16:29 +0000 Received: by mail-lf1-x12b.google.com with SMTP id z8so12171963lfb.12 for ; Tue, 11 Apr 2023 06:16:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681218982; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=CcUTTOUcMW0dZnIqgtsXXko3U+fcNkeoSkY3ZJOPmXE=; b=LYUd4gN0uvXVwbiLe+XaMSfZYrd+SwcY14tzEW5bLYbnCvbOjB/IB4sP6F1LfgFC7q BSefua8JuXbOq7EDzM3b9LBcTQGaMqZAjneiOHp8G/rdIR43GAt4B6ZchiceXSFwWa07 xv+hX5RZbZpq5DoIIPl9x5aHvqBhYh1TbFKpe0gKwjKLVQcy+A+Yp6MCFft43Xuzk53a 8TBiENf2cer2zEgRynfAzy+gC6VszB9hwZCbV6aJjdGuQcA9Z1XfpgeNHciFodlwRcBr HHzjrhwHuXKETo6CNUblAQs9jRzsoD8XM6zqjI7vlCIFUY2AqEi0T1Lx3sRC3Bk1szZ0 /eww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681218982; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=CcUTTOUcMW0dZnIqgtsXXko3U+fcNkeoSkY3ZJOPmXE=; b=wGpUWSLeRHsg6tMw6B3A/mqMtATjJhze9o4kVz/HITFmuDS4wQb42VuDKZvi8fOXAJ 24ZCFwoWXbwxUpgO5aNnQVYbfOlw+6pG60DbHlNP8TlZ74DNqqEreY94zEID8Hw2RQA9 4CxpiEWiGnWx1oMEs0yAV4V3CCMBpCv0pqoWjVs5qm/JM6CNx2VDf7+Htbab+qIIW55R 2dxl4bqM7nRp435qdxMpLVQxjIWzPU54F1TbtX1Ew4Lc1OFLxlb5tguGib40y7kmONfr mzguBIhVyMkjXyytKkZC46fmgFGc9flTimZxxrG6fEE95xWL+e0/wQD+i5zBUD1ZDnhL 4//g== X-Gm-Message-State: AAQBX9cHCUYliRIFN/yIXUh3A9Zxps5ZVfFyzq0h3MmjFgpFnUZrcPlt xhd4g0wa1oLYT4hbmBNGju29oQ== X-Google-Smtp-Source: AKy350blhLpXLllc5IUc17Ff5DabLr3YrfUjg7JsGcKpnIEbMfXx9pu1SF8NEN24gpwptlidkj7IFg== X-Received: by 2002:ac2:414a:0:b0:4d5:978e:8bcf with SMTP id c10-20020ac2414a000000b004d5978e8bcfmr3481121lfi.33.1681218982568; Tue, 11 Apr 2023 06:16:22 -0700 (PDT) Received: from [192.168.1.101] (abxj23.neoplus.adsl.tpnet.pl. [83.9.3.23]) by smtp.gmail.com with ESMTPSA id r26-20020ac252ba000000b004eb09820adbsm2557794lfm.105.2023.04.11.06.16.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 06:16:22 -0700 (PDT) Message-ID: <6c75d434-bb5d-278f-a125-d096fd6b387d@linaro.org> Date: Tue, 11 Apr 2023 15:16:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v3 7/7] arm64: dts: qcom: sa8775p: add the GPU IOMMU node Content-Language: en-US To: Bartosz Golaszewski , Bjorn Andersson , Andy Gross , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Will Deacon , Robin Murphy , Joerg Roedel , Catalin Marinas , Arnd Bergmann Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev, Bartosz Golaszewski References: <20230411125910.401075-1-brgl@bgdev.pl> <20230411125910.401075-8-brgl@bgdev.pl> From: Konrad Dybcio In-Reply-To: <20230411125910.401075-8-brgl@bgdev.pl> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230411_061627_911231_929A5737 X-CRM114-Status: GOOD ( 17.31 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 11.04.2023 14:59, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > Add the Adreno GPU IOMMU for sa8775p-based platforms. > > Signed-off-by: Bartosz Golaszewski > --- > arch/arm64/boot/dts/qcom/sa8775p.dtsi | 37 +++++++++++++++++++++++++++ > 1 file changed, 37 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/sa8775p.dtsi b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > index 191b510b5a1a..11f3d80dd869 100644 > --- a/arch/arm64/boot/dts/qcom/sa8775p.dtsi > +++ b/arch/arm64/boot/dts/qcom/sa8775p.dtsi > @@ -7,6 +7,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -605,6 +606,42 @@ gpucc: clock-controller@3d90000 { > #power-domain-cells = <1>; > }; > > + adreno_smmu: iommu@3da0000 { > + compatible = "qcom,sa8775p-smmu-500", "qcom,adreno-smmu", > + "arm,mmu-500"; Err.. does it even boot like this? You dropped the qcom,smmu-500 compatible which means it's getting bound to the generic SMMU driver (without QC quirks). If that was a mistake, you should have had all 4 "qcom,sa8775p-smmu-500", qcom,adreno-smmu, "qcom,smmu-500", "arm,mmu-500" Without falling into the qc-specific codepaths, the Adreno compat does nothing. Konrad > + reg = <0x0 0x03da0000 0x0 0x20000>; > + #iommu-cells = <2>; > + #global-interrupts = <2>; > + dma-coherent; > + power-domains = <&gpucc GPU_CC_CX_GDSC>; > + clocks = <&gcc GCC_GPU_MEMNOC_GFX_CLK>, > + <&gcc GCC_GPU_SNOC_DVM_GFX_CLK>, > + <&gpucc GPU_CC_AHB_CLK>, > + <&gpucc GPU_CC_HLOS1_VOTE_GPU_SMMU_CLK>, > + <&gpucc GPU_CC_CX_GMU_CLK>, > + <&gpucc GPU_CC_HUB_CX_INT_CLK>, > + <&gpucc GPU_CC_HUB_AON_CLK>; > + clock-names = "gcc_gpu_memnoc_gfx_clk", > + "gcc_gpu_snoc_dvm_gfx_clk", > + "gpu_cc_ahb_clk", > + "gpu_cc_hlos1_vote_gpu_smmu_clk", > + "gpu_cc_cx_gmu_clk", > + "gpu_cc_hub_cx_int_clk", > + "gpu_cc_hub_aon_clk"; > + interrupts = , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + , > + ; > + }; > + > pdc: interrupt-controller@b220000 { > compatible = "qcom,sa8775p-pdc", "qcom,pdc"; > reg = <0x0 0x0b220000 0x0 0x30000>, _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel