From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20438C433FF for ; Mon, 12 Aug 2019 13:28:26 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E982120651 for ; Mon, 12 Aug 2019 13:28:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Ciij/VZ/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E982120651 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pnJ1bWTor1UdznzTpanpIAF4nAlwN6v1xQII9W95dYo=; b=Ciij/VZ/b0yXDv T3lGvln/b6IDndnL04EPo3UmMz18jqB60UDwI77dJWL/7aJ2uPsd7y2pB+4PUjkHSrSkmlfpH5AmP Vgdyu9+R71MSHEXS8VZ3yClna0vdJ2kdD7sotfcctAwMyZIStv/35iThVTYmMSpj+WZftLEN4OuM7 xrDKVpMWYLHuxdmQlAOiQn1fBfCMr2mWCiCI/2pCSqfOyibZEcP/PPGu4n7iNZkLtUKZ2hhBc3Z5d +Cagy/U6G7G1c5wkHnCJl+sT9IbgvvEhVEpYw1RJQPlckeMYy5uQsIPA3NUk6UJyzc7cTVolwYEU4 aN4GNEpGgDIRgfrK1O6g==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hxAN6-0007aL-Uv; Mon, 12 Aug 2019 13:28:24 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92 #3 (Red Hat Linux)) id 1hxAN4-0007Zd-3v for linux-arm-kernel@lists.infradead.org; Mon, 12 Aug 2019 13:28:23 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 97A362834A8 Message-ID: <6c78d1343b92e08c92e568a9e349fe22ac2f4aed.camel@collabora.com> Subject: Re: [PATCH 1/7] media: cedrus: Disable engine after each slice decoding From: Ezequiel Garcia To: Maxime Ripard , Jernej Skrabec Date: Mon, 12 Aug 2019 10:28:11 -0300 In-Reply-To: <20190603113827.2nmm5wkycf44aqox@flea> References: <20190530211516.1891-1-jernej.skrabec@siol.net> <20190530211516.1891-2-jernej.skrabec@siol.net> <20190603113827.2nmm5wkycf44aqox@flea> Organization: Collabora User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190812_062822_294544_155F4D2A X-CRM114-Status: GOOD ( 11.89 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, paul.kocialkowski@bootlin.com, wens@csie.org, mchehab@kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Jernej, On Mon, 2019-06-03 at 13:38 +0200, Maxime Ripard wrote: > Hi, > > On Thu, May 30, 2019 at 11:15:10PM +0200, Jernej Skrabec wrote: > > libvdpau-sunxi always disables engine after each decoded slice. > > Do same in Cedrus driver. > > > > Presumably this also lowers power consumption which is always nice. > > > > Signed-off-by: Jernej Skrabec > > Is it fixing anything though? > > I indeed saw that cedar did disable it everytime, but I couldn't find > a reason why. > > Also, the power management improvement would need to be measured, it > can even create the opposite situation where the device will draw more > current from being woken up than if it had just remained disabled. > While reviewing this, I'm noticing that cedrus_engine_disable can be marked for static storage (with or without this patch). Regards, Eze _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel