From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9BD4FC433F5 for ; Thu, 9 Dec 2021 22:36:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/vMUQbBJQvmTCsCoKkGLKY1GSMMhtTPq0vaM8UZbqV0=; b=bR8Qp1EkKecfAT uK4nZlLlcYACPPKb6ncboIIJg+swizSCPyoD8Of4rhz2DG14LQzq3bGjvhVVXj2EEkcg3Qp4YIyAV MQjzCU3KpyrjbWFbwPHRinCn7AnzuhBHRQMh31QkyKNwoU2kMMifDhAoke7jbwAkmQZcnUkiyQrex 15oXV0Cv19jek7bxvstYV99ZQ/C0HJv9YhgOtTe6OBj23nEV+jcUc9hH4F7DlPmaLtJ/pKUt9eVHt YMb356J+EYnEhQ1rJDMFlpj6gK614DkzBldJDkNmCFyfOV5I04mYjDLwsfc26A0nkBuV7djcFvyA3 4f97fab570jspSXnoWkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvS03-000HwZ-Cc; Thu, 09 Dec 2021 22:34:51 +0000 Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvRzy-000HvG-MX; Thu, 09 Dec 2021 22:34:49 +0000 Received: by mail-ed1-x52a.google.com with SMTP id t5so23933941edd.0; Thu, 09 Dec 2021 14:34:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=e0xWu4FRBdpcPopR+tYuIVQgtChl7uURnH22cFlaA5A=; b=fXFqrXO6Mqxbn1VMEeZUPYqwDn0Axi1WQoRKyIm0Wko3qi8To1yhBnzyQBnuuJpvU9 tR9dyu+xSqUrDMvvahFuENMdiHPMXRJ4o4DKWl7ljy3Mz+Nrt/S+gISbeuWgkR+cEOle 5HfXVZsTYOn1456X/asYJBDh/+KY3upkcOeEjnBkupzBDml+tuhSKMfrF3aI5eR2H+9m AxeYoRDcvdBsZd0n9yd/Xbwhp7Eyc1p3mbosWQ4yNA3IyW8kf/9iawYPt5tkAmOak1+/ fGSMnJ7WfE0c7M44ExGyn8D0Cv6BJ1MqLcK9O6mLpBWThWXCeEb72RJR4HaLNOYG3YT4 QWww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=e0xWu4FRBdpcPopR+tYuIVQgtChl7uURnH22cFlaA5A=; b=bpj//FomMipHiu788/0V2DqDTdqGDEjTgE87VFMtWZDJtQZO0BS0qnZZmDvAA3vzKy cYOcPgs4xbLENlMX9udFENOxpKhHvp5uKK3deQgqOw/JpEJEWMuaWvTU4NwcximN1R8I E1s/RB+2nONbQY1kawaUxUM9rMJCBinDt10lGC23wh0zur/PiTjxxpZdbdTMGPRvYjA2 6uD+1LpY5aoNltupzWQEE67D5PUx8pjnhNNZkc9INHDn4qo0Z/Ak+07o3wlJ9qPjkfrA uBD/gMvUo0RmXdLQF2S/9GUU4LQyBmK7XsphBihIjG7uJ5tQwqFDABW9YVp/xcuwNttV b79A== X-Gm-Message-State: AOAM532CsTULlAaEvxqvFqAKvVLuuaJdyMkUZMcDkWbWN9pOB1ngNKFU OmjWgQ+3Pd4DyHJBPMLAAM8= X-Google-Smtp-Source: ABdhPJyxMeAJrbZymRVBb0iPORoJGZau5fLIvkWo7GHCG5UbZ3oj1yMvqn13BjVbdYGJRifVkBRRAw== X-Received: by 2002:a17:906:b2c7:: with SMTP id cf7mr19483296ejb.303.1639089285134; Thu, 09 Dec 2021 14:34:45 -0800 (PST) Received: from ?IPV6:2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e? ([2001:b07:6468:f312:5e2c:eb9a:a8b6:fd3e]) by smtp.googlemail.com with ESMTPSA id go10sm459347ejc.115.2021.12.09.14.34.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 09 Dec 2021 14:34:44 -0800 (PST) Message-ID: <6cb2cd57-16f3-d0ec-adf6-cb8fdcbae035@redhat.com> Date: Thu, 9 Dec 2021 23:34:37 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0 Subject: Re: [PATCH v5 08/12] KVM: Reinstate gfn_to_pfn_cache with invalidation support Content-Language: en-US To: David Woodhouse , kvm Cc: Boris Ostrovsky , Joao Martins , "jmattson @ google . com" , "wanpengli @ tencent . com" , "seanjc @ google . com" , "vkuznets @ redhat . com" , "mtosatti @ redhat . com" , "joro @ 8bytes . org" , karahmed@amazon.com, Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , Will Deacon , Huacai Chen , Aleksandar Markovic , Michael Ellerman , Benjamin Herrenschmidt , Anup Patel , Christian Borntraeger , kvmarm@lists.cs.columbia.edu, linux-arm-kernel , linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-s390@vger.kernel.org, butt3rflyh4ck References: <20211121125451.9489-1-dwmw2@infradead.org> <20211121125451.9489-9-dwmw2@infradead.org> From: Paolo Bonzini In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211209_143446_822801_F120C6E1 X-CRM114-Status: UNSURE ( 8.29 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/9/21 21:40, David Woodhouse wrote: > > NP, very useful fixes. Thanks. Incremental patch looks like this. It > passes the xen_shinfo_test self-test; will test it with real Xen guests > tomorrow and repost based on your kvm/next tree once it shows up. Compared to the review it's missing this hunk: @@ -265,7 +265,7 @@ void kvm_gfn_to_pfn_cache_unmap(struct kvm *kvm, struct gfn_to_pfn_cache *gpc) gpc->valid = false; - old_khva = gpc->khva; + old_khva = (void *)((unsigned long)gpc->khva & ~PAGE_MASK); old_dirty = gpc->dirty; old_gpa = gpc->gpa; old_pfn = gpc->pfn; Otherwise looks good, thanks! Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel