Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Siddharth Vadapalli <s-vadapalli@ti.com>
To: Hari Prasath G E <gehariprasath@ti.com>, "Kumar, Udit" <u-kumar1@ti.com>
Cc: Francesco Dolcini <francesco@dolcini.it>, <nm@ti.com>,
	<vigneshr@ti.com>, <kristo@kernel.org>, <robh@kernel.org>,
	<krzk+dt@kernel.org>, <conor+dt@kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>,
	<s-vadapalli@ti.com>
Subject: Re: [PATCH 2/4] arm64: dts: ti: k3-j7200-common-proc-board: Add ethernet alias
Date: Mon, 7 Sep 2026 10:15:39 +0530	[thread overview]
Message-ID: <6cc21f60-45a9-4342-86e3-5257128b8989@ti.com> (raw)
In-Reply-To: <f849a5f9-e027-4203-a684-1bf15d032a9b@ti.com>

On 06/09/26 20:58, Hari Prasath G E wrote:
> Hello Udit,
> 
> On 9/6/2026 7:34 PM, Kumar, Udit wrote:
>>
>>
>> On 9/6/2026 5:48 PM, Hari Prasath G E wrote:
>>> Hello Udit,
>>>
>>> On 9/6/2026 11:13 AM, Kumar, Udit wrote:
>>>>
>>>>
>>>> On 8/11/2026 11:43 AM, Siddharth Vadapalli wrote:
>>>>> Add the 'ethernet0' alias for the Ethernet interface corresponding to
>>>>> the
>>>>> MCU CPSW2G instance of the CPSW Ethernet Switch on the J7200 Common
>>>>> Processor Board.
>>>>>
>>>>> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
>>>>> ---
>>>>>    arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts | 1 +
>>>>>    1 file changed, 1 insertion(+)
>>>>>
>>>>> diff --git a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts b/
>>>>> arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>>>>> index 54dea36b153b..ac1c1ffe40b7 100644
>>>>> --- a/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>>>>> +++ b/arch/arm64/boot/dts/ti/k3-j7200-common-proc-board.dts
>>>>> @@ -24,6 +24,7 @@ aliases {
>>>>>            serial5 = &main_uart3;
>>>>>            mmc0 = &main_sdhci0;
>>>>>            mmc1 = &main_sdhci1;
>>>>> +        ethernet0 = &cpsw_port1;
>>>>
>>>> Hello Siddharth,
>>>> As default only 1 cpsw port is enabled for all boards in this series.
>>>> So ethernet0 will be cpsw_port1 always, In case you want to enable more
>>>> port in default config then having aliasing will help.
>>>>
>>>> otherwise, you can consider to add aliasing in overlays where you enable
>>>> more than 1 port.
>>>>
>>>
>>> The first patch in the series for k3-am62a7-sk has two ports enabled by
>>> default, so there it's fine to add alias. Also, there are many other TI
>>
>> May be I am missing something, but i don't see two port are enabled for
>> am62a7
>> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/ 
>> arch/arm64/boot/dts/ti/k3-am62a7-sk.dts#n796
>>
>>
> 
> Apologies, I mistakenly looked at the TI vendor kernel where it's enabled 
> on both ports. I think still the below reasoning is valid to take this 
> patch series in. Let's wait for Siddharth to come back with this comments.

Despite the board having a single Ethernet port enabled, there are two 
reasons for this patch/series:
1. For consistency - keeping these boards on-par with the rest of the K3 
boards (some of which also have a single Ethernet port)
2. As Francesco pointed out at:
https://lore.kernel.org/r/20260906153114.GA3576@francesco-nb/
if PCIe-Ethernet Adapters OR even USB-Ethernet Adapters are used (both of 
which are possible on J7200-Common-Processor-Board which has PCIe and USB 
connectors), we need to specify which of them is 'ethernet0'. For NFS 
(Network File System), if 'ethernet0' isn't specified in the device-tree, 
it is possible that the wrong network interface is used by Linux (despite 
eth0 passed in the Kernel Command Line for NFS) with PCIe/USB Ethernet 
Adapters connected to the board.

Regards,
Siddharth.


  reply	other threads:[~2026-09-07  4:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-11  6:13 [PATCH 0/4] Add ethernet aliases for TI K3 Boards Siddharth Vadapalli
2026-08-11  6:13 ` [PATCH 1/4] arm64: dts: ti: k3-am62a7-sk: Add ethernet alias Siddharth Vadapalli
2026-08-11  6:13 ` [PATCH 2/4] arm64: dts: ti: k3-j7200-common-proc-board: " Siddharth Vadapalli
2026-09-06  5:43   ` Kumar, Udit
2026-09-06 12:18     ` Hari Prasath G E
2026-09-06 14:04       ` Kumar, Udit
2026-09-06 15:28         ` Hari Prasath G E
2026-09-07  4:45           ` Siddharth Vadapalli [this message]
2026-09-06 15:31     ` Francesco Dolcini
2026-09-06 17:44       ` Kumar, Udit
2026-08-11  6:13 ` [PATCH 3/4] arm64: dts: ti: k3-j721s2-common-proc-board: " Siddharth Vadapalli
2026-08-11  6:13 ` [PATCH 4/4] arm64: dts: ti: k3-j722s-evm: " Siddharth Vadapalli
2026-09-11 19:52 ` [PATCH 0/4] Add ethernet aliases for TI K3 Boards Nishanth Menon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6cc21f60-45a9-4342-86e3-5257128b8989@ti.com \
    --to=s-vadapalli@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco@dolcini.it \
    --cc=gehariprasath@ti.com \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=robh@kernel.org \
    --cc=srk@ti.com \
    --cc=u-kumar1@ti.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox