From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BC1DEEE645A for ; Fri, 15 Sep 2023 12:34:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/a3k7x2bfHMLDhUYF3mCU7N9+IlWXNTLmiKX2gAMzKc=; b=dFcDxDj3cqbOL2 uKNgrfyi3GTxqM6GL/FndhAzC1EHQ9pcuHkiCHFF4uCqHHYzUpRtZsW830NorsoTPSiT+WPiMJfhf +nsJO8Jk6GrdH4L2ezfhG2IpFOXhG+x78N2yWEFBNQsoS6avOdTErgeacME/2OakmngWbNzJmaxjA WIZfcy36j1hyMpzetz9xrJLi2Eng6/xOfMQOhBQKlqbDFrW9JHlzgyAs/YOcYScwaMkccRGBvorvn TeIgoCEJgpFUT/AJkXh7pSSKQANzzTlcLz06Y21UAHffELOYxTiKZIMxuP6ZbaqauQ7ZFMoWOm7y3 Q//nqH4uKuEJUN4bAM1w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qh819-00AjQT-1a; Fri, 15 Sep 2023 12:33:51 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qh817-00AjOz-0H for linux-arm-kernel@lists.infradead.org; Fri, 15 Sep 2023 12:33:50 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-40476ce8b2fso12207835e9.3 for ; Fri, 15 Sep 2023 05:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1694781224; x=1695386024; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=RUflmh4qQ8B/WFQpBNSKOdW/4uwxczL/Xulw2wdH1lQ=; b=qOFCEnJPpD77s/wDCW3Y7GqrvqMGQq+i8zQGKreCiBrA2P0b7aRIHYgqxtun8rpv7G eRPseJzGR8WhnoVFhR9rKDdbspqHLr5GlahhvYExO+S+GjT5b6JuQIzIcaZkNgdJdmdp Od+wWh46dkWRXTZSAZuTp55KbGwpk0Z5RZR/pIfju2l91J9AxbDx1lyg5tDA/WM3FZkU UAsjj+Z23vRtnj8venb1YenZgtlE6BtJqJr5EafImPSWidr8ygE6JVw/69SVpd6zVaN+ KWchMJRs8KbJuP4CSK8hx9Eyxj7H+bvhNYZOWI9wiLs++BeEYXjexwgWlnZ0T+JcfEHV SeIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694781224; x=1695386024; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=RUflmh4qQ8B/WFQpBNSKOdW/4uwxczL/Xulw2wdH1lQ=; b=KknoH1rTr1lG+bn3gvBQ+7pDU6Jdl7OZBMzlKQAXAOrLZN32loT+BBMYzthMGU5BJs 2j/X5JU3KE96FfGrBwnCeXQ3J/WzLCIYtiqwWQpVn3ZdSMP8zr1wA5LMzwoDOn84KDkD LVTV1GCImmg7Y7h0sCtkZ6dzYNRODSggJZmyViSNjtpCMG8mAxV9C/l6igouQrBXm22o mos6uH//McZdL6TJ4vd8WhxEz4ZTuaaoz6zCImsd6aAQ4C+QqCeS4SBJau2TXWPLlNl1 2G6EsaDxg0ZDrIeahEMm01lrF/9JfV41AvkVahd7g0HD/LnEAy+UVN/4zKHVLe5me5ZU XaRQ== X-Gm-Message-State: AOJu0Yw2w0XfG+flZ6BNZc2Ou4HRyKPZROws0lDEaR6SoWElZj0cEytn j047amxkrrxGG9UArUKOj/1Y8w== X-Google-Smtp-Source: AGHT+IEXJxeuznECg/KVhjt1QvjvR2Tw2XeeiZ/7QRi2IaCLCcMSwSMos+je8/bQAc+71y5qesI2Uw== X-Received: by 2002:a05:600c:364f:b0:400:2dc5:2006 with SMTP id y15-20020a05600c364f00b004002dc52006mr1448236wmq.36.1694781223461; Fri, 15 Sep 2023 05:33:43 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id x13-20020a1c7c0d000000b003fc0505be19sm4491795wmc.37.2023.09.15.05.33.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 15 Sep 2023 05:33:43 -0700 (PDT) Date: Fri, 15 Sep 2023 15:33:40 +0300 From: Dan Carpenter To: Ma Ke Cc: mripard@kernel.org, paul.kocialkowski@bootlin.com, mchehab@kernel.org, gregkh@linuxfoundation.org, wens@csie.org, jernej.skrabec@gmail.com, samuel@sholland.org, linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev Subject: Re: [PATCH] media: cedrus: fix use after free bug in cedrus_remove due to race condition Message-ID: <6ccc8fb2-4bd9-4df5-afe2-17868c4023f6@kadam.mountain> References: <20230915114038.3407953-1-make_ruc2021@163.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230915114038.3407953-1-make_ruc2021@163.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230915_053349_127627_9D5BE810 X-CRM114-Status: UNSURE ( 8.79 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org No, the code is okay. The works is created in probe() and canceled in remove(). You've added a new cancel in release() which is the wrong place. probe() pairs with remove(). open() pairs with release(). regards, dan carpenter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel