From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 555CAC61DF7 for ; Thu, 23 Nov 2023 14:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1c+KCb8UT2JhWf+rrQw5WSPhyHxrUG1P9GTmJvxVFhs=; b=QpwBY6bUXSuVVyYZCyiGNtKTv8 jWHbcS8T6PSbPRUWRQti3aCUdDVPkG0JCaQh85e0Ypzqw+khqZjNHyqlqUd4gcoAXLOL3PW5PjqNR EoZoe6KDJt+b2j/urjsgLw7wuTJcl1Ih3KYrfolJ/zASt8Nv6BxiKUQ0Air2xN5Ejb5pyZxPU1HQ4 SYORKcFRDqyJjzo/+ddHA/9EO18ce8psKr91NlHjnRANzAyX5TWDp5EIqeZgbRG5uOMoyM5xa3hi5 vBz/WMo9/MYfTnnstrOdwVptxC+XOdi8gOy83Ao1yGTUt2Zq+hkDDiTgnmH4u+tmAUMKJ6IXeGwN4 oGFCeeUA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r6AlI-0051jL-2C; Thu, 23 Nov 2023 14:33:00 +0000 Received: from szxga01-in.huawei.com ([45.249.212.187]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r6AlF-0051h4-1e for linux-arm-kernel@lists.infradead.org; Thu, 23 Nov 2023 14:32:59 +0000 Received: from dggpemm500002.china.huawei.com (unknown [172.30.72.56]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4SbgV61xj0zsR57; Thu, 23 Nov 2023 22:29:18 +0800 (CST) Received: from [10.174.178.247] (10.174.178.247) by dggpemm500002.china.huawei.com (7.185.36.229) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Thu, 23 Nov 2023 22:32:48 +0800 Subject: Re: [Patch v7] ACPI: processor: reduce CPUFREQ thermal reduction pctg for Tegra241 To: Sudeep Holla , Sumit Gupta CC: , , , , , , , , , , , , , , References: <20231123121433.12089-1-sumitg@nvidia.com> From: Hanjun Guo Message-ID: <6ccd1598-3c8b-1290-9494-01a3cdbb3003@huawei.com> Date: Thu, 23 Nov 2023 22:32:48 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Language: en-GB X-Originating-IP: [10.174.178.247] X-ClientProxiedBy: dggems702-chm.china.huawei.com (10.3.19.179) To dggpemm500002.china.huawei.com (7.185.36.229) X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231123_063257_771311_84348108 X-CRM114-Status: GOOD ( 18.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2023/11/23 22:00, Sudeep Holla wrote: > On Thu, Nov 23, 2023 at 05:44:33PM +0530, Sumit Gupta wrote: >> From: Srikar Srimath Tirumala >> >> Current implementation of processor_thermal performs software throttling >> in fixed steps of "20%" which can be too coarse for some platforms. >> We observed some performance gain after reducing the throttle percentage. >> Change the CPUFREQ thermal reduction percentage and maximum thermal steps >> to be configurable. Also, update the default values of both for Nvidia >> Tegra241 (Grace) SoC. The thermal reduction percentage is reduced to "5%" >> and accordingly the maximum number of thermal steps are increased as they >> are derived from the reduction percentage. >> >> Signed-off-by: Srikar Srimath Tirumala >> Co-developed-by: Sumit Gupta >> Signed-off-by: Sumit Gupta >> --- >> >> Sending this patch separately as the other patch in the series is >> applied by Rafael in v6[1]. Revision history before this version is >> in the cover letter of v6[1]. >> >> Please review and provide ACK if looks fine. >> > > For arm64 specific changes(a minor nit below though), > > Acked-by: Sudeep Holla > > > [...] > >> diff --git a/drivers/acpi/arm64/thermal_cpufreq.c b/drivers/acpi/arm64/thermal_cpufreq.c >> new file mode 100644 >> index 000000000000..d524f2cd6044 >> --- /dev/null >> +++ b/drivers/acpi/arm64/thermal_cpufreq.c >> @@ -0,0 +1,20 @@ >> +// SPDX-License-Identifier: GPL-2.0-only >> +#include >> + >> +#include "../internal.h" >> + >> +#define SMCCC_SOC_ID_T241 0x036b0241 >> + > > [nit] We really need to find better place to define this globally and not > locally at each usage site like this. We already have it in GICv3 driver. > But that can come as a cleanup later if it causes issue for merging this > change. Agreed. Looks good to me as well. Acked-by: Hanjun Guo Thanks Hanjun _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel