From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A883C433DB for ; Fri, 22 Jan 2021 13:25:01 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5D2A323437 for ; Fri, 22 Jan 2021 13:25:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5D2A323437 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G34GRHDtijaXpVAYeHinf32GyRUWaDr55uHYa0lqWgg=; b=gok/3Gqv6KqcUQ0BWmndSI7XS gY+Ix0QxAouXLSYzPrBl+FmXD3jU++Hf8DKacRgIZKuciw+J5VBBnq8nJuxZ6vGSA+NRoo1u2mlO7 NpOZHPIhLT2zc78swOsUhd96TOT1+hMnLU+ohkoSkNn3mjS1WY7YikGhq/s0O9sth5ckmtYhwpf39 C8nlNnRDwMb5nq3sr5DdjdRysWxt5VGNGrlpcl7WvSNzRmsOswdDLLruYAb7M2MI0MbCzN4jVdNUl glRDxU4e2keLglq+Xj3PCXw5FmYrAUnFqFyRkYsjr8A9UcVACWmvbc3ReCO7eB92ZFKWdhMwsjJcQ 0PgAZYzLg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2wPT-0004SO-8h; Fri, 22 Jan 2021 13:23:31 +0000 Received: from foss.arm.com ([217.140.110.172]) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l2wPR-0004Rg-0i for linux-arm-kernel@lists.infradead.org; Fri, 22 Jan 2021 13:23:29 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4320711B3; Fri, 22 Jan 2021 05:23:27 -0800 (PST) Received: from [10.37.8.28] (unknown [10.37.8.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DA7743F66E; Fri, 22 Jan 2021 05:23:24 -0800 (PST) Subject: Re: [PATCH v5 3/6] kasan: Add report for async mode To: Catalin Marinas References: <20210121163943.9889-1-vincenzo.frascino@arm.com> <20210121163943.9889-4-vincenzo.frascino@arm.com> <20210122131933.GD8567@gaia> From: Vincenzo Frascino Message-ID: <6ccde9db-98cd-5a56-b93d-0b79f4df56a7@arm.com> Date: Fri, 22 Jan 2021 13:27:15 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210122131933.GD8567@gaia> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210122_082329_102486_FE303394 X-CRM114-Status: GOOD ( 20.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Branislav Rankov , Marco Elver , Andrey Konovalov , Evgenii Stepanov , linux-kernel@vger.kernel.org, kasan-dev@googlegroups.com, Alexander Potapenko , linux-arm-kernel@lists.infradead.org, Andrey Ryabinin , Will Deacon , Dmitry Vyukov Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/22/21 1:19 PM, Catalin Marinas wrote: > On Thu, Jan 21, 2021 at 04:39:40PM +0000, Vincenzo Frascino wrote: >> diff --git a/include/linux/kasan.h b/include/linux/kasan.h >> index bb862d1f0e15..b0a1d9dfa85c 100644 >> --- a/include/linux/kasan.h >> +++ b/include/linux/kasan.h >> @@ -351,6 +351,8 @@ static inline void *kasan_reset_tag(const void *addr) >> bool kasan_report(unsigned long addr, size_t size, >> bool is_write, unsigned long ip); >> >> +void kasan_report_async(void); >> + >> #else /* CONFIG_KASAN_SW_TAGS || CONFIG_KASAN_HW_TAGS */ >> >> static inline void *kasan_reset_tag(const void *addr) >> diff --git a/mm/kasan/report.c b/mm/kasan/report.c >> index 234f35a84f19..2fd6845a95e9 100644 >> --- a/mm/kasan/report.c >> +++ b/mm/kasan/report.c >> @@ -358,6 +358,17 @@ void kasan_report_invalid_free(void *object, unsigned long ip) >> end_report(&flags); >> } >> >> +void kasan_report_async(void) >> +{ >> + unsigned long flags; >> + >> + start_report(&flags); >> + pr_err("BUG: KASAN: invalid-access\n"); >> + pr_err("Asynchronous mode enabled: no access details available\n"); >> + dump_stack(); >> + end_report(&flags); >> +} > > I think the kernel test robot complains that with KASAN_SW_TAGS and > HW_TAGS disabled, the kasan_report_async() prototype is no longer > visible but you still have the non-static function definition here. So > either move kasan_report_async() out of this #ifdef or add the #ifdef > around the function definition. > I think adding #ifdef around the function would be the best way in this case, for consistency with the header. > It looks like the original kasan_report() prototype is declared in two > places (second one in mm/kasan/kasan.h). I'd remove the latter and try > to have a consistent approach for kasan_report() and > kasan_report_async(). > Ok, I will remove it. -- Regards, Vincenzo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel