From: yixun.lan@amlogic.com (Yixun Lan)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] spi: meson-axg: support MAX 80M clock
Date: Fri, 4 May 2018 09:56:10 +0800 [thread overview]
Message-ID: <6cdee2c8-2ca4-2efb-43ac-c233516c0570@amlogic.com> (raw)
In-Reply-To: <20180503231305.GC13402@sirena.org.uk>
Hi Mark
On 05/04/18 07:13, Mark Brown wrote:
> On Thu, May 03, 2018 at 09:36:42PM +0000, Yixun Lan wrote:
>
>> static const struct of_device_id meson_spicc_of_match[] = {
>> - { .compatible = "amlogic,meson-gx-spicc", },
>> - { .compatible = "amlogic,meson-axg-spicc", },
>> + {
>> + .compatible = "amlogic,meson-gx-spicc",
>> + .data = &meson_spicc_gx_data,
>> + },
>> + {
>> + .compatible = "amlogic,meson-axg-spicc",
>> + .data = &meson_spicc_axg_data,
>> + },
>> { /* sentinel */ }
>> };
>> MODULE_DEVICE_TABLE(of, meson_spicc_of_match);
>
> This is changing the DT bindings but there's no update to the DT binding
> documentation, please add an update there.
>
thanks for your comments, but I actually didn't get what's your point here.
Here I only introduce the dt compatible data to differentiate the
old/new controller, the compatible name is not changed, and none of the
property is introduced.
Yixun
next prev parent reply other threads:[~2018-05-04 1:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 21:36 [PATCH 0/3] spi: meson-axg: add few enhanced features Yixun Lan
2018-05-03 21:36 ` [PATCH 1/3] spi: meson-axg: support MAX 80M clock Yixun Lan
2018-05-03 23:13 ` Mark Brown
2018-05-04 1:56 ` Yixun Lan [this message]
2018-05-05 0:58 ` Mark Brown
2018-05-03 21:36 ` [PATCH 2/3] spi: meson-axg: enhance output enable feature Yixun Lan
2018-05-03 21:36 ` [PATCH 3/3] spi: meson-axg: add a linear clock divider support Yixun Lan
2018-05-03 23:16 ` Mark Brown
2018-05-04 2:07 ` Yixun Lan
2018-05-04 2:22 ` kbuild test robot
2018-05-04 2:46 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cdee2c8-2ca4-2efb-43ac-c233516c0570@amlogic.com \
--to=yixun.lan@amlogic.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox