From: Flavio Suligoi <f.suligoi@asem.it>
To: Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
"Robert Jarzmik" <robert.jarzmik@free.fr>,
Mark Brown <broonie@kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-spi@vger.kernel.org" <linux-spi@vger.kernel.org>
Subject: RE: [PATCH 1/1] spi: pxa2xx: add driver enabling message
Date: Tue, 9 Apr 2019 14:11:49 +0000 [thread overview]
Message-ID: <6cef52a73fb547bb9c0dd84efca8f7f8@asem.it> (raw)
In-Reply-To: <51e9e073-625d-f5c0-6b2e-410f6ddb6346@linux.intel.com>
Hi Jarkko,
> Hi
>
> On 4/8/19 6:22 PM, Flavio Suligoi wrote:
> > Add an info message for the PXA2xx device driver start-up,
> > with the indication of the transfer mode used (DMA or GPIO).
> >
> > This info is useful to individuate the timing when
> > the module starts.
> >
> > Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> > ---
> > drivers/spi/spi-pxa2xx.c | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/spi/spi-pxa2xx.c b/drivers/spi/spi-pxa2xx.c
> > index f7068cc..d449501 100644
> > --- a/drivers/spi/spi-pxa2xx.c
> > +++ b/drivers/spi/spi-pxa2xx.c
> > @@ -1826,6 +1826,9 @@ static int pxa2xx_spi_probe(struct platform_device
> *pdev)
> > goto out_error_clock_enabled;
> > }
> >
> > + dev_info(dev, "PXA2xx SPI master controller (%s mode)\n",
> > + platform_info->enable_dma ? "DMA" : "PIO");
> > +
> > return status;
> >
> Would this look better if moved before devm_spi_register_controller()
> call?
Ok, so in case of SPI registering failure, we have two messages, as:
pxa2xx-spi 80860F0E:00: PXA2xx SPI master controller (DMA mode)
pxa2xx-spi 80860F0E:00: problem registering spi controller
Do you think that it is more explicative?
Flavio
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-09 14:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 15:22 [PATCH 1/1] spi: pxa2xx: add driver enabling message Flavio Suligoi
2019-04-09 13:48 ` Jarkko Nikula
2019-04-09 14:11 ` Flavio Suligoi [this message]
2019-04-10 7:55 ` Jarkko Nikula
2019-04-10 8:13 ` Flavio Suligoi
2019-04-10 8:29 ` Jarkko Nikula
2019-04-10 8:47 ` Flavio Suligoi
2019-04-10 9:47 ` [PATCH v2 " Flavio Suligoi
2019-04-10 10:11 ` Jarkko Nikula
2019-04-10 10:16 ` Flavio Suligoi
2019-04-10 10:32 ` [PATCH " Mark Brown
2019-04-10 11:47 ` Flavio Suligoi
2019-04-10 11:54 ` Mark Brown
2019-04-10 12:01 ` Flavio Suligoi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cef52a73fb547bb9c0dd84efca8f7f8@asem.it \
--to=f.suligoi@asem.it \
--cc=broonie@kernel.org \
--cc=daniel@zonque.org \
--cc=haojian.zhuang@gmail.com \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).