From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8A41F60A2617 for ; Mon, 26 Oct 2026 19:17:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=WdBcgdpO; dkim=pass (1024-bit key, unprotected) header.d=broadcom.com header.i=@broadcom.com header.a=rsa-sha256 header.s=google header.b=M/p5jByl DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Unsubscribe-Post: List-Owner; bh=BdfLZ3+TQnhk/1R/dKHjB/gyQ9lcXQ2fJWw3eaIlqVQ=; b=WdBcgdpOoOjD36 2yE2OeoaY1kLzPLd0jhLe5O4BiJ1pemtDuJZ5e3VJc0OpaGRB/uwlZm/zaYUGQ4eW4tO+zKHZ4Y1N qwNtO5ouGX2sAZ2MLWbyoY7wul1aFPExpfvKoeTT7jplK52gLXxDHl56GS3tCPHKQaidAZtgV6N+X hBrC6e3WwyKP4jSU86GMyndjxj1or8lUsD/0y0xDzSzh5MlAlSmmGT8BvP35KIcp0a+RyeGzeaXbL wLL78lStce3RXmQJaNenYS5P+jFxWYGonoP/ffAH+FslBrcLlv4StMiE+D23n3qfYmhntW6woDtUh /HydeqZb8/gBAhbwiTXA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLQC8-000000039FM-05tF; Mon, 26 Oct 2026 19:17:20 +0000 Received: from mail-pl1-x663.google.com ([2607:f8b0:4864:20::663]) by bombadil.infradead.org with esmtps (Exim 4.100.1 #2 (Red Hat Linux)) id 1xLQC4-000000039EV-4Arh for linux-arm-kernel@lists.infradead.org; Mon, 26 Oct 2026 19:17:18 +0000 Received: by mail-pl1-x663.google.com with SMTP id d9443c01a7336-2e9d1114320so25767625ad.3 for ; Mon, 26 Oct 2026 12:17:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1793042236; x=1793647036; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:dkim-signature:x-gm-gg:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to:content-type; bh=BdfLZ3+TQnhk/1R/dKHjB/gyQ9lcXQ2fJWw3eaIlqVQ=; b=LXmU4VpX4tugPkdmYHPDTPMs8XjAPJ6PuFE3MboH4JRymqCFcYQnsGCDvrFo9YFasy 8kG+Gn+ETcO2222xFSt+zbkFLWX/4g1dXbWEHqqHhuyNFZ63pMtyX5WdSPj4mngq5vGH wI0A2v/vRK5kjkZgPvRdrT0kwUVLeEryj+J2ChMKkSnwj3AbUXXgYz3ZTglxFQGFfota 7Td4W1Y/YLpwm1sOIFJOVyXDaLrb8rQd6RLnPgtZIPv2IvcnlzstX3VGaxVXsZjFjJ6F EnUdg+t8dZJUqH1Fi9xnRSpx4pJsUJY2hlNQltdoVTUplEmGTqJakkAM8WE4RcT8ky5L UAlA== X-Forwarded-Encrypted: i=1; AKwUvBz4r5VtvFrSqnylktx0E8UukXG3vtqsmHCdw9bqhTxlPH2bCveXQgBzD+91Lzfj9O4SM8I574Z+z6CMyLzbH4vf@lists.infradead.org X-Gm-Message-State: AFq9FYJ4zvTTzWBzkiTRiucMws3gL1+UXenHFRnuRxi56svpRfVaND+b gpnrBB2fsPmDKOOLLINQ+zCiuy1xkSUXC0ZnVUog+r5eyKPsV9loPiipRDpM5Naz9lx8Z8ykJZp OjiRllV8LKWhjjsUgu35V87VkikuHY4mDuV4NkKC2ZQKfyfNqbNYZjUt01/T6qj8gopH4pmFLbr Smm0fcVmfYG4bHbdcWsnWaP0wqlJzJx0Z9ieFjtjrzA6q0tGG46tcdyGeS+3ReacnID0hGRz/mH 50VVxk5y99OFVj4Ljz31poRiJnRxYMrRVSL/Q== X-Gm-Gg: AYBFou3443/GiTF+khBqib0oGvZk/KbxuFDMQLKpVRjO8uzKDGcw/ARdy6MUgxyjsxi 9/b7eQE45bjD1fsLeHI2CdtFEEPsUAvbv053JyCP8aobB0P0IcPMRbWsWzjcthJ9Bm8d2d+1HwP BUpsqDX4CsMpup11sHX4pxdSnP5ktwsOZoiXJt/MZiL+2zuMC5XPugLZJ5xpTWrvVpwkFvcdq0b xR86n59RqU4XvwImFKYppTSsYvJ6VQI82u+VctNCqIeADCF7Vd2M087DIwCRmiZbJPnBiQrEahF 78Kjt5iw1t7Pw10tdKmmvN1WDRTTiZ1Oz4lmuEd8KYmInwd7NIGXKhhmDdt5C45Y3aHJOyOl1+C gZuHnVNxUyfhMuEaMLZcRRNIDbomcpMTwHUqZxtTQ2A6u6oD7EhOnT4SOAS51Mf7VBOl1Stbzxh bAmi/z0edStH/jrgouSEEkTSsm8QST6HRclitl53pl5Lk= X-Received: by 2002:a17:90b:6c7:b0:3ac:9d26:551d with SMTP id 98e67ed59e1d1-3adeb10f4cfmr6378980a91.50.1793042235993; Mon, 26 Oct 2026 12:17:15 -0700 (PDT) Received: from smtp-us-east1-p01-i01-si01.dlp.protect.broadcom.com (address-144-49-247-120.dlp.protect.broadcom.com. [144.49.247.120]) by smtp-relay.gmail.com with ESMTPS id 98e67ed59e1d1-3adebaddeddsm3140656a91.2.2026.10.26.12.17.15 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 26 Oct 2026 12:17:15 -0700 (PDT) X-Relaying-Domain: broadcom.com X-CFilter-Loop: Reflected Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-91785bd637bso83229626d6.1 for ; Mon, 26 Oct 2026 12:17:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1793042235; x=1793647035; darn=lists.infradead.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=BdfLZ3+TQnhk/1R/dKHjB/gyQ9lcXQ2fJWw3eaIlqVQ=; b=M/p5jBylHgQbmrOp0HKU/IjBa7edmfxEwVXWiryXTcjrBeQaRvbo08duUW/698jRGv QUzNl2FkJj5lbycEq/eA8HtF45omYeqrwErIpfGNc4E3d9dVs2/q8dpIu1r7gq6sAm23 Fip5Plbaj5vtkGc8VbPg6kQGXxoHZzzZRVE3E= X-Forwarded-Encrypted: i=1; AKwUvBzvGwoPkAknlNnEMCja6HreCkWl3sq4ox3rDyTdI0GYI1yyh1oJ/ulPll3lJ5ubOrRHVocws9boHt6a9T+kN5+g@lists.infradead.org X-Received: by 2002:a05:6214:2602:b0:91b:83b7:b9c3 with SMTP id 6a1803df08f44-91c48cefde5mr132808576d6.5.1793042234793; Mon, 26 Oct 2026 12:17:14 -0700 (PDT) X-Received: by 2002:a05:6214:2602:b0:91b:83b7:b9c3 with SMTP id 6a1803df08f44-91c48cefde5mr132806056d6.5.1793042232303; Mon, 26 Oct 2026 12:17:12 -0700 (PDT) Received: from [10.67.48.245] ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-91c47ce49d9sm80619336d6.45.2026.10.26.12.17.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2026 12:17:11 -0700 (PDT) Message-ID: <6cf34238-ed4e-477c-938f-f5d6910fda1d@broadcom.com> Date: Mon, 26 Oct 2026 12:17:08 -0700 X-Archived-By: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/6] ata: ahci_brcm: Initialize the NSP interface clock and reset To: linux-kernel@vger.kernel.org Cc: Damien Le Moal , Niklas Cassel , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Ray Jui , Scott Branden , Broadcom internal kernel review list , Vinod Koul , Neil Armstrong , Manivannan Sadhasivam , Kishon Vijay Abraham I , Tejun Heo , Yendapally Reddy Dhananjaya Reddy , "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "moderated list:BROADCOM IPROC ARM ARCHITECTURE" , "open list:GENERIC PHY FRAMEWORK" References: <20261026182856.3168686-1-florian.fainelli@broadcom.com> <20261026182856.3168686-4-florian.fainelli@broadcom.com> Content-Language: en-US, fr-FR From: Florian Fainelli Autocrypt: addr=florian.fainelli@broadcom.com; keydata= xsBNBFPAG8ABCAC3EO02urEwipgbUNJ1r6oI2Vr/+uE389lSEShN2PmL3MVnzhViSAtrYxeT M0Txqn1tOWoIc4QUl6Ggqf5KP6FoRkCrgMMTnUAINsINYXK+3OLe7HjP10h2jDRX4Ajs4Ghs JrZOBru6rH0YrgAhr6O5gG7NE1jhly+EsOa2MpwOiXO4DE/YKZGuVe6Bh87WqmILs9KvnNrQ PcycQnYKTVpqE95d4M824M5cuRB6D1GrYovCsjA9uxo22kPdOoQRAu5gBBn3AdtALFyQj9DQ KQuc39/i/Kt6XLZ/RsBc6qLs+p+JnEuPJngTSfWvzGjpx0nkwCMi4yBb+xk7Hki4kEslABEB AAHNMEZsb3JpYW4gRmFpbmVsbGkgPGZsb3JpYW4uZmFpbmVsbGlAYnJvYWRjb20uY29tPsLB IQQQAQgAywUCZWl41AUJI+Jo+hcKAAG/SMv+fS3xUQWa0NryPuoRGjsA3SAUAAAAAAAWAAFr ZXktdXNhZ2UtbWFza0BwZ3AuY29tjDAUgAAAAAAgAAdwcmVmZXJyZWQtZW1haWwtZW5jb2Rp bmdAcGdwLmNvbXBncG1pbWUICwkIBwMCAQoFF4AAAAAZGGxkYXA6Ly9rZXlzLmJyb2FkY29t Lm5ldAUbAwAAAAMWAgEFHgEAAAAEFQgJChYhBNXZKpfnkVze1+R8aIExtcQpvGagAAoJEIEx tcQpvGagWPEH/2l0DNr9QkTwJUxOoP9wgHfmVhqc0ZlDsBFv91I3BbhGKI5UATbipKNqG13Z TsBrJHcrnCqnTRS+8n9/myOF0ng2A4YT0EJnayzHugXm+hrkO5O9UEPJ8a+0553VqyoFhHqA zjxj8fUu1px5cbb4R9G4UAySqyeLLeqnYLCKb4+GklGSBGsLMYvLmIDNYlkhMdnnzsSUAS61 WJYW6jjnzMwuKJ0ZHv7xZvSHyhIsFRiYiEs44kiYjbUUMcXor/uLEuTIazGrE3MahuGdjpT2 IOjoMiTsbMc0yfhHp6G/2E769oDXMVxCCbMVpA+LUtVIQEA+8Zr6mX0Yk4nDS7OiBlvOwE0E U8AbwQEIAKxr71oqe+0+MYCc7WafWEcpQHFUwvYLcdBoOnmJPxDwDRpvU5LhqSPvk/yJdh9k 4xUDQu3rm1qIW2I9Puk5n/Jz/lZsqGw8T13DKyu8eMcvaA/irm9lX9El27DPHy/0qsxmxVmU pu9y9S+BmaMb2CM9IuyxMWEl9ruWFS2jAWh/R8CrdnL6+zLk60R7XGzmSJqF09vYNlJ6Bdbs MWDXkYWWP5Ub1ZJGNJQ4qT7g8IN0qXxzLQsmz6tbgLMEHYBGx80bBF8AkdThd6SLhreCN7Uh IR/5NXGqotAZao2xlDpJLuOMQtoH9WVNuuxQQZHVd8if+yp6yRJ5DAmIUt5CCPcAEQEAAcLB gQQYAQIBKwUCU8AbwgUbDAAAAMBdIAQZAQgABgUCU8AbwQAKCRCTYAaomC8PVQ0VCACWk3n+ obFABEp5Rg6Qvspi9kWXcwCcfZV41OIYWhXMoc57ssjCand5noZi8bKg0bxw4qsg+9cNgZ3P N/DFWcNKcAT3Z2/4fTnJqdJS//YcEhlr8uGs+ZWFcqAPbteFCM4dGDRruo69IrHfyyQGx16s CcFlrN8vD066RKevFepb/ml7eYEdN5SRALyEdQMKeCSf3mectdoECEqdF/MWpfWIYQ1hEfdm C2Kztm+h3Nkt9ZQLqc3wsPJZmbD9T0c9Rphfypgw/SfTf2/CHoYVkKqwUIzI59itl5Lze+R5 wDByhWHx2Ud2R7SudmT9XK1e0x7W7a5z11Q6vrzuED5nQvkhAAoJEIExtcQpvGagugcIAJd5 EYe6KM6Y6RvI6TvHp+QgbU5dxvjqSiSvam0Ms3QrLidCtantcGT2Wz/2PlbZqkoJxMQc40rb fXa4xQSvJYj0GWpadrDJUvUu3LEsunDCxdWrmbmwGRKqZraV2oG7YEddmDqOe0Xm/NxeSobc MIlnaE6V0U8f5zNHB7Y46yJjjYT/Ds1TJo3pvwevDWPvv6rdBeV07D9s43frUS6xYd1uFxHC 7dZYWJjZmyUf5evr1W1gCgwLXG0PEi9n3qmz1lelQ8lSocmvxBKtMbX/OKhAfuP/iIwnTsww 95A2SaPiQZA51NywV8OFgsN0ITl2PlZ4Tp9hHERDe6nQCsNI/Us= In-Reply-To: <20261026182856.3168686-4-florian.fainelli@broadcom.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-DetectorID-Processed: b00c1d49-9d2e-4205-b15f-d015386d3d5e X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.9.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20261026_121717_035311_D228DF4E X-CRM114-Status: GOOD ( 11.73 ) X-Spam-Score: -2.4 (--) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" X-Spam-Status: No, score=-12.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 On 10/26/26 11:28, Florian Fainelli wrote: > The NSP probe path assumes firmware has enabled the SATA IDM interface > clock and released the core reset. The downstream iProc config_AHCI() > sequence explicitly performs both operations before accessing AHCI. > Without that setup, a cold boot can access an inactive controller. > > Map the optional NSP IDM register region and enable the interface clock > before releasing reset, retaining the downstream settling intervals. > Perform the sequence at probe and resume before reconfiguring SATA. > > Keep the resource optional so older device trees continue to rely on > firmware initialization. > > Fixes: 3ee2e6dcaa35 ("ata: ahci_brcm: Add support for Broadcom NSP SoC") > Signed-off-by: Florian Fainelli Apologies, this is the same as v1, I will resubmit in a short while. -- Florian