From: Hans de Goede <johannes.goede@oss.qualcomm.com>
To: Sudeep Holla <sudeep.holla@kernel.org>
Cc: Bjorn Andersson <andersson@kernel.org>,
Cristian Marussi <cristian.marussi@arm.com>,
Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
Frank.Li@kernel.org, arm-scmi@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, imx@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 3/4] firmware: arm_scmi: Fix scmi_protocol_device_unrequest() race
Date: Fri, 18 Sep 2026 11:26:36 +0200 [thread overview]
Message-ID: <6d103565-42aa-4f02-91b8-bc7598830c8c@oss.qualcomm.com> (raw)
In-Reply-To: <20260915-messy-imposing-frog-ea9338@sudeepholla>
Hi,
On 15-Sep-26 16:21, Sudeep Holla wrote:
> On Fri, Sep 11, 2026 at 05:23:28PM +0200, Hans de Goede wrote:
>> scmi_protocol_device_unrequest() unlocks scmi_requested_devices_mtx during
>> the notifier call. During this window phead might have been deleted by
>> another racing scmi_protocol_device_unrequest().
>>
>> Re-acquire phead before cleaning it up to avoid this potential double
>> free problem.
>>
>
> Does the below address this issue already ?
> Commit 2c4097e6c4ae ("firmware: arm_scmi: Fix requested device removal race")
Yes, the v6 series was based on v7.2 which did not have this yet.
I'll drop this for the upcoming v7.
Regards,
Hans
next prev parent reply other threads:[~2026-09-18 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-11 15:23 [PATCH v6 0/4] firmware: arm_scmi: fix module auto-loading Hans de Goede
2026-09-11 15:23 ` [PATCH v6 1/4] module: add SCMI device table alias support Hans de Goede
2026-09-11 15:23 ` [PATCH v6 2/4] firmware: arm_scmi: Fix scmi_protocol_table_register() error handling Hans de Goede
2026-09-12 20:50 ` Abel Vesa
2026-09-12 20:57 ` Hans de Goede
2026-09-11 15:23 ` [PATCH v6 3/4] firmware: arm_scmi: Fix scmi_protocol_device_unrequest() race Hans de Goede
2026-09-15 14:21 ` Sudeep Holla
2026-09-18 9:26 ` Hans de Goede [this message]
2026-09-11 15:23 ` [PATCH v6 4/4] firmware: arm_scmi: Always create devices for standard protocols Hans de Goede
2026-09-15 14:24 ` [PATCH v6 0/4] firmware: arm_scmi: fix module auto-loading Sudeep Holla
2026-09-18 9:30 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d103565-42aa-4f02-91b8-bc7598830c8c@oss.qualcomm.com \
--to=johannes.goede@oss.qualcomm.com \
--cc=Frank.Li@kernel.org \
--cc=andersson@kernel.org \
--cc=arm-scmi@vger.kernel.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=cristian.marussi@arm.com \
--cc=daniel.lezcano@oss.qualcomm.com \
--cc=imx@lists.linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sudeep.holla@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox