From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4B152C2BD09 for ; Tue, 9 Jul 2024 12:06:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To: Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=W6jRhWKuXlde166zspa2DUKgr2wUg6dCIlif5oG61AY=; b=i1gUCUKnTd03/ITUSnL35z6fWg W59mcUBjyTkPxzDWuZUo3oC1bjzS7gca0trzPQ1XWbQKB3tLNzWdr1+7iinNmmkzz8upR+AXS6jV3 LwT8UgpyGkcCFqE2kvxiEEEdqJEKBJoq/f+9xxf2ew8grlvtmgtzByMeu1VvRZKbc/bvOWDMJrgWJ AoapowkJFm4cc2pbbf2kryRQ0PW64HTgCj8/9T+18GewXJNc66ItfDbEDKVNojdIuUbblHGpCQvDZ YJxv0LugPU4+wvWwGat0TT3EWgoqdocz+k0FJwJz442KnEdOgfo+N4A/2h8dFJdwPt7i6jDTK80VR N3pTE8kw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR9bq-000000074Vo-2RlL; Tue, 09 Jul 2024 12:06:14 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR9ba-000000074Sa-3qCr for linux-arm-kernel@bombadil.infradead.org; Tue, 09 Jul 2024 12:05:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:MIME-Version:Date:Message-ID:From:Cc:References:To:Subject: Sender:Reply-To:Content-ID:Content-Description; bh=W6jRhWKuXlde166zspa2DUKgr2wUg6dCIlif5oG61AY=; b=gjpSQdfxtPw8DXmvg15ssBymVp MqVNQHIwBuXzd1/qKZFiwLrzQEl8TUMfRZNgL1uAdXrP57PXvXwCXsy30k2bmg/uABtfJIwohv+pg 8dnMeQi9dL8MeKeLJdqrTB+T6P3gOA6xxCgfUCJcc+G079shHwtU1cmvFmuYI2dkT5insJVQJ8b4K 1Ru5ST1a56izlAgdgBHW3uUkIJRUkX8w8q1UHLdLcysWdUTre6s6jPgm1CIZSYjsTFCXXAWiAgzIT FoOmt/FvRDCsJ1wbYR/jUCvJD0MXdDxWJmhSrrs/F2RsRQ6JmdhWqFQLEHGe+rSiBZCbEEWC6VJeu ogEeP7ug==; Received: from mail.loongson.cn ([114.242.206.163]) by desiato.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sR9bV-00000000kLI-3QYA for linux-arm-kernel@lists.infradead.org; Tue, 09 Jul 2024 12:05:56 +0000 Received: from loongson.cn (unknown [113.200.148.30]) by gateway (Coremail) with SMTP id _____8AxG_CVJ41miWsCAA--.7244S3; Tue, 09 Jul 2024 20:05:41 +0800 (CST) Received: from [10.130.0.149] (unknown [113.200.148.30]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxJMWUJ41m8QJBAA--.7892S3; Tue, 09 Jul 2024 20:05:41 +0800 (CST) Subject: Re: [PATCH v3 1/3] perf: Add perf_event_attr::bp_priv To: Will Deacon References: <20240709095506.9691-1-yangtiezhu@loongson.cn> <20240709095506.9691-2-yangtiezhu@loongson.cn> <20240709100304.GA12978@willie-the-truck> Cc: Mark Rutland , Russell King , Catalin Marinas , Oleg Nesterov , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org From: Tiezhu Yang Message-ID: <6d18e6fc-1d3f-f866-e887-bf5e01fb9368@loongson.cn> Date: Tue, 9 Jul 2024 20:05:40 +0800 User-Agent: Mozilla/5.0 (X11; Linux mips64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20240709100304.GA12978@willie-the-truck> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-CM-TRANSID: AQAAf8CxJMWUJ41m8QJBAA--.7892S3 X-CM-SenderInfo: p1dqw3xlh2x3gn0dqz5rrqw2lrqou0/ X-Coremail-Antispam: 1Uk129KBj93XoW7Cw17Gw4rtrykAr1fuFyxCrX_yoW8uF1xpr ZxCFn5K3yktry093ZrWwsrZryUXws29rWqg3W3Kw4Ykryav3s3G3ykWr909Fn5Zr1xAa4r twnFgFn8ta4UXagCm3ZEXasCq-sJn29KB7ZKAUJUUUUr529EdanIXcx71UUUUU7KY7ZEXa sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU 0xBIdaVrnRJUUUPIb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2 IYs7xG6rWj6s0DM7CIcVAFz4kK6r1Y6r17M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_JFI_Gr1l84ACjcxK6xIIjxv20xvEc7CjxVAFwI 0_Gr0_Cr1l84ACjcxK6I8E87Iv67AKxVW8Jr0_Cr1UM28EF7xvwVC2z280aVCY1x0267AK xVWxJr0_GcWln4kS14v26r1Y6r17M2AIxVAIcxkEcVAq07x20xvEncxIr21l57IF6xkI12 xvs2x26I8E6xACxx1l5I8CrVACY4xI64kE6c02F40Ex7xfMcIj6xIIjxv20xvE14v26r1Y 6r17McIj6I8E87Iv67AKxVW8JVWxJwAm72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IY64vIr4 1lc7I2V7IY0VAS07AlzVAYIcxG8wCY1x0262kKe7AKxVWUAVWUtwCF04k20xvY0x0EwIxG rwCFx2IqxVCFs4IE7xkEbVWUJVW8JwCFI7km07C267AKxVWUXVWUAwC20s026c02F40E14 v26r1j6r18MI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_Jw0_GFylIxkG c2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI 0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26r4j6F4U MIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0xZFpf9x07j7189UUU UU= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240709_130554_823516_81DAC365 X-CRM114-Status: GOOD ( 21.90 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 07/09/2024 06:03 PM, Will Deacon wrote: > On Tue, Jul 09, 2024 at 05:55:04PM +0800, Tiezhu Yang wrote: >> When developing hardware watchpoint on LoongArch, we want to set the >> same privilege passed by the ptrace user data, but there is no bridge >> to save this value like bp_addr, bp_type and bp_len. This is a common >> issue for the archs which have privilege level of breakpoint. >> >> Add a member "bp_priv" which lives in a union on config3 at the end >> of the uapi struct perf_event_attr to make a bridge between ptrace >> and hardware breakpoint. >> >> This is preparation for later patch on some archs such as ARM, ARM64 >> and LoongArch which have privilege level of breakpoint. >> >> Signed-off-by: Tiezhu Yang >> --- >> include/uapi/linux/perf_event.h | 5 ++++- >> kernel/events/hw_breakpoint.c | 1 + >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/include/uapi/linux/perf_event.h b/include/uapi/linux/perf_event.h >> index 3a64499b0f5d..abe8da7a1f60 100644 >> --- a/include/uapi/linux/perf_event.h >> +++ b/include/uapi/linux/perf_event.h >> @@ -521,7 +521,10 @@ struct perf_event_attr { >> */ >> __u64 sig_data; >> >> - __u64 config3; /* extension of config2 */ >> + union { >> + __u8 bp_priv; /* privilege level of breakpoint */ >> + __u64 config3; /* extension of config2 */ >> + }; >> }; >> >> /* >> diff --git a/kernel/events/hw_breakpoint.c b/kernel/events/hw_breakpoint.c >> index 6c2cb4e4f48d..3ad16b226e4f 100644 >> --- a/kernel/events/hw_breakpoint.c >> +++ b/kernel/events/hw_breakpoint.c >> @@ -754,6 +754,7 @@ static void hw_breakpoint_copy_attr(struct perf_event_attr *to, >> to->bp_addr = from->bp_addr; >> to->bp_type = from->bp_type; >> to->bp_len = from->bp_len; >> + to->bp_priv = from->bp_priv; >> to->disabled = from->disabled; >> } > > Sorry, but I still don't see why we should change uapi for this. As I > have said multiple times, this is unnecessary. Thanks for your review, I see your point but let us wait for more comments from perf people. Thanks, Tiezhu