From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E848CD128A for ; Wed, 10 Apr 2024 20:56:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EQ2KZ7RS2b8ZdAJ8lr7X+5tfXn3JexDrbTaPucSZCzs=; b=5G1zEHZaaEBu5u NRif71hXOAZCy+CRYyM/BxOkzAAilF4MR6a8DIMi2LPiUuVIujmSSF7aw72Ts7jRl6M3bVLkCFecX wB+59ONS5aqOLHnjHgPnzf2akH12BQX46kJZznCKdZYgWGgU7KgmL0sqtyXvWs5gPun7lP7zNR9re 3MnRvgD3gww6fsgsvw5DcpNoh1pt/LvErvn6/vWlCK6NxVD+prG3T4TrNI7yTmWygKLgTvWRuu+2x nAES6c2fBGuen/muBPl4QZ8G/pswxUW5xrH24AFQRot1SGmVhh6duqVIhAqwp0YHDvt0Hi8xwo0hT e7URwMXGkz8VEyDqLdOg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruezl-00000008v9Y-2geG; Wed, 10 Apr 2024 20:56:37 +0000 Received: from mail-lf1-x129.google.com ([2a00:1450:4864:20::129]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1ruezi-00000008v8E-24ng for linux-arm-kernel@lists.infradead.org; Wed, 10 Apr 2024 20:56:36 +0000 Received: by mail-lf1-x129.google.com with SMTP id 2adb3069b0e04-516ab4b3251so8152847e87.0 for ; Wed, 10 Apr 2024 13:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1712782592; x=1713387392; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=velTxyDyUhfVt0WKozw2xszoAn3uVnpWZ/SVMLGjm+c=; b=YQAqOd86D0ca4MaFRhGsDCCSedhQOtee7SaJgHx8TgouiPyn8VLI2GHkTWg0JmE6pa iKO3iSWoZfjYs3BYMqKPIMT48fmY3Mm1a3KZ8JImvd5JhzKBOwxVdW6ucgnd0RAbpHO8 rvyosiNtIv0rWVEckDh7NdBbLdQNPMLKqoTV399E8sBBBWGLht89qHVOQUH/xb4r+F0Y uinVIuV/wFLTXomIYpw/wTP1cPgp4T/w6w2d5SPbFPZHK93romVjtj8yQLXwbUtfAlfO JvqT+MtjJXwx58+OWhibPWuBAhRRb+RrMLP0HezghYL12A8GWCPBoMoWZjcPUo01XXql tmWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712782592; x=1713387392; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=velTxyDyUhfVt0WKozw2xszoAn3uVnpWZ/SVMLGjm+c=; b=rb1DOOo5PocdMV6vzU6YHZWon9DQpzAxzwGl6SUa6i8QCrf0cR/V2S/CWiHJ56w7mZ Op2rMq0JgI+SOc33mHy5MDoegSV0p004qXAUUB6puCfcPPqhDaQzx3q5Rxr+4GBykHks xbCdTXLCpY/HwHz2/Y8gSYAbICzkMXuGZXyx04vP4R7CkV9wZsGGp7uXS603+/eSQyU3 EyjhvZruDLbtS0TnLcT1Ljw1wlrdXdRi2TDC9H8AGIc5iRMld58zIbcSvngMXAEJIigb Fmuqt2r5asLCFX0jfztr8OL0u66xA42QlWAgr4Pj6pcdU59FXJeAiJq4+R71e4NqryXm 1lRg== X-Forwarded-Encrypted: i=1; AJvYcCWnhk673i2huYikQ6EGrwrhl0s0LoUmJjHV/vQaBXCteVm6GTTv57XDnnB3VaJqB0bp9MV/RI4C75JCnnX5T830g7dO49t5txUzFsIQtdEqsvhc+zA= X-Gm-Message-State: AOJu0YyIdwB93G68WDa6gVXhp8FloGJ/3ky67DnI8A282ivgdf+bbv1F euSyp3EEnErC+2pCcwOqRDdKZitXo/Omu8NL04jB8WN7Msx7RYRE X-Google-Smtp-Source: AGHT+IHU+2lp+CqY9Y0dbETJpEetgTV/6YxYcG7h5rkJpRV4Z3ndf35dDAQDagEP9Qz4ZQNHrtFv9w== X-Received: by 2002:a19:f50b:0:b0:513:aef9:7159 with SMTP id j11-20020a19f50b000000b00513aef97159mr2555020lfb.39.1712782592156; Wed, 10 Apr 2024 13:56:32 -0700 (PDT) Received: from [192.168.0.31] (84-115-213-64.cable.dynamic.surfer.at. [84.115.213.64]) by smtp.gmail.com with ESMTPSA id gv15-20020a170906f10f00b00a517995c070sm51166ejb.33.2024.04.10.13.56.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 10 Apr 2024 13:56:31 -0700 (PDT) Message-ID: <6d1f0fbf-ea53-47e2-92e5-131da010be0b@gmail.com> Date: Wed, 10 Apr 2024 22:56:29 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] dt-bindings: rtc: lpc32xx-rtc: convert to dtschema To: Alexandre Belloni Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jiaxun Yang , Vladimir Zapolskiy , Joel Stanley , Andrew Jeffery , Maxime Coquelin , Alexandre Torgue , linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-stm32@st-md-mailman.stormreply.com References: <20240410-rtc_dtschema-v2-0-d32a11ab0745@gmail.com> <20240410-rtc_dtschema-v2-2-d32a11ab0745@gmail.com> <202404102043571b7450b5@mail.local> Content-Language: en-US, de-AT From: Javier Carrasco In-Reply-To: <202404102043571b7450b5@mail.local> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240410_135634_708517_A8C604E9 X-CRM114-Status: GOOD ( 19.16 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/10/24 22:43, Alexandre Belloni wrote: > On 10/04/2024 17:55:34+0200, Javier Carrasco wrote: >> Convert existing binding to dtschema to support validation. >> >> Add the undocumented 'clocks' property. >> >> Signed-off-by: Javier Carrasco >> --- >> .../devicetree/bindings/rtc/lpc32xx-rtc.txt | 15 -------- >> .../devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml | 41 ++++++++++++++++++++++ >> 2 files changed, 41 insertions(+), 15 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt b/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt >> deleted file mode 100644 >> index a87a1e9bc060..000000000000 >> --- a/Documentation/devicetree/bindings/rtc/lpc32xx-rtc.txt >> +++ /dev/null >> @@ -1,15 +0,0 @@ >> -* NXP LPC32xx SoC Real Time Clock controller >> - >> -Required properties: >> -- compatible: must be "nxp,lpc3220-rtc" >> -- reg: physical base address of the controller and length of memory mapped >> - region. >> -- interrupts: The RTC interrupt >> - >> -Example: >> - >> - rtc@40024000 { >> - compatible = "nxp,lpc3220-rtc"; >> - reg = <0x40024000 0x1000>; >> - interrupts = <52 0>; >> - }; >> diff --git a/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml >> new file mode 100644 >> index 000000000000..62ddeef961e9 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/rtc/nxp,lpc32xx-rtc.yaml >> @@ -0,0 +1,41 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/rtc/nxp,lpc32xx-rtc.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: NXP LPC32xx SoC Real Time Clock >> + >> +maintainers: >> + - Javier Carrasco >> + >> +allOf: >> + - $ref: rtc.yaml# >> + >> +properties: >> + compatible: >> + const: nxp,lpc3220-rtc >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 > > As I explained the clock doesn't really exist, there is no control over > it, it is a fixed 32768 Hz crystal, there is no point in describing it > as this is already the input clock of the SoC. > > In that case the first approach was right, and it should be moved to trivial-rtc. I made the mistake of mentioning the driver and what it does not support, but strictly talking about the device description, the 'clocks' property was pointless in the dts where it was added. If we leave it undocumented, the error I discussed with Krzysztof will have to stay unless the 'clocks' property gets removed from the dts. Best regards, Javier Carrasco _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel