From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 873CDCED618 for ; Wed, 9 Oct 2024 07:23:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=teJTPtRRgJhpXeRenDVLI/Et/c/d1xs+s7uhazdPDm0=; b=U2lGBenItm6TzbWnNIehRrDq0e PybOMOd720fG68+8gkGJPrjsdGEV++TxAKAcrSoZJf7HXYM3l44ZgZjGADJwrkrCD5l5O3RAWoxyD Xc/dpi4+XLefg/TbunJpVmyvJWG/aJfu+RCONhTUWJJtcvaWGsO0zuQyzJuC9/K1kVN6diITGfhMX W1PZVkTK7+S77c6n5RQS8Txdper9S6YTOvnbm5E0T1+0r3vDTvnOt5kF2IJOl4VjqkhkkQKsEJsEh iKhxKcOpSx/D7PX3dsZGukIIBLG3pAhScFHQRJsmpMmfpBNIG8BGX5V7l8sptIRkf4qVK7gylm3J1 8h09ifkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1syR2y-00000008DQ8-3C6M; Wed, 09 Oct 2024 07:23:48 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1syR0Y-00000008D7a-0Efr; Wed, 09 Oct 2024 07:21:19 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1728458476; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=teJTPtRRgJhpXeRenDVLI/Et/c/d1xs+s7uhazdPDm0=; b=TyETTNC1zl05T201XgrXqx0D0KiRvUAaraRZz1XxXCWydv7LPMdASYegWv6IGRDtVaoLGs tiuV/8IpCRSNfO2LLkjevdVyE1tvGuiTgTiDkM2JqQTO2WeAqqzzz7N9sZcZDX2Xx2V746 UfLBTIQBGcmQe+KT3lbp3slxuEmupGZy2vwCa/1MiFd+kqXwzhjeTYGpkJ1dsRLQb/TZBf +llqIwgDWXO6qalY27My0UvrChQ+6722Sujlby0ilmmwernpZJyM3UEem/fBq6fqxUxuYS hHybBRsxtHmaa6vr6vkl+nbo/bceM8kBTr2ci3c8Nb6TUJpTOGialrGaGuly4A== Date: Wed, 09 Oct 2024 09:21:16 +0200 From: Dragan Simic To: Heiko Stuebner Cc: linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Sergey Bostandzhyan Subject: Re: [PATCH v2 08/14] arm64: dts: rockchip: remove num-slots property from rk3328-nanopi-r2s-plus In-Reply-To: <20241008203940.2573684-9-heiko@sntech.de> References: <20241008203940.2573684-1-heiko@sntech.de> <20241008203940.2573684-9-heiko@sntech.de> Message-ID: <6d5e661117f23aa85c3a874290ea336f@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241009_002118_303881_C2457BAA X-CRM114-Status: GOOD ( 13.92 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Heiko, On 2024-10-08 22:39, Heiko Stuebner wrote: > num-slots was not part of the dw-mmc binding and the last slipage of > one of them seeping in from the vendor kernel was removed way back in > 2017. Somehow the nanopi-r2s-plus managed to smuggle another on in the > kernel, so remove that as well. > > Fixes: b8c028782922 ("arm64: dts: rockchip: Add DTS for FriendlyARM > NanoPi R2S Plus") > Cc: Sergey Bostandzhyan > Signed-off-by: Heiko Stuebner Looking good to me, thanks for the patch. The introduced change is obviously correct. Reviewed-by: Dragan Simic > --- > arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > index 3093f607f282..4b9ced67742d 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3328-nanopi-r2s-plus.dts > @@ -24,7 +24,6 @@ &emmc { > disable-wp; > mmc-hs200-1_8v; > non-removable; > - num-slots = <1>; > pinctrl-names = "default"; > pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>; > status = "okay";