From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51647C43381 for ; Thu, 28 Feb 2019 14:38:34 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1EB502184A for ; Thu, 28 Feb 2019 14:38:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="iu20nWxJ"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="KSa4nP5p"; dkim=fail reason="key not found in DNS" (0-bit key) header.d=codeaurora.org header.i=@codeaurora.org header.b="dXhlmu8x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1EB502184A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FRFkQkipBCUVV6Q3vNu2/AWFATKVDxlP5I6n8xOdB+Y=; b=iu20nWxJnd9wJA w9oDLne9x/qeaIMsJ5XybgZ4BGsLHnutliQTVW41yZWtzfG8UjLttAQ/qer466A4LL3xvkAzWsP4J WYCxq5nZ2FiB7sa8p/AE4oEkilNbVqnzb9uORRAs8PFWd1TSpf3PfoAosqWLJOrM5N0wsNucUb5hN m24IOr/HStI5V/5q4ZYhdpFPI2oHf+LM+p3kVGJTtKwmcJsTze9YLvKBo36mVqwgfAA17epuL3uy1 kRbIcU6n2IEZ9WRMz1f+/wHSrilTtMzS3AZzJooh3jQVqzS1WL3TKqeQUCvgm95OiK/fMayKHEks9 swiBdImeVhs8YjzbN94Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzMpU-0001pq-GI; Thu, 28 Feb 2019 14:38:32 +0000 Received: from smtp.codeaurora.org ([198.145.29.96]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gzMpI-0001iy-A7 for linux-arm-kernel@lists.infradead.org; Thu, 28 Feb 2019 14:38:23 +0000 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 70A1560FEA; Thu, 28 Feb 2019 14:38:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551364699; bh=1dZ4j70oFdSuJpoShHSyxeTtRTbm9yCbpn1EoUE4SEU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=KSa4nP5pTIdnmcNKqJQJzESdE2m0HhuzNxWkEJ1PJBg6IsWyOgGGdDNqIcxZBaevk ip9JpDJD1dtRt6A6/EAh6mPNw17FuuUvnu4S16vfWSEQ7gtooWfYAeIk/1ZyBmno0S RKZMQNIf53kxEDVq+PZ3wYJVLWQWMo1q+yGGKKM0= Received: from [10.204.79.37] (blr-c-bdr-fw-01_globalnat_allzones-outside.qualcomm.com [103.229.19.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: clingutla@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id CAB62616B7; Thu, 28 Feb 2019 14:38:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1551364697; bh=1dZ4j70oFdSuJpoShHSyxeTtRTbm9yCbpn1EoUE4SEU=; h=Subject:To:Cc:References:From:Date:In-Reply-To:From; b=dXhlmu8xLNZPMDcoPZQYNa8rCEquUvOgY7zqlkDrW434xLRjUNoEAx0Zk70g4Jzu0 xZsKfZ/UpAQinzb+29GViAgNT7XT98IqJk9C8iix2BNY39IhYYLab0hEwK3XIZfWIG /fbi/17Tt1rwJPvIywwy8BQU7PUKk8rgZx/e9zYQ= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org CAB62616B7 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=clingutla@codeaurora.org Subject: Re: [PATCH] arch_topology: Update user supplied capacity to possible cpus in cluster To: Sudeep Holla References: <1551354838-29902-1-git-send-email-clingutla@codeaurora.org> <20190228121901.GA26207@e107155-lin> From: Chandra Sekhar Lingutla Message-ID: <6d7eb7cc-2453-3a7b-9163-ef9a5389220f@codeaurora.org> Date: Thu, 28 Feb 2019 20:08:13 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: <20190228121901.GA26207@e107155-lin> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190228_063820_485261_2BF31C58 X-CRM114-Status: GOOD ( 16.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: catalin.marinas@arm.com, will.deacon@arm.com, dietmar.eggemann@arm.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sudeep, On 2/28/2019 5:49 PM, Sudeep Holla wrote: > On Thu, Feb 28, 2019 at 05:23:58PM +0530, Lingutla Chandrasekhar wrote: >> With commit '5bdd2b3f0f8 ("arm64: topology: add support to remove cpu >> topology sibling masks")', when cpu hotplugged out, it resets the cpu >> information in its sibling CPUs. If user changes capacity of any cpu, >> then the new capacity applied to all online cpus in the cluster. >> > Correct but you are now changing to apply the same to all the CPUs > in the package which is wrong. > >> If any hot plugged out cpu in the same cluster comes back to online, >> then that would have different/stale capacity value. >> > Why not save the value ? Sorry, didn't get you, you mean save user supplied value ? > >> Fix it by applying user supplied capacity to all possible cpus in the >> cluster. >> > NACK for the change. It changes for all the CPUs in the package/socket. > Though DT platforms have cluster ids as package ids, that's wrong and > must be fixed. So you need to fix this issuw without depending on the > package id. I have removed all the wrong users of the same and this is > also a wrong usage. I presumed all cores with same package-id have same cpu capacity, so depended on it. I think, we can update the capacity of newly online cpu by reading its core_sibling cpu capacity. Let me know your opinion on this option ? > -- > Regards, > Sudeep -- Chandrasekhar L, QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel