Re: [PATCH 6/7] arm64: dts: amlogic: Add clock and EMMC for T7

[Krzysztof Kozlowski <krzk@kernel.org>]

On 18/02/2026 11:20, Ronald Claveau wrote:
> Add fixed clock and EMMC support for Amlogic T7 SoC family dtsi.
> 
> Signed-off-by: Ronald Claveau <linux-kernel-dev@aliel.fr>
> ---
>  arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi | 137 +++++++++++++++++++-
>  1 file changed, 134 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> index 6510068bcff9..e5932eb3db2b 100644
> --- a/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/amlogic-t7.dtsi
> @@ -3,6 +3,8 @@
>   * Copyright (c) 2019 Amlogic, Inc. All rights reserved.
>   */
>  
> +#include <dt-bindings/clock/amlogic,t7-peripherals-clkc.h>
> +#include <dt-bindings/clock/amlogic,t7-pll-clkc.h>
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/power/amlogic,t7-pwrc.h>
>  #include "amlogic-t7-reset.h"
> @@ -208,12 +210,14 @@ soc {
>  		ranges;
>  
>  		gic: interrupt-controller@fff01000 {
> -			compatible = "arm,gic-400";
> +			compatible = "arm,cortex-a15-gic", "arm,cortex-a9-gic";

I don't get how this is related to "Add fixed clock".

>  			#interrupt-cells = <3>;
>  			#address-cells = <0>;
>  			interrupt-controller;
>  			reg = <0x0 0xfff01000 0 0x1000>,
> -			      <0x0 0xfff02000 0 0x0100>;
> +				  <0x0 0xfff02000 0 0x2000>,
> +				  <0x0 0xfff04000 0 0x2000>,
> +				  <0x0 0xfff06000 0 0x2000>;

Neither this really.

...

> +
> +			sd_emmc_c: mmc@8c000{
> +				compatible = "amlogic,meson-axg-mmc";

Compatible says axg, DTS says T7, so something does not feel right.



Best regards,
Krzysztof