From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 903C7CD1288 for ; Wed, 3 Apr 2024 09:58:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1bikQti/EBRqMCU9md7KWyxyXPPnqXPglt/H2x71DtQ=; b=OlWFuXwJvuaQFS FXa6Gy2AZdJrAt041Lp9j3AVGdFF/pHVMfKcKutOFKYrUUl3i3/VDbK1kTyF/m/NtamLYpmBFMSLd h458bGMdCMWmMV5/suCUehykZ5iNfe+i29J1nK8S+Bi54umDNerjAqbHqRIndBacuSQZcS23TEXwj lefqp2sUiUtaZEmOKsbIcKgLOk2PAAieH/wCwTXCF6Nv7bAC+2XAEEN+G5hykS0rjh5sKNe3HMtjZ p8EM8aIIQ8b8WGlWS+abRa+ar8kiLI/OTbh2U0UMe19BZHDtPfjGDjbKXU+F4jnzZCGx1Co9TZB1Q G4C+QTBYww+Nebdj8nrA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrxO5-0000000FLIX-0tz7; Wed, 03 Apr 2024 09:58:33 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rrxO3-0000000FLGf-14Ys for linux-arm-kernel@lists.infradead.org; Wed, 03 Apr 2024 09:58:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 02B8A1007; Wed, 3 Apr 2024 02:58:59 -0700 (PDT) Received: from [10.57.73.155] (unknown [10.57.73.155]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id F05E63F64C; Wed, 3 Apr 2024 02:58:26 -0700 (PDT) Message-ID: <6d90b034-b91a-4e33-b728-b86261c050b0@arm.com> Date: Wed, 3 Apr 2024 10:58:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: remove redundant 'extern' Content-Language: en-GB To: Mark Rutland Cc: Catalin Marinas , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20240327112439.200455-1-steven.price@arm.com> From: Steven Price In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240403_025831_486213_433C114F X-CRM114-Status: GOOD ( 18.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 02/04/2024 11:01, Mark Rutland wrote: > On Wed, Mar 27, 2024 at 11:24:39AM +0000, Steven Price wrote: >> It isn't necessary to mark function definitions extern and goes against >> the kernel coding style. Remove the redundant extern keyword. >> >> Signed-off-by: Steven Price > > We (unfortunately) have extern misused in a number of places: > > | [mark@lakrids:~/src/linux]% git grep 'extern.*(' -- arch/arm64/include | cut -d: -f 1 | uniq -c > | 11 arch/arm64/include/asm/cacheflush.h > | 1 arch/arm64/include/asm/checksum.h > | 1 arch/arm64/include/asm/cpu_ops.h > | 4 arch/arm64/include/asm/cpufeature.h > | 2 arch/arm64/include/asm/efi.h > | 2 arch/arm64/include/asm/elf.h > | 1 arch/arm64/include/asm/exec.h > | 1 arch/arm64/include/asm/fixmap.h > | 48 arch/arm64/include/asm/fpsimd.h > | 3 arch/arm64/include/asm/ftrace.h > | 10 arch/arm64/include/asm/hugetlb.h > | 11 arch/arm64/include/asm/hw_breakpoint.h > | 6 arch/arm64/include/asm/io.h > | 4 arch/arm64/include/asm/kexec.h > | 1 arch/arm64/include/asm/kgdb.h > | 16 arch/arm64/include/asm/kvm_asm.h > | 3 arch/arm64/include/asm/kvm_host.h > | 11 arch/arm64/include/asm/kvm_hyp.h > | 2 arch/arm64/include/asm/kvm_pkvm.h > | 2 arch/arm64/include/asm/memory.h > | 8 arch/arm64/include/asm/mmu.h > | 2 arch/arm64/include/asm/page.h > | 1 arch/arm64/include/asm/percpu.h > | 2 arch/arm64/include/asm/perf_event.h > | 2 arch/arm64/include/asm/pgalloc.h > | 18 arch/arm64/include/asm/pgtable.h > | 3 arch/arm64/include/asm/pointer_auth.h > | 3 arch/arm64/include/asm/proc-fns.h > | 2 arch/arm64/include/asm/processor.h > | 3 arch/arm64/include/asm/ptrace.h > | 12 arch/arm64/include/asm/smp.h > | 1 arch/arm64/include/asm/stacktrace.h > | 14 arch/arm64/include/asm/string.h > | 2 arch/arm64/include/asm/suspend.h > | 1 arch/arm64/include/asm/system_misc.h > | 6 arch/arm64/include/asm/uaccess.h > > ... so it'd probably be best to make the commit title more specific to this > instance, and maybe go clean those up in bulk as a series to avoid a steady > stream of copycat patches. Ah, I hadn't gone looking that closely - I'll do a series updating the arch/arm64/include ones (thanks for the list ;) ), and I'll include an updated version of this patch, with a clearly commit title, in the series. Thanks, Steve > Mark. > >> --- >> arch/arm64/include/asm/fixmap.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/include/asm/fixmap.h b/arch/arm64/include/asm/fixmap.h >> index 87e307804b99..75b22b89db1a 100644 >> --- a/arch/arm64/include/asm/fixmap.h >> +++ b/arch/arm64/include/asm/fixmap.h >> @@ -107,7 +107,7 @@ void __init early_fixmap_init(void); >> #define __late_set_fixmap __set_fixmap >> #define __late_clear_fixmap(idx) __set_fixmap((idx), 0, FIXMAP_PAGE_CLEAR) >> >> -extern void __set_fixmap(enum fixed_addresses idx, phys_addr_t phys, pgprot_t prot); >> +void __set_fixmap(enum fixed_addresses idx, phys_addr_t phys, pgprot_t prot); >> >> #include >> >> -- >> 2.34.1 >> >> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel