From: Sjoerd Simons <sjoerd@collabora.com>
To: Peter Collingbourne <peter@pcc.me.uk>
Cc: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: mediatek: mt7981b: Add PMU
Date: Tue, 05 May 2026 08:49:31 +0200 [thread overview]
Message-ID: <6dbefb2c80964c0394771ae11fd0f9e05486db29.camel@collabora.com> (raw)
In-Reply-To: <20260502074912.12193-1-peter@pcc.me.uk>
On Sat, 2026-05-02 at 00:49 -0700, Peter Collingbourne wrote:
> The interrupt number was taken from a downstream DTS of the similar MT7987
> [1] and verified on my OpenWrt One.
>
> Signed-off-by: Peter Collingbourne <peter@pcc.me.uk>
> Link: [1]
> https://github.com/openwrt/openwrt/blob/e4b3d5c799aef3be20b7f6079e8e5a14b215c116/target/linux/mediatek/dts/mt7987.dtsi#L246
> ---
> arch/arm64/boot/dts/mediatek/mt7981b.dtsi | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> index 4084f4dfa3e5..3c6fbb6c5333 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b.dtsi
> @@ -38,6 +38,12 @@ oscillator-40m {
> #clock-cells = <0>;
> };
>
> + pmu {
> + compatible = "arm,cortex-a53-pmu";
> + interrupt-parent = <&gic>;
The parent node already specifies the interrupt-parent, so this is redundant.
> + interrupts = <GIC_PPI 7 IRQ_TYPE_LEVEL_LOW>;
> + };
> +
Otherwise looks good
Regards,
--
Sjoerd Simons
Collabora
prev parent reply other threads:[~2026-05-05 6:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-02 7:49 [PATCH] arm64: dts: mediatek: mt7981b: Add PMU Peter Collingbourne
2026-05-05 6:49 ` Sjoerd Simons [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6dbefb2c80964c0394771ae11fd0f9e05486db29.camel@collabora.com \
--to=sjoerd@collabora.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=peter@pcc.me.uk \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox